You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/24 09:37:14 UTC
[GitHub] [airflow] malagoli opened a new pull request #7849: [AIRFLOW-7106]
Cloud data fusion integration - Allow to pass args to start pipeline
malagoli opened a new pull request #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline
URL: https://github.com/apache/airflow/pull/7849
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [X ] Description above provides context of the change
- [X ] Unit tests coverage for changes (not needed for documentation changes)
- [ X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] turbaszek commented on a change in pull request #7849:
[AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start
pipeline
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline
URL: https://github.com/apache/airflow/pull/7849#discussion_r399059972
##########
File path: tests/conftest.py
##########
@@ -131,8 +131,9 @@ def breeze_test_helper(request):
# Setup test environment for breeze
home = os.path.expanduser("~")
airflow_home = os.environ.get("AIRFLOW_HOME") or os.path.join(home, "airflow")
+ print(airflow_home)
- print(f"Home of the user: {home}\nAirflow home {airflow_home}")
+ #print(f"Home of the user: {home}\nAirflow home {airflow_home}")
Review comment:
This seems to be unrelated change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] turbaszek merged pull request #7849: [AIRFLOW-7106] Cloud
data fusion integration - Allow to pass args to start pipeline
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline
URL: https://github.com/apache/airflow/pull/7849
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] malagoli commented on a change in pull request #7849:
[AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start
pipeline
Posted by GitBox <gi...@apache.org>.
malagoli commented on a change in pull request #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline
URL: https://github.com/apache/airflow/pull/7849#discussion_r399965638
##########
File path: tests/conftest.py
##########
@@ -131,8 +131,9 @@ def breeze_test_helper(request):
# Setup test environment for breeze
home = os.path.expanduser("~")
airflow_home = os.environ.get("AIRFLOW_HOME") or os.path.join(home, "airflow")
+ print(airflow_home)
- print(f"Home of the user: {home}\nAirflow home {airflow_home}")
+ #print(f"Home of the user: {home}\nAirflow home {airflow_home}")
Review comment:
correct, my fault. fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7849:
[AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start
pipeline
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline
URL: https://github.com/apache/airflow/pull/7849#issuecomment-603132041
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7849: [AIRFLOW-7106] Cloud
data fusion integration - Allow to pass args to start pipeline
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline
URL: https://github.com/apache/airflow/pull/7849#issuecomment-603153153
@turbaszek ? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] turbaszek commented on issue #7849: [AIRFLOW-7106] Cloud
data fusion integration - Allow to pass args to start pipeline
Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline
URL: https://github.com/apache/airflow/pull/7849#issuecomment-606143585
It seems that Travis is sad because static code checks are failing. You may find this useful: https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] malagoli commented on issue #7849: [AIRFLOW-7106] Cloud
data fusion integration - Allow to pass args to start pipeline
Posted by GitBox <gi...@apache.org>.
malagoli commented on issue #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline
URL: https://github.com/apache/airflow/pull/7849#issuecomment-609597156
@turbaszek all travis checks passed, any change to merge?
thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] malagoli commented on a change in pull request #7849:
[AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start
pipeline
Posted by GitBox <gi...@apache.org>.
malagoli commented on a change in pull request #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline
URL: https://github.com/apache/airflow/pull/7849#discussion_r398669775
##########
File path: airflow/providers/google/cloud/hooks/datafusion.py
##########
@@ -397,7 +400,13 @@ def start_pipeline(
"DataPipelineWorkflow",
"start",
)
- response = self._cdap_request(url=url, method="POST")
+
+ if runtime_args != None:
+ args = ast.literal_eval(runtime_args)
+ else:
+ args = None
+
+ response = self._cdap_request(url=url, method="POST", body=args)
Review comment:
thanks turbaszek, you are right.
I've updated from string to dict, updated also tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] turbaszek commented on a change in pull request #7849:
[AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start
pipeline
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline
URL: https://github.com/apache/airflow/pull/7849#discussion_r397064575
##########
File path: airflow/providers/google/cloud/hooks/datafusion.py
##########
@@ -397,7 +400,13 @@ def start_pipeline(
"DataPipelineWorkflow",
"start",
)
- response = self._cdap_request(url=url, method="POST")
+
+ if runtime_args != None:
+ args = ast.literal_eval(runtime_args)
+ else:
+ args = None
+
+ response = self._cdap_request(url=url, method="POST", body=args)
Review comment:
Why pass `runtime_args` as a string? Can't we use `dict`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] malagoli commented on issue #7849: [AIRFLOW-7106] Cloud
data fusion integration - Allow to pass args to start pipeline
Posted by GitBox <gi...@apache.org>.
malagoli commented on issue #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline
URL: https://github.com/apache/airflow/pull/7849#issuecomment-606625491
fixed also all static checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] turbaszek commented on a change in pull request #7849:
[AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start
pipeline
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline
URL: https://github.com/apache/airflow/pull/7849#discussion_r399060134
##########
File path: airflow/providers/google/cloud/hooks/datafusion.py
##########
@@ -381,6 +382,8 @@ def start_pipeline(
:type pipeline_name: str
:param instance_url: Endpoint on which the REST APIs is accessible for the instance.
:type instance_url: str
+ :param runtime_args: Optional runtime JSON args to be passed to the pipeline
+ :type runtime_args: dict
Review comment:
```suggestion
:type runtime_args: Optional[Dict[str, Any]]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7849:
[AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start
pipeline
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline
URL: https://github.com/apache/airflow/pull/7849#issuecomment-609642424
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services