You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/14 22:46:58 UTC
[jira] [Commented] (BEAM-1154) ReduceFnRunner fetches side input
from the wrong window
[ https://issues.apache.org/jira/browse/BEAM-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749748#comment-15749748 ]
ASF GitHub Bot commented on BEAM-1154:
--------------------------------------
GitHub user jkff opened a pull request:
https://github.com/apache/incubator-beam/pull/1620
[BEAM-1154] Get side input from proper window in ReduceFn
R: @kennknowles
CC: @peihe
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkff/incubator-beam combine-side-input
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1620.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1620
----
commit 38bca062b99900f44321035d660fa9b63f5179b4
Author: Eugene Kirpichov <ki...@google.com>
Date: 2016-12-14T22:29:30Z
[BEAM-1154] Get side input from proper window in ReduceFn
----
> ReduceFnRunner fetches side input from the wrong window
> -------------------------------------------------------
>
> Key: BEAM-1154
> URL: https://issues.apache.org/jira/browse/BEAM-1154
> Project: Beam
> Issue Type: Bug
> Reporter: Eugene Kirpichov
> Assignee: Eugene Kirpichov
>
> This https://github.com/apache/incubator-beam/blame/master/runners/core-java/src/main/java/org/apache/beam/runners/core/ReduceFnContextFactory.java#L529 is incorrect - I broke it in https://github.com/apache/incubator-beam/commit/90a0d0e13fa0332df805b79b1dc64860d9590217#diff-16edced77586e39a5f31907f4ced51b5R530
> It uses windowing strategy of the main input to do .getSideInputWindow() instead of windowing strategy of the side input.
> The fix is very simple; trying to come up with a test...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)