You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/06/27 07:48:52 UTC
[GitHub] [kafka] Smeb opened a new pull request, #12352: KAFKA-13978: Don't skip exceptions in Kafka streams custom handlers
Smeb opened a new pull request, #12352:
URL: https://github.com/apache/kafka/pull/12352
Previously `IllegalArgumentException` and `IllegalStateException` errors would always trigger an application shutdown. With this change those errors are treated the same as all other exceptions thrown while an application processes a stream, and are processed by the registered uncaught exception handler.
Tested using unit and integration tests. Since this is removing a feature, no new tests were added.
### Committer Checklist (excluded from commit message)
- [x] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #12352: KAFKA-13978: Don't skip exceptions in Kafka streams custom handlers
Posted by GitBox <gi...@apache.org>.
ijuma commented on PR #12352:
URL: https://github.com/apache/kafka/pull/12352#issuecomment-1210956343
Removing the 3.3 label given the comment from @vvcephei. If it is a blocker for 3.3, please provide the rationale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Smeb commented on pull request #12352: KAFKA-13978: Don't skip exceptions in Kafka streams custom handlers
Posted by GitBox <gi...@apache.org>.
Smeb commented on PR #12352:
URL: https://github.com/apache/kafka/pull/12352#issuecomment-1227710135
Looks like it was removed in #12421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jsancio commented on pull request #12352: KAFKA-13978: Don't skip exceptions in Kafka streams custom handlers
Posted by GitBox <gi...@apache.org>.
jsancio commented on PR #12352:
URL: https://github.com/apache/kafka/pull/12352#issuecomment-1206418659
@Smeb This is marked as a blocker for 3.3.0. It looks like there are merge conflicts with trunk. Let's find a committer to review this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #12352: KAFKA-13978: Don't skip exceptions in Kafka streams custom handlers
Posted by GitBox <gi...@apache.org>.
vvcephei commented on PR #12352:
URL: https://github.com/apache/kafka/pull/12352#issuecomment-1210796778
Hey @Smeb , I just checked trunk and 3.3, and I don't see the code that you're removing in your PR. It seems like someone else may have fixed this issue in the mean time. Can you confirm whether or not the issue is resolved?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Smeb commented on pull request #12352: KAFKA-13978: Don't skip exceptions in Kafka streams custom handlers
Posted by GitBox <gi...@apache.org>.
Smeb commented on PR #12352:
URL: https://github.com/apache/kafka/pull/12352#issuecomment-1167014927
CI appears to timeout but I don't see how it could be related to my changes - I can also see that's the case for a lot of other PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Smeb closed pull request #12352: KAFKA-13978: Don't skip exceptions in Kafka streams custom handlers
Posted by GitBox <gi...@apache.org>.
Smeb closed pull request #12352: KAFKA-13978: Don't skip exceptions in Kafka streams custom handlers
URL: https://github.com/apache/kafka/pull/12352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org