You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@freemarker.apache.org by Daniel Dekany <dd...@apache.org> on 2021/02/09 22:19:49 UTC
[VOTE] Release Apache FreeMarker 2.3.31
Hi all,
Please vote on releasing FreeMarker 2.3.31!
As there were changes in the last few days, don't skip testing with
your dependent projects, even if you already did it recently.
Release Notes:
https://freemarker.apache.org/builds/2.3.31-voting/versions_2_3_31.html
Before proceed, you should know that FreeMarker 2.3.x, for a long
time, always releases a normal and a "gae" variant on the same time,
which are technically two independent source trees (Git branches). The
"gae" variant contains a few small modification in the Java source
code to be Google App Engine compliant, and has freemarker-gae as the
Maven artifact name. Otherwise the normal and the "gae" branches are
identical. Hence they will be voted on together.
The commits to be voted upon are:
- Normal (non-gae) variant:
https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=f2308d4b4c242901e6a0e71cb12082243479f69c
Commit hash: f2308d4b4c242901e6a0e71cb12082243479f69c
- "gae" variant:
https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=8d15d85c70df172e5c8ad64f6ba05d52dcac663c
Commit hash: 8d15d85c70df172e5c8ad64f6ba05d52dcac663c
The artifacts to be voted upon are located here:
https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.31/source/
where the source release artifacts are:
- Normal (non-gae) variant:
apache-freemarker-2.3.31-src.tar.gz
- "gae" variant:
apache-freemarker-gae-2.3.31-src.tar.gz
See the README.md inside them for build instructions!
The release artifacts are signed with the following key:
https://people.apache.org/keys/committer/ddekany.asc
For convenience, we also provide binaries, which also need to be checked:
https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.31/binaries/
and Maven artifacts in the ASF Staging Repository:
https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.31/
Please try out the package and vote!
The vote is open for a minimum of 72 hours or until the necessary number of
votes (3 binding +1s) is reached.
[ ] +1 Release this package as Apache FreeMarker 2.3.31
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...
Please add "(binding)" if your vote is binding.
--
Thanks,
Daniel Dekany
Re: [VOTE] Release Apache FreeMarker 2.3.31
Posted by Justin Mclean <jm...@apache.org>.
Hi,
Just a really minor trivial thing, for your next release you might want to update the year in the NOTICE file to include the current year.
Thanks,
Justin
Re: [VOTE] Release Apache FreeMarker 2.3.31
Posted by Jacopo Cappellato <ja...@gmail.com>.
+1 (binding)
checksum, signature, build and tests are all successful.
Jacopo Cappellato
On Tue, Feb 9, 2021 at 11:20 PM Daniel Dekany <dd...@apache.org> wrote:
>
> Hi all,
>
> Please vote on releasing FreeMarker 2.3.31!
>
> As there were changes in the last few days, don't skip testing with
> your dependent projects, even if you already did it recently.
>
> Release Notes:
> https://freemarker.apache.org/builds/2.3.31-voting/versions_2_3_31.html
>
> Before proceed, you should know that FreeMarker 2.3.x, for a long
> time, always releases a normal and a "gae" variant on the same time,
> which are technically two independent source trees (Git branches). The
> "gae" variant contains a few small modification in the Java source
> code to be Google App Engine compliant, and has freemarker-gae as the
> Maven artifact name. Otherwise the normal and the "gae" branches are
> identical. Hence they will be voted on together.
>
> The commits to be voted upon are:
> - Normal (non-gae) variant:
>
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=f2308d4b4c242901e6a0e71cb12082243479f69c
> Commit hash: f2308d4b4c242901e6a0e71cb12082243479f69c
> - "gae" variant:
>
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=8d15d85c70df172e5c8ad64f6ba05d52dcac663c
> Commit hash: 8d15d85c70df172e5c8ad64f6ba05d52dcac663c
>
> The artifacts to be voted upon are located here:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.31/source/
> where the source release artifacts are:
> - Normal (non-gae) variant:
> apache-freemarker-2.3.31-src.tar.gz
> - "gae" variant:
> apache-freemarker-gae-2.3.31-src.tar.gz
>
> See the README.md inside them for build instructions!
>
> The release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/ddekany.asc
>
> For convenience, we also provide binaries, which also need to be checked:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.31/binaries/
> and Maven artifacts in the ASF Staging Repository:
> https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.31/
>
> Please try out the package and vote!
>
> The vote is open for a minimum of 72 hours or until the necessary number of
> votes (3 binding +1s) is reached.
>
> [ ] +1 Release this package as Apache FreeMarker 2.3.31
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Please add "(binding)" if your vote is binding.
>
> --
> Thanks,
> Daniel Dekany
Re: [VOTE] Release Apache FreeMarker 2.3.31
Posted by Daniel Dekany <dd...@apache.org>.
+1 (binding)
I was the release engineer, and didn't notice anything out of order.
I also tested the release with FMPP (test suite passes), and Docgen
(generates exactly the same output for the FreeMarker Manual).
On Tue, Feb 9, 2021 at 11:19 PM Daniel Dekany <dd...@apache.org> wrote:
> Hi all,
>
> Please vote on releasing FreeMarker 2.3.31!
>
> As there were changes in the last few days, don't skip testing with
> your dependent projects, even if you already did it recently.
>
> Release Notes:
> https://freemarker.apache.org/builds/2.3.31-voting/versions_2_3_31.html
>
> Before proceed, you should know that FreeMarker 2.3.x, for a long
> time, always releases a normal and a "gae" variant on the same time,
> which are technically two independent source trees (Git branches). The
> "gae" variant contains a few small modification in the Java source
> code to be Google App Engine compliant, and has freemarker-gae as the
> Maven artifact name. Otherwise the normal and the "gae" branches are
> identical. Hence they will be voted on together.
>
> The commits to be voted upon are:
> - Normal (non-gae) variant:
>
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=f2308d4b4c242901e6a0e71cb12082243479f69c
> Commit hash: f2308d4b4c242901e6a0e71cb12082243479f69c
> - "gae" variant:
>
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=8d15d85c70df172e5c8ad64f6ba05d52dcac663c
> Commit hash: 8d15d85c70df172e5c8ad64f6ba05d52dcac663c
>
> The artifacts to be voted upon are located here:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.31/source/
> where the source release artifacts are:
> - Normal (non-gae) variant:
> apache-freemarker-2.3.31-src.tar.gz
> - "gae" variant:
> apache-freemarker-gae-2.3.31-src.tar.gz
>
> See the README.md inside them for build instructions!
>
> The release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/ddekany.asc
>
> For convenience, we also provide binaries, which also need to be checked:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.31/binaries/
> and Maven artifacts in the ASF Staging Repository:
>
> https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.31/
>
> Please try out the package and vote!
>
> The vote is open for a minimum of 72 hours or until the necessary number of
> votes (3 binding +1s) is reached.
>
> [ ] +1 Release this package as Apache FreeMarker 2.3.31
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Please add "(binding)" if your vote is binding.
>
> --
> Thanks,
> Daniel Dekany
>
Re: [VOTE] Release Apache FreeMarker 2.3.31
Posted by Jacques Le Roux <ja...@les7arts.com>.
+1 (binding)
Tested in OFBiz trunk HEAD, UI and console OK. I even spotted an old small issue in log that did not show before :)
Jacques
Le 13/02/2021 à 12:31, Siegfried Goeschl a écrit :
> +1 (non-binding)
>
> Tested with freemarker-generator
>
> Thanks in advance,
>
> Siegfried Goeschl
>
>
>> On 12.02.2021, at 20:12, Christoph Rüger <c....@synesty.com> wrote:
>>
>> +1 (non-binding)
>>
>> Verified running our testsuite containing some FM related tests
>> with org.freemarker.freemarker-2.3.31.jar .
>> no regression found, all testcases successful.
>>
>> Regards
>> Christoph
>>
>> Am Mi., 10. Feb. 2021 um 23:51 Uhr schrieb Woonsan Ko <wo...@apache.org>:
>>
>>> +1 (binding)
>>>
>>> Verified the following:
>>> - gpg --verify with the .asc files: OK
>>> - sha512 checksums: OK
>>> - builds and artifacts in both "normal" and "gae": OK
>>> (ant, ant test, ant javadoc, ant manualOffline, ant maven-install)
>>> - testing in a CMS product with the freemarker-2.3.31.jar: OK
>>>
>>> Regards,
>>>
>>> Woonsan
>>>
>>>
>>> On Tue, Feb 9, 2021 at 5:20 PM Daniel Dekany <dd...@apache.org> wrote:
>>>> Hi all,
>>>>
>>>> Please vote on releasing FreeMarker 2.3.31!
>>>>
>>>> As there were changes in the last few days, don't skip testing with
>>>> your dependent projects, even if you already did it recently.
>>>>
>>>> Release Notes:
>>>> https://freemarker.apache.org/builds/2.3.31-voting/versions_2_3_31.html
>>>>
>>>> Before proceed, you should know that FreeMarker 2.3.x, for a long
>>>> time, always releases a normal and a "gae" variant on the same time,
>>>> which are technically two independent source trees (Git branches). The
>>>> "gae" variant contains a few small modification in the Java source
>>>> code to be Google App Engine compliant, and has freemarker-gae as the
>>>> Maven artifact name. Otherwise the normal and the "gae" branches are
>>>> identical. Hence they will be voted on together.
>>>>
>>>> The commits to be voted upon are:
>>>> - Normal (non-gae) variant:
>>>>
>>>>
>>> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=f2308d4b4c242901e6a0e71cb12082243479f69c
>>>> Commit hash: f2308d4b4c242901e6a0e71cb12082243479f69c
>>>> - "gae" variant:
>>>>
>>>>
>>> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=8d15d85c70df172e5c8ad64f6ba05d52dcac663c
>>>> Commit hash: 8d15d85c70df172e5c8ad64f6ba05d52dcac663c
>>>>
>>>> The artifacts to be voted upon are located here:
>>>> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.31/source/
>>>> where the source release artifacts are:
>>>> - Normal (non-gae) variant:
>>>> apache-freemarker-2.3.31-src.tar.gz
>>>> - "gae" variant:
>>>> apache-freemarker-gae-2.3.31-src.tar.gz
>>>>
>>>> See the README.md inside them for build instructions!
>>>>
>>>> The release artifacts are signed with the following key:
>>>> https://people.apache.org/keys/committer/ddekany.asc
>>>>
>>>> For convenience, we also provide binaries, which also need to be checked:
>>>>
>>> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.31/binaries/
>>>> and Maven artifacts in the ASF Staging Repository:
>>>>
>>> https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.31/
>>>> Please try out the package and vote!
>>>>
>>>> The vote is open for a minimum of 72 hours or until the necessary number
>>> of
>>>> votes (3 binding +1s) is reached.
>>>>
>>>> [ ] +1 Release this package as Apache FreeMarker 2.3.31
>>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release
>>>> [ ] -1 Do not release this package because...
>>>>
>>>> Please add "(binding)" if your vote is binding.
>>>>
>>>> --
>>>> Thanks,
>>>> Daniel Dekany
>> --
>> Synesty GmbH
>> Moritz-von-Rohr-Str. 1a
>> 07745 Jena
>> Tel.: +49 3641
>> 5596493Internet: https://synesty.com <https://synesty.com>
>> Informationen
>> zum Datenschutz: https://synesty.com/datenschutz
>> <https://synesty.com/datenschutz>
>>
>> Geschäftsführer: Christoph Rüger
>> Unternehmenssitz: Jena
>> Handelsregister B beim Amtsgericht: Jena
>> Handelsregister-Nummer: HRB 508766
>> Ust-IdNr.: DE287564982
Re: [VOTE] Release Apache FreeMarker 2.3.31
Posted by Siegfried Goeschl <si...@gmail.com>.
+1 (non-binding)
Tested with freemarker-generator
Thanks in advance,
Siegfried Goeschl
> On 12.02.2021, at 20:12, Christoph Rüger <c....@synesty.com> wrote:
>
> +1 (non-binding)
>
> Verified running our testsuite containing some FM related tests
> with org.freemarker.freemarker-2.3.31.jar .
> no regression found, all testcases successful.
>
> Regards
> Christoph
>
> Am Mi., 10. Feb. 2021 um 23:51 Uhr schrieb Woonsan Ko <wo...@apache.org>:
>
>> +1 (binding)
>>
>> Verified the following:
>> - gpg --verify with the .asc files: OK
>> - sha512 checksums: OK
>> - builds and artifacts in both "normal" and "gae": OK
>> (ant, ant test, ant javadoc, ant manualOffline, ant maven-install)
>> - testing in a CMS product with the freemarker-2.3.31.jar: OK
>>
>> Regards,
>>
>> Woonsan
>>
>>
>> On Tue, Feb 9, 2021 at 5:20 PM Daniel Dekany <dd...@apache.org> wrote:
>>>
>>> Hi all,
>>>
>>> Please vote on releasing FreeMarker 2.3.31!
>>>
>>> As there were changes in the last few days, don't skip testing with
>>> your dependent projects, even if you already did it recently.
>>>
>>> Release Notes:
>>> https://freemarker.apache.org/builds/2.3.31-voting/versions_2_3_31.html
>>>
>>> Before proceed, you should know that FreeMarker 2.3.x, for a long
>>> time, always releases a normal and a "gae" variant on the same time,
>>> which are technically two independent source trees (Git branches). The
>>> "gae" variant contains a few small modification in the Java source
>>> code to be Google App Engine compliant, and has freemarker-gae as the
>>> Maven artifact name. Otherwise the normal and the "gae" branches are
>>> identical. Hence they will be voted on together.
>>>
>>> The commits to be voted upon are:
>>> - Normal (non-gae) variant:
>>>
>>>
>> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=f2308d4b4c242901e6a0e71cb12082243479f69c
>>> Commit hash: f2308d4b4c242901e6a0e71cb12082243479f69c
>>> - "gae" variant:
>>>
>>>
>> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=8d15d85c70df172e5c8ad64f6ba05d52dcac663c
>>> Commit hash: 8d15d85c70df172e5c8ad64f6ba05d52dcac663c
>>>
>>> The artifacts to be voted upon are located here:
>>> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.31/source/
>>> where the source release artifacts are:
>>> - Normal (non-gae) variant:
>>> apache-freemarker-2.3.31-src.tar.gz
>>> - "gae" variant:
>>> apache-freemarker-gae-2.3.31-src.tar.gz
>>>
>>> See the README.md inside them for build instructions!
>>>
>>> The release artifacts are signed with the following key:
>>> https://people.apache.org/keys/committer/ddekany.asc
>>>
>>> For convenience, we also provide binaries, which also need to be checked:
>>>
>> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.31/binaries/
>>> and Maven artifacts in the ASF Staging Repository:
>>>
>> https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.31/
>>>
>>> Please try out the package and vote!
>>>
>>> The vote is open for a minimum of 72 hours or until the necessary number
>> of
>>> votes (3 binding +1s) is reached.
>>>
>>> [ ] +1 Release this package as Apache FreeMarker 2.3.31
>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release
>>> [ ] -1 Do not release this package because...
>>>
>>> Please add "(binding)" if your vote is binding.
>>>
>>> --
>>> Thanks,
>>> Daniel Dekany
>
> --
> Synesty GmbH
> Moritz-von-Rohr-Str. 1a
> 07745 Jena
> Tel.: +49 3641
> 5596493Internet: https://synesty.com <https://synesty.com>
> Informationen
> zum Datenschutz: https://synesty.com/datenschutz
> <https://synesty.com/datenschutz>
>
> Geschäftsführer: Christoph Rüger
> Unternehmenssitz: Jena
> Handelsregister B beim Amtsgericht: Jena
> Handelsregister-Nummer: HRB 508766
> Ust-IdNr.: DE287564982
Re: [VOTE] Release Apache FreeMarker 2.3.31
Posted by Christoph Rüger <c....@synesty.com>.
+1 (non-binding)
Verified running our testsuite containing some FM related tests
with org.freemarker.freemarker-2.3.31.jar .
no regression found, all testcases successful.
Regards
Christoph
Am Mi., 10. Feb. 2021 um 23:51 Uhr schrieb Woonsan Ko <wo...@apache.org>:
> +1 (binding)
>
> Verified the following:
> - gpg --verify with the .asc files: OK
> - sha512 checksums: OK
> - builds and artifacts in both "normal" and "gae": OK
> (ant, ant test, ant javadoc, ant manualOffline, ant maven-install)
> - testing in a CMS product with the freemarker-2.3.31.jar: OK
>
> Regards,
>
> Woonsan
>
>
> On Tue, Feb 9, 2021 at 5:20 PM Daniel Dekany <dd...@apache.org> wrote:
> >
> > Hi all,
> >
> > Please vote on releasing FreeMarker 2.3.31!
> >
> > As there were changes in the last few days, don't skip testing with
> > your dependent projects, even if you already did it recently.
> >
> > Release Notes:
> > https://freemarker.apache.org/builds/2.3.31-voting/versions_2_3_31.html
> >
> > Before proceed, you should know that FreeMarker 2.3.x, for a long
> > time, always releases a normal and a "gae" variant on the same time,
> > which are technically two independent source trees (Git branches). The
> > "gae" variant contains a few small modification in the Java source
> > code to be Google App Engine compliant, and has freemarker-gae as the
> > Maven artifact name. Otherwise the normal and the "gae" branches are
> > identical. Hence they will be voted on together.
> >
> > The commits to be voted upon are:
> > - Normal (non-gae) variant:
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=f2308d4b4c242901e6a0e71cb12082243479f69c
> > Commit hash: f2308d4b4c242901e6a0e71cb12082243479f69c
> > - "gae" variant:
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=8d15d85c70df172e5c8ad64f6ba05d52dcac663c
> > Commit hash: 8d15d85c70df172e5c8ad64f6ba05d52dcac663c
> >
> > The artifacts to be voted upon are located here:
> > https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.31/source/
> > where the source release artifacts are:
> > - Normal (non-gae) variant:
> > apache-freemarker-2.3.31-src.tar.gz
> > - "gae" variant:
> > apache-freemarker-gae-2.3.31-src.tar.gz
> >
> > See the README.md inside them for build instructions!
> >
> > The release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/ddekany.asc
> >
> > For convenience, we also provide binaries, which also need to be checked:
> >
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.31/binaries/
> > and Maven artifacts in the ASF Staging Repository:
> >
> https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.31/
> >
> > Please try out the package and vote!
> >
> > The vote is open for a minimum of 72 hours or until the necessary number
> of
> > votes (3 binding +1s) is reached.
> >
> > [ ] +1 Release this package as Apache FreeMarker 2.3.31
> > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
> >
> > Please add "(binding)" if your vote is binding.
> >
> > --
> > Thanks,
> > Daniel Dekany
--
Synesty GmbH
Moritz-von-Rohr-Str. 1a
07745 Jena
Tel.: +49 3641
5596493Internet: https://synesty.com <https://synesty.com>
Informationen
zum Datenschutz: https://synesty.com/datenschutz
<https://synesty.com/datenschutz>
Geschäftsführer: Christoph Rüger
Unternehmenssitz: Jena
Handelsregister B beim Amtsgericht: Jena
Handelsregister-Nummer: HRB 508766
Ust-IdNr.: DE287564982
Re: [VOTE] Release Apache FreeMarker 2.3.31
Posted by Woonsan Ko <wo...@apache.org>.
+1 (binding)
Verified the following:
- gpg --verify with the .asc files: OK
- sha512 checksums: OK
- builds and artifacts in both "normal" and "gae": OK
(ant, ant test, ant javadoc, ant manualOffline, ant maven-install)
- testing in a CMS product with the freemarker-2.3.31.jar: OK
Regards,
Woonsan
On Tue, Feb 9, 2021 at 5:20 PM Daniel Dekany <dd...@apache.org> wrote:
>
> Hi all,
>
> Please vote on releasing FreeMarker 2.3.31!
>
> As there were changes in the last few days, don't skip testing with
> your dependent projects, even if you already did it recently.
>
> Release Notes:
> https://freemarker.apache.org/builds/2.3.31-voting/versions_2_3_31.html
>
> Before proceed, you should know that FreeMarker 2.3.x, for a long
> time, always releases a normal and a "gae" variant on the same time,
> which are technically two independent source trees (Git branches). The
> "gae" variant contains a few small modification in the Java source
> code to be Google App Engine compliant, and has freemarker-gae as the
> Maven artifact name. Otherwise the normal and the "gae" branches are
> identical. Hence they will be voted on together.
>
> The commits to be voted upon are:
> - Normal (non-gae) variant:
>
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=f2308d4b4c242901e6a0e71cb12082243479f69c
> Commit hash: f2308d4b4c242901e6a0e71cb12082243479f69c
> - "gae" variant:
>
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=8d15d85c70df172e5c8ad64f6ba05d52dcac663c
> Commit hash: 8d15d85c70df172e5c8ad64f6ba05d52dcac663c
>
> The artifacts to be voted upon are located here:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.31/source/
> where the source release artifacts are:
> - Normal (non-gae) variant:
> apache-freemarker-2.3.31-src.tar.gz
> - "gae" variant:
> apache-freemarker-gae-2.3.31-src.tar.gz
>
> See the README.md inside them for build instructions!
>
> The release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/ddekany.asc
>
> For convenience, we also provide binaries, which also need to be checked:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.31/binaries/
> and Maven artifacts in the ASF Staging Repository:
> https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.31/
>
> Please try out the package and vote!
>
> The vote is open for a minimum of 72 hours or until the necessary number of
> votes (3 binding +1s) is reached.
>
> [ ] +1 Release this package as Apache FreeMarker 2.3.31
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Please add "(binding)" if your vote is binding.
>
> --
> Thanks,
> Daniel Dekany
Re: [VOTE] Release Apache FreeMarker 2.3.31
Posted by Daniel Dekany <da...@gmail.com>.
Ah, indeed, ARM allows reordering stores and such. I don't think the test
suite (that runs on Travis on ARM) has much chance to uncover such bugs, if
any exists. FM has not-so-trivial concurrency at a few places. But at least
I never assumed anything that the JVM memory model doesn't guarantee.
Others did some brave things though. Like in SimpleHash, the code assumes
that HashMap and TreeMap can be confurrently modified without any
synchronization, as far as you don't add a new key, just modify the value
for an existing key. (That the new value might won't be immediately visible
for other threads is not a big problem there, especially as real world
CPU-s has coherent cache, so it will be visible very soon.)
On Wed, Feb 10, 2021 at 10:45 AM Martin Grigorov <mg...@apache.org>
wrote:
> Hi,
>
> On Wed, Feb 10, 2021 at 11:23 AM Daniel Dekany <da...@gmail.com>
> wrote:
>
> > Ah yes. I forgot to add the build and CI related improvements from the
> > release notes (there were others too). I will add those to the version
> > history post release (can't modify artifacts being voted upon).
> >
> > But I think it will be soon taken as granted that all Java libraries work
> > on ARM (unless they have native parts). Did you run into any issues with
> > other Java libraries?
> >
>
> I am dealing with more and more deployments of Java software on ARM64
> machines lately. Disclaimer: I work for one of the cloud providers.
> Indeed, most of the problems we have faced so far are related to software
> that uses native libraries somehow.
> But most of the times the "main" software is not to blame but one of its
> dependencies. For example some of the file format (Protobuf, Thrift,
> Parquet, etc) and file compression libraries (e.g. Brotli) caused problems.
>
> The only big problem with pure Java (well, Scala in this case) I am aware
> of was in Scala Cats library:
> - https://github.com/typelevel/cats-effect/releases/tag/v3.0.0-M4
> - code with explanation from OpenJDK expert:
> https://gist.github.com/RaasAhsan/8e3554a41e07068536425ca0de46c9e8
>
> This concurrency related code is always tricky and I expect that other
> projects may face it too when someone tries to deploy on ARM64. We'll see!
>
> Regards,
> Martin
>
>
> >
> > On Wed, Feb 10, 2021 at 9:45 AM Emilio Fernandes <
> > emilio.fernandes70@gmail.com> wrote:
> >
> > > Hi,
> > >
> > > On 2021/02/09 22:19:49, Daniel Dekany <dd...@apache.org> wrote:
> > > > Hi all,
> > > >
> > > > Please vote on releasing FreeMarker 2.3.31!
> > > >
> > > > As there were changes in the last few days, don't skip testing with
> > > > your dependent projects, even if you already did it recently.
> > > >
> > > > Release Notes:
> > > >
> > https://freemarker.apache.org/builds/2.3.31-voting/versions_2_3_31.html
> > >
> > > I am not sure whether the Release Notes is the right place or somewhere
> > at
> > > https://freemarker.apache.org/committer-howto.html but I think it is
> > also
> > > worth to mention that Apache FreeMarker is being tested on ARM64 (
> > > https://github.com/apache/freemarker/pull/72) and it works without
> > issues!
> > >
> > > Regards,
> > > Emilio
> > >
> > > >
> > > > Before proceed, you should know that FreeMarker 2.3.x, for a long
> > > > time, always releases a normal and a "gae" variant on the same time,
> > > > which are technically two independent source trees (Git branches).
> The
> > > > "gae" variant contains a few small modification in the Java source
> > > > code to be Google App Engine compliant, and has freemarker-gae as the
> > > > Maven artifact name. Otherwise the normal and the "gae" branches are
> > > > identical. Hence they will be voted on together.
> > > >
> > > > The commits to be voted upon are:
> > > > - Normal (non-gae) variant:
> > > >
> > > >
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=f2308d4b4c242901e6a0e71cb12082243479f69c
> > > > Commit hash: f2308d4b4c242901e6a0e71cb12082243479f69c
> > > > - "gae" variant:
> > > >
> > > >
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=8d15d85c70df172e5c8ad64f6ba05d52dcac663c
> > > > Commit hash: 8d15d85c70df172e5c8ad64f6ba05d52dcac663c
> > > >
> > > > The artifacts to be voted upon are located here:
> > > >
> > https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.31/source/
> > > > where the source release artifacts are:
> > > > - Normal (non-gae) variant:
> > > > apache-freemarker-2.3.31-src.tar.gz
> > > > - "gae" variant:
> > > > apache-freemarker-gae-2.3.31-src.tar.gz
> > > >
> > > > See the README.md inside them for build instructions!
> > > >
> > > > The release artifacts are signed with the following key:
> > > > https://people.apache.org/keys/committer/ddekany.asc
> > > >
> > > > For convenience, we also provide binaries, which also need to be
> > checked:
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.31/binaries/
> > > > and Maven artifacts in the ASF Staging Repository:
> > > >
> > >
> >
> https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.31/
> > > >
> > > > Please try out the package and vote!
> > > >
> > > > The vote is open for a minimum of 72 hours or until the necessary
> > number
> > > of
> > > > votes (3 binding +1s) is reached.
> > > >
> > > > [ ] +1 Release this package as Apache FreeMarker 2.3.31
> > > > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > > > [ ] -1 Do not release this package because...
> > > >
> > > > Please add "(binding)" if your vote is binding.
> > > >
> > > > --
> > > > Thanks,
> > > > Daniel Dekany
> > > >
> > >
> >
> >
> > --
> > Best regards,
> > Daniel Dekany
> >
>
--
Best regards,
Daniel Dekany
Re: [VOTE] Release Apache FreeMarker 2.3.31
Posted by Martin Grigorov <mg...@apache.org>.
Hi,
On Wed, Feb 10, 2021 at 11:23 AM Daniel Dekany <da...@gmail.com>
wrote:
> Ah yes. I forgot to add the build and CI related improvements from the
> release notes (there were others too). I will add those to the version
> history post release (can't modify artifacts being voted upon).
>
> But I think it will be soon taken as granted that all Java libraries work
> on ARM (unless they have native parts). Did you run into any issues with
> other Java libraries?
>
I am dealing with more and more deployments of Java software on ARM64
machines lately. Disclaimer: I work for one of the cloud providers.
Indeed, most of the problems we have faced so far are related to software
that uses native libraries somehow.
But most of the times the "main" software is not to blame but one of its
dependencies. For example some of the file format (Protobuf, Thrift,
Parquet, etc) and file compression libraries (e.g. Brotli) caused problems.
The only big problem with pure Java (well, Scala in this case) I am aware
of was in Scala Cats library:
- https://github.com/typelevel/cats-effect/releases/tag/v3.0.0-M4
- code with explanation from OpenJDK expert:
https://gist.github.com/RaasAhsan/8e3554a41e07068536425ca0de46c9e8
This concurrency related code is always tricky and I expect that other
projects may face it too when someone tries to deploy on ARM64. We'll see!
Regards,
Martin
>
> On Wed, Feb 10, 2021 at 9:45 AM Emilio Fernandes <
> emilio.fernandes70@gmail.com> wrote:
>
> > Hi,
> >
> > On 2021/02/09 22:19:49, Daniel Dekany <dd...@apache.org> wrote:
> > > Hi all,
> > >
> > > Please vote on releasing FreeMarker 2.3.31!
> > >
> > > As there were changes in the last few days, don't skip testing with
> > > your dependent projects, even if you already did it recently.
> > >
> > > Release Notes:
> > >
> https://freemarker.apache.org/builds/2.3.31-voting/versions_2_3_31.html
> >
> > I am not sure whether the Release Notes is the right place or somewhere
> at
> > https://freemarker.apache.org/committer-howto.html but I think it is
> also
> > worth to mention that Apache FreeMarker is being tested on ARM64 (
> > https://github.com/apache/freemarker/pull/72) and it works without
> issues!
> >
> > Regards,
> > Emilio
> >
> > >
> > > Before proceed, you should know that FreeMarker 2.3.x, for a long
> > > time, always releases a normal and a "gae" variant on the same time,
> > > which are technically two independent source trees (Git branches). The
> > > "gae" variant contains a few small modification in the Java source
> > > code to be Google App Engine compliant, and has freemarker-gae as the
> > > Maven artifact name. Otherwise the normal and the "gae" branches are
> > > identical. Hence they will be voted on together.
> > >
> > > The commits to be voted upon are:
> > > - Normal (non-gae) variant:
> > >
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=f2308d4b4c242901e6a0e71cb12082243479f69c
> > > Commit hash: f2308d4b4c242901e6a0e71cb12082243479f69c
> > > - "gae" variant:
> > >
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=8d15d85c70df172e5c8ad64f6ba05d52dcac663c
> > > Commit hash: 8d15d85c70df172e5c8ad64f6ba05d52dcac663c
> > >
> > > The artifacts to be voted upon are located here:
> > >
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.31/source/
> > > where the source release artifacts are:
> > > - Normal (non-gae) variant:
> > > apache-freemarker-2.3.31-src.tar.gz
> > > - "gae" variant:
> > > apache-freemarker-gae-2.3.31-src.tar.gz
> > >
> > > See the README.md inside them for build instructions!
> > >
> > > The release artifacts are signed with the following key:
> > > https://people.apache.org/keys/committer/ddekany.asc
> > >
> > > For convenience, we also provide binaries, which also need to be
> checked:
> > >
> >
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.31/binaries/
> > > and Maven artifacts in the ASF Staging Repository:
> > >
> >
> https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.31/
> > >
> > > Please try out the package and vote!
> > >
> > > The vote is open for a minimum of 72 hours or until the necessary
> number
> > of
> > > votes (3 binding +1s) is reached.
> > >
> > > [ ] +1 Release this package as Apache FreeMarker 2.3.31
> > > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > > [ ] -1 Do not release this package because...
> > >
> > > Please add "(binding)" if your vote is binding.
> > >
> > > --
> > > Thanks,
> > > Daniel Dekany
> > >
> >
>
>
> --
> Best regards,
> Daniel Dekany
>
Re: [VOTE] Release Apache FreeMarker 2.3.31
Posted by Daniel Dekany <da...@gmail.com>.
Ah yes. I forgot to add the build and CI related improvements from the
release notes (there were others too). I will add those to the version
history post release (can't modify artifacts being voted upon).
But I think it will be soon taken as granted that all Java libraries work
on ARM (unless they have native parts). Did you run into any issues with
other Java libraries?
On Wed, Feb 10, 2021 at 9:45 AM Emilio Fernandes <
emilio.fernandes70@gmail.com> wrote:
> Hi,
>
> On 2021/02/09 22:19:49, Daniel Dekany <dd...@apache.org> wrote:
> > Hi all,
> >
> > Please vote on releasing FreeMarker 2.3.31!
> >
> > As there were changes in the last few days, don't skip testing with
> > your dependent projects, even if you already did it recently.
> >
> > Release Notes:
> > https://freemarker.apache.org/builds/2.3.31-voting/versions_2_3_31.html
>
> I am not sure whether the Release Notes is the right place or somewhere at
> https://freemarker.apache.org/committer-howto.html but I think it is also
> worth to mention that Apache FreeMarker is being tested on ARM64 (
> https://github.com/apache/freemarker/pull/72) and it works without issues!
>
> Regards,
> Emilio
>
> >
> > Before proceed, you should know that FreeMarker 2.3.x, for a long
> > time, always releases a normal and a "gae" variant on the same time,
> > which are technically two independent source trees (Git branches). The
> > "gae" variant contains a few small modification in the Java source
> > code to be Google App Engine compliant, and has freemarker-gae as the
> > Maven artifact name. Otherwise the normal and the "gae" branches are
> > identical. Hence they will be voted on together.
> >
> > The commits to be voted upon are:
> > - Normal (non-gae) variant:
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=f2308d4b4c242901e6a0e71cb12082243479f69c
> > Commit hash: f2308d4b4c242901e6a0e71cb12082243479f69c
> > - "gae" variant:
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=8d15d85c70df172e5c8ad64f6ba05d52dcac663c
> > Commit hash: 8d15d85c70df172e5c8ad64f6ba05d52dcac663c
> >
> > The artifacts to be voted upon are located here:
> > https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.31/source/
> > where the source release artifacts are:
> > - Normal (non-gae) variant:
> > apache-freemarker-2.3.31-src.tar.gz
> > - "gae" variant:
> > apache-freemarker-gae-2.3.31-src.tar.gz
> >
> > See the README.md inside them for build instructions!
> >
> > The release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/ddekany.asc
> >
> > For convenience, we also provide binaries, which also need to be checked:
> >
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.31/binaries/
> > and Maven artifacts in the ASF Staging Repository:
> >
> https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.31/
> >
> > Please try out the package and vote!
> >
> > The vote is open for a minimum of 72 hours or until the necessary number
> of
> > votes (3 binding +1s) is reached.
> >
> > [ ] +1 Release this package as Apache FreeMarker 2.3.31
> > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
> >
> > Please add "(binding)" if your vote is binding.
> >
> > --
> > Thanks,
> > Daniel Dekany
> >
>
--
Best regards,
Daniel Dekany
Re: [VOTE] Release Apache FreeMarker 2.3.31
Posted by Emilio Fernandes <em...@gmail.com>.
Hi,
On 2021/02/09 22:19:49, Daniel Dekany <dd...@apache.org> wrote:
> Hi all,
>
> Please vote on releasing FreeMarker 2.3.31!
>
> As there were changes in the last few days, don't skip testing with
> your dependent projects, even if you already did it recently.
>
> Release Notes:
> https://freemarker.apache.org/builds/2.3.31-voting/versions_2_3_31.html
I am not sure whether the Release Notes is the right place or somewhere at https://freemarker.apache.org/committer-howto.html but I think it is also worth to mention that Apache FreeMarker is being tested on ARM64 (https://github.com/apache/freemarker/pull/72) and it works without issues!
Regards,
Emilio
>
> Before proceed, you should know that FreeMarker 2.3.x, for a long
> time, always releases a normal and a "gae" variant on the same time,
> which are technically two independent source trees (Git branches). The
> "gae" variant contains a few small modification in the Java source
> code to be Google App Engine compliant, and has freemarker-gae as the
> Maven artifact name. Otherwise the normal and the "gae" branches are
> identical. Hence they will be voted on together.
>
> The commits to be voted upon are:
> - Normal (non-gae) variant:
>
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=f2308d4b4c242901e6a0e71cb12082243479f69c
> Commit hash: f2308d4b4c242901e6a0e71cb12082243479f69c
> - "gae" variant:
>
> https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=8d15d85c70df172e5c8ad64f6ba05d52dcac663c
> Commit hash: 8d15d85c70df172e5c8ad64f6ba05d52dcac663c
>
> The artifacts to be voted upon are located here:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.31/source/
> where the source release artifacts are:
> - Normal (non-gae) variant:
> apache-freemarker-2.3.31-src.tar.gz
> - "gae" variant:
> apache-freemarker-gae-2.3.31-src.tar.gz
>
> See the README.md inside them for build instructions!
>
> The release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/ddekany.asc
>
> For convenience, we also provide binaries, which also need to be checked:
> https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.31/binaries/
> and Maven artifacts in the ASF Staging Repository:
> https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.31/
>
> Please try out the package and vote!
>
> The vote is open for a minimum of 72 hours or until the necessary number of
> votes (3 binding +1s) is reached.
>
> [ ] +1 Release this package as Apache FreeMarker 2.3.31
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Please add "(binding)" if your vote is binding.
>
> --
> Thanks,
> Daniel Dekany
>