You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ericm-db (via GitHub)" <gi...@apache.org> on 2025/01/31 16:46:41 UTC
[PR] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
ericm-db opened a new pull request, #49751:
URL: https://github.com/apache/spark/pull/49751
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Right now, effectively set all fields in a schema to nullable, regardless of what the user specifies. If a field is specified as non-nullable and Avro encoding is used we will throw an error
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
In order to keep parity with the user-specified schema with the actual schema that we use.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Unit tests
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51065][SQL] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db commented on code in PR #49751:
URL: https://github.com/apache/spark/pull/49751#discussion_r1945369374
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StateStoreColumnFamilySchemaUtils.scala:
##########
@@ -47,7 +47,7 @@ object StateStoreColumnFamilySchemaUtils {
// Byte type is converted to Int in Avro, which doesn't work for us as Avro
// uses zig-zag encoding as opposed to big-endian for Ints
Seq(
- StructField(s"${field.name}_marker", BinaryType, nullable = false),
Review Comment:
Lets say `nullable=true` explicitly ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51065][SQL] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "ericm-db (via GitHub)" <gi...@apache.org>.
ericm-db commented on code in PR #49751:
URL: https://github.com/apache/spark/pull/49751#discussion_r1945307892
##########
python/pyspark/sql/tests/pandas/test_pandas_transform_with_state.py:
##########
@@ -1470,6 +1470,39 @@ def check_exception(error):
check_exception=check_exception,
)
+ def test_not_nullable_fails(self):
Review Comment:
The thing is, there is no way for user to specify this using Scala.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51065][SQL] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on code in PR #49751:
URL: https://github.com/apache/spark/pull/49751#discussion_r1945998917
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TransformWithStateExec.scala:
##########
@@ -149,8 +149,11 @@ case class TransformWithStateExec(
0, keyExpressions.toStructType, 0, DUMMY_VALUE_ROW_SCHEMA,
Some(NoPrefixKeyStateEncoderSpec(keySchema)))
+ // For Scala, the user can't explicitly set nullability on schema, so there is
Review Comment:
https://github.com/apache/spark/pull/49751#discussion_r1945987644
I realized you had to go through this way due to case class enconder. Sorry about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51065][SQL] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on PR #49751:
URL: https://github.com/apache/spark/pull/49751#issuecomment-2646062189
I didn't realize the prefix is not properly set in the PR title - @ericm-db let's use `[SS]` if the PR is relevant to Structured Streaming. If you think the PR is bound to multiple components, you can add all of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51065][SQL] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "ericm-db (via GitHub)" <gi...@apache.org>.
ericm-db commented on code in PR #49751:
URL: https://github.com/apache/spark/pull/49751#discussion_r1945307417
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulProcessorHandleImpl.scala:
##########
@@ -364,17 +364,20 @@ class DriverStatefulProcessorHandleImpl(timeMode: TimeMode, keyExprEnc: Expressi
}
def getColumnFamilySchemas(
- setNullableFields: Boolean
+ shouldCheckNullable: Boolean
): Map[String, StateStoreColFamilySchema] = {
val schemas = columnFamilySchemas.toMap
- if (setNullableFields) {
- schemas.map { case (colFamilyName, stateStoreColFamilySchema) =>
- colFamilyName -> stateStoreColFamilySchema.copy(
- valueSchema = stateStoreColFamilySchema.valueSchema.toNullable
- )
+ schemas.map { case (colFamilyName, schema) =>
+ // assert that each field is nullable if schema evolution is enabled
+ schema.valueSchema.fields.foreach { field =>
+ if (!field.nullable && shouldCheckNullable) {
+ throw StateStoreErrors.stateStoreSchemaMustBeNullable(
+ schema.colFamilyName, schema.valueSchema.toString())
+ }
}
- } else {
- schemas
+ colFamilyName -> schema.copy(
Review Comment:
Yeah, it is. Encoders.product automatically sets schema as non-nullable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51065][SQL] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on code in PR #49751:
URL: https://github.com/apache/spark/pull/49751#discussion_r1946053479
##########
python/pyspark/sql/tests/pandas/test_pandas_transform_with_state.py:
##########
@@ -1470,6 +1470,39 @@ def check_exception(error):
check_exception=check_exception,
)
+ def test_not_nullable_fails(self):
Review Comment:
(Not really a bug, we figured out.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51065][SQL] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "ericm-db (via GitHub)" <gi...@apache.org>.
ericm-db commented on PR #49751:
URL: https://github.com/apache/spark/pull/49751#issuecomment-2637637025
@HeartSaVioR Can you PTAL when you get a chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51065][SQL] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "ericm-db (via GitHub)" <gi...@apache.org>.
ericm-db commented on PR #49751:
URL: https://github.com/apache/spark/pull/49751#issuecomment-2631483423
We need to treat them differently because the schemas for these are
non-nullable by default. We can either change the schemas for them to be
nullable or have this check, what do you think is the best solution?
I think this check makes the most sense but am open to change
On Mon, Feb 3, 2025, 12:32 AM Anish ***@***.***> wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In
> sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulProcessorHandleImpl.scala
> <https://github.com/apache/spark/pull/49751#discussion_r1938843936>:
>
> > ): Map[String, StateStoreColFamilySchema] = {
> val schemas = columnFamilySchemas.toMap
> - if (setNullableFields) {
> - schemas.map { case (colFamilyName, stateStoreColFamilySchema) =>
> - colFamilyName -> stateStoreColFamilySchema.copy(
> - valueSchema = stateStoreColFamilySchema.valueSchema.toNullable
> - )
> + schemas.map { case (colFamilyName, schema) =>
> + // assert that each field is nullable if schema evolution is enabled
> + schema.valueSchema.fields.foreach { field =>
> + if (!field.nullable && shouldCheckNullable && !isInternal(colFamilyName)) {
>
> Why do we need to treat internal col families differently ?
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/spark/pull/49751#pullrequestreview-2589011983>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/A7RNYRIO5IZH3FCSEBS2GML2N4EPVAVCNFSM6AAAAABWH7JDB2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOBZGAYTCOJYGM>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51065][SQL] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db commented on code in PR #49751:
URL: https://github.com/apache/spark/pull/49751#discussion_r1941728749
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulProcessorHandleImpl.scala:
##########
@@ -363,18 +363,25 @@ class DriverStatefulProcessorHandleImpl(timeMode: TimeMode, keyExprEnc: Expressi
addTimerColFamily()
}
+ private def isInternal(columnFamilyName: String): Boolean = {
+ columnFamilyName.startsWith("_") || columnFamilyName.startsWith("$")
+ }
+
def getColumnFamilySchemas(
- setNullableFields: Boolean
+ shouldCheckNullable: Boolean
): Map[String, StateStoreColFamilySchema] = {
val schemas = columnFamilySchemas.toMap
- if (setNullableFields) {
- schemas.map { case (colFamilyName, stateStoreColFamilySchema) =>
- colFamilyName -> stateStoreColFamilySchema.copy(
- valueSchema = stateStoreColFamilySchema.valueSchema.toNullable
- )
+ schemas.map { case (colFamilyName, schema) =>
+ // assert that each field is nullable if schema evolution is enabled
+ schema.valueSchema.fields.foreach { field =>
+ if (!field.nullable && shouldCheckNullable && !isInternal(colFamilyName)) {
Review Comment:
Yea lets change the schemas I think. We can apply a higher level check to ensure that certain state types are not evolvable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51065][SQL] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on code in PR #49751:
URL: https://github.com/apache/spark/pull/49751#discussion_r1946054194
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulProcessorHandleImpl.scala:
##########
@@ -363,18 +363,36 @@ class DriverStatefulProcessorHandleImpl(timeMode: TimeMode, keyExprEnc: Expressi
addTimerColFamily()
}
+ /**
+ * This method returns all column family schemas, and checks and enforces nullability
+ * if need be. The nullability check and set is only set to true when Avro is enabled.
+ * @param shouldCheckNullable Whether we need to check the nullability. This is set to
+ * true when using Python, as this is the only avenue through
+ * which users can set nullability
+ * @param shouldSetNullable Whether we need to set the fields as nullable. This is set to
+ * true when using Scala, as case classes are set to
Review Comment:
I found this, `def nullable: Boolean = !isPrimitive` from AgnosticEncoder trait, so it's intended and not a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51065][SQL] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on PR #49751:
URL: https://github.com/apache/spark/pull/49751#issuecomment-2646061052
Thanks! Merging to master/4.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db commented on PR #49751:
URL: https://github.com/apache/spark/pull/49751#issuecomment-2628612427
@ericm-db - also, is test failure related to the change ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51065][SQL] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on PR #49751:
URL: https://github.com/apache/spark/pull/49751#issuecomment-2642990403
@ericm-db Looks like CI failure is relevant (I only checked with core module and there is another failure in other module). Could you please take a look and fix it? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51065][SQL] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "ericm-db (via GitHub)" <gi...@apache.org>.
ericm-db commented on PR #49751:
URL: https://github.com/apache/spark/pull/49751#issuecomment-2644297952
@HeartSaVioR Can you PTAL now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51065][SQL] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on code in PR #49751:
URL: https://github.com/apache/spark/pull/49751#discussion_r1946003608
##########
python/pyspark/sql/tests/pandas/test_pandas_transform_with_state.py:
##########
@@ -1470,6 +1470,39 @@ def check_exception(error):
check_exception=check_exception,
)
+ def test_not_nullable_fails(self):
Review Comment:
Now I get that you are not able to test this actually, as we have to just accept non-nullable column and change to nullable. Again I doubt this is just a bug though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51065][SQL] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on code in PR #49751:
URL: https://github.com/apache/spark/pull/49751#discussion_r1946034847
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulProcessorHandleImpl.scala:
##########
@@ -363,18 +363,36 @@ class DriverStatefulProcessorHandleImpl(timeMode: TimeMode, keyExprEnc: Expressi
addTimerColFamily()
}
+ /**
+ * This method returns all column family schemas, and checks and enforces nullability
+ * if need be. The nullability check and set is only set to true when Avro is enabled.
+ * @param shouldCheckNullable Whether we need to check the nullability. This is set to
+ * true when using Python, as this is the only avenue through
+ * which users can set nullability
+ * @param shouldSetNullable Whether we need to set the fields as nullable. This is set to
+ * true when using Scala, as case classes are set to
Review Comment:
Maybe it is only true for primitive type? If then it might make sense, like an optimization for the type which could never have null. If you see non-nullable to String or so, this should be a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51065][SQL] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db commented on code in PR #49751:
URL: https://github.com/apache/spark/pull/49751#discussion_r1946028553
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -5072,6 +5072,14 @@
],
"sqlState" : "42601"
},
+ "TRANSFORM_WITH_STATE_SCHEMA_MUST_BE_NULLABLE" : {
+ "message" : [
+ "If schema evolution is enabled, all the fields in the schema for column family <columnFamilyName> must be nullable",
Review Comment:
Yea I think its fine to say that we refer to the `transformWithState` case relative to `Avro` being used - dont need to explicitly call out schema evolution here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51065][SQL] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on code in PR #49751:
URL: https://github.com/apache/spark/pull/49751#discussion_r1944051166
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TransformWithStateExec.scala:
##########
@@ -150,7 +150,7 @@ case class TransformWithStateExec(
Some(NoPrefixKeyStateEncoderSpec(keySchema)))
val columnFamilySchemas = getDriverProcessorHandle()
- .getColumnFamilySchemas(setNullableFields) ++
+ .getColumnFamilySchemas(false) ++
Review Comment:
Are we going to ignore the param and just put true/false "differently" between Scala and Python? What's the rationale?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TransformWithStateExec.scala:
##########
@@ -150,7 +150,7 @@ case class TransformWithStateExec(
Some(NoPrefixKeyStateEncoderSpec(keySchema)))
val columnFamilySchemas = getDriverProcessorHandle()
- .getColumnFamilySchemas(setNullableFields) ++
+ .getColumnFamilySchemas(false) ++
Review Comment:
Also nit: use named parameter for boolean param
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -4669,6 +4669,13 @@
],
"sqlState" : "42K06"
},
+ "STATE_STORE_SCHEMA_MUST_BE_NULLABLE" : {
+ "message" : [
+ "If schema evolution is enabled, all the fields in the schema for column family <columnFamilyName> must be nullable.",
Review Comment:
Shall we be very specific about error class and the message?
* Is it only happening when schema evolution is enabled, or it's bound to Avro encoding?
* Is it only bound to TWS? Note that this will be a breaking change for other stateful operators.
This generic error class and message leads confusion that this is applied for all stateful operators and the encoding type.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/python/TransformWithStateInPandasExec.scala:
##########
@@ -117,7 +117,7 @@ case class TransformWithStateInPandasExec(
override def getColFamilySchemas(
setNullableFields: Boolean
): Map[String, StateStoreColFamilySchema] = {
- driverProcessorHandle.getColumnFamilySchemas(setNullableFields)
+ driverProcessorHandle.getColumnFamilySchemas(true)
Review Comment:
nit: use named param for boolean to easily get what is it.
##########
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala:
##########
@@ -1815,7 +1815,6 @@ class TransformWithStateSuite extends StateStoreMetricsTest
TransformWithStateSuiteUtils.NUM_SHUFFLE_PARTITIONS.toString) {
withTempDir { checkpointDir =>
// When Avro is used, we want to set the StructFields to nullable
- val shouldBeNullable = usingAvroEncoding()
Review Comment:
nit: please also remove out of sync comment.
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -4669,6 +4669,13 @@
],
"sqlState" : "42K06"
},
+ "STATE_STORE_SCHEMA_MUST_BE_NULLABLE" : {
+ "message" : [
+ "If schema evolution is enabled, all the fields in the schema for column family <columnFamilyName> must be nullable.",
Review Comment:
I'd suggest not to generalize the error. I think it's better to be scoped to TWS. Let's not bind this to general state store error class.
In future, we may want to migrate to Avro for other stateful operators. For other stateful operators, it is really uneasy for users to ensure nullability of the schema, hence it's high likely on us to fix this rather than disallowing and forcing users to ensure nullability.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/python/TransformWithStateInPandasExec.scala:
##########
@@ -117,7 +117,7 @@ case class TransformWithStateInPandasExec(
override def getColFamilySchemas(
setNullableFields: Boolean
): Map[String, StateStoreColFamilySchema] = {
- driverProcessorHandle.getColumnFamilySchemas(setNullableFields)
+ driverProcessorHandle.getColumnFamilySchemas(true)
Review Comment:
Also, since we do not use the parameter, should the parameter be needed? Why this method has the param `setNullableFields` and DriverStatefulProcessorHandleImpl.getColumnFamilySchemas has the param `shouldCheckNullable`?
##########
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala:
##########
@@ -1815,7 +1815,6 @@ class TransformWithStateSuite extends StateStoreMetricsTest
TransformWithStateSuiteUtils.NUM_SHUFFLE_PARTITIONS.toString) {
withTempDir { checkpointDir =>
// When Avro is used, we want to set the StructFields to nullable
- val shouldBeNullable = usingAvroEncoding()
Review Comment:
Btw, this worries me that disallowing non-nullable column does not only impact Avro but UnsafeRow as well. Do we have tests which will check we do not disallow non-nullable column for UnsafeRow encode?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulProcessorHandleImpl.scala:
##########
@@ -364,17 +364,20 @@ class DriverStatefulProcessorHandleImpl(timeMode: TimeMode, keyExprEnc: Expressi
}
def getColumnFamilySchemas(
- setNullableFields: Boolean
+ shouldCheckNullable: Boolean
): Map[String, StateStoreColFamilySchema] = {
val schemas = columnFamilySchemas.toMap
- if (setNullableFields) {
- schemas.map { case (colFamilyName, stateStoreColFamilySchema) =>
- colFamilyName -> stateStoreColFamilySchema.copy(
- valueSchema = stateStoreColFamilySchema.valueSchema.toNullable
- )
+ schemas.map { case (colFamilyName, schema) =>
+ // assert that each field is nullable if schema evolution is enabled
+ schema.valueSchema.fields.foreach { field =>
+ if (!field.nullable && shouldCheckNullable) {
+ throw StateStoreErrors.stateStoreSchemaMustBeNullable(
+ schema.colFamilyName, schema.valueSchema.toString())
+ }
}
- } else {
- schemas
+ colFamilyName -> schema.copy(
Review Comment:
Is it intentional to change columns to be nullable regardless of `shouldCheckNullable` param?
##########
python/pyspark/sql/tests/pandas/test_pandas_transform_with_state.py:
##########
@@ -1470,6 +1470,39 @@ def check_exception(error):
check_exception=check_exception,
)
+ def test_not_nullable_fails(self):
Review Comment:
Why not having identical test in Scala as well? I don't see a new test verifying the error.
##########
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala:
##########
@@ -1826,15 +1825,15 @@ class TransformWithStateSuite extends StateStoreMetricsTest
val schema0 = StateStoreColFamilySchema(
"countState", 0,
keySchema, 0,
- new StructType().add("value", LongType, nullable = shouldBeNullable),
Review Comment:
nit: Looks like there are also other columns which rely on the fact the default value of `nullable = true`. Let's be consistent, removing all explicit values or adding explicit nullable value for all columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51065][SQL] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on code in PR #49751:
URL: https://github.com/apache/spark/pull/49751#discussion_r1945951586
##########
python/pyspark/sql/tests/pandas/test_pandas_transform_with_state.py:
##########
@@ -1470,6 +1470,39 @@ def check_exception(error):
check_exception=check_exception,
)
+ def test_not_nullable_fails(self):
Review Comment:
Yes and probably also no.
I agree moderate users may not ever try to get over and just stick with case class or POJO or so. But "we" can imagine a way to get over, exactly the same way how we could support PySpark:
```
override protected val stateEncoder: ExpressionEncoder[Any] =
ExpressionEncoder(stateType).resolveAndBind().asInstanceOf[ExpressionEncoder[Any]]
```
This is how we come up with state encoder for Python version of FMGWS. This is to serde with Row interface - my rough memory says it's not InternalRow but Row, so, most likely work with GenericRow, but we can try with both GenericRow and InternalRow.
I'm OK with deferring this as follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51065][SQL] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "ericm-db (via GitHub)" <gi...@apache.org>.
ericm-db commented on code in PR #49751:
URL: https://github.com/apache/spark/pull/49751#discussion_r1941548766
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulProcessorHandleImpl.scala:
##########
@@ -363,18 +363,25 @@ class DriverStatefulProcessorHandleImpl(timeMode: TimeMode, keyExprEnc: Expressi
addTimerColFamily()
}
+ private def isInternal(columnFamilyName: String): Boolean = {
+ columnFamilyName.startsWith("_") || columnFamilyName.startsWith("$")
+ }
+
def getColumnFamilySchemas(
- setNullableFields: Boolean
+ shouldCheckNullable: Boolean
): Map[String, StateStoreColFamilySchema] = {
val schemas = columnFamilySchemas.toMap
- if (setNullableFields) {
- schemas.map { case (colFamilyName, stateStoreColFamilySchema) =>
- colFamilyName -> stateStoreColFamilySchema.copy(
- valueSchema = stateStoreColFamilySchema.valueSchema.toNullable
- )
+ schemas.map { case (colFamilyName, schema) =>
+ // assert that each field is nullable if schema evolution is enabled
+ schema.valueSchema.fields.foreach { field =>
+ if (!field.nullable && shouldCheckNullable && !isInternal(colFamilyName)) {
Review Comment:
We need to treat them differently because the schemas for these are non-nullable by default. We can either change the schemas for them to be nullable or have this check, what do you think is the best solution?
I think this check makes the most sense but am open to change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51065][SQL] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db commented on code in PR #49751:
URL: https://github.com/apache/spark/pull/49751#discussion_r1938843936
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulProcessorHandleImpl.scala:
##########
@@ -363,18 +363,25 @@ class DriverStatefulProcessorHandleImpl(timeMode: TimeMode, keyExprEnc: Expressi
addTimerColFamily()
}
+ private def isInternal(columnFamilyName: String): Boolean = {
+ columnFamilyName.startsWith("_") || columnFamilyName.startsWith("$")
+ }
+
def getColumnFamilySchemas(
- setNullableFields: Boolean
+ shouldCheckNullable: Boolean
): Map[String, StateStoreColFamilySchema] = {
val schemas = columnFamilySchemas.toMap
- if (setNullableFields) {
- schemas.map { case (colFamilyName, stateStoreColFamilySchema) =>
- colFamilyName -> stateStoreColFamilySchema.copy(
- valueSchema = stateStoreColFamilySchema.valueSchema.toNullable
- )
+ schemas.map { case (colFamilyName, schema) =>
+ // assert that each field is nullable if schema evolution is enabled
+ schema.valueSchema.fields.foreach { field =>
+ if (!field.nullable && shouldCheckNullable && !isInternal(colFamilyName)) {
Review Comment:
Why do we need to treat internal col families differently ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db commented on code in PR #49751:
URL: https://github.com/apache/spark/pull/49751#discussion_r1937971847
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulProcessorHandleImpl.scala:
##########
@@ -364,13 +364,21 @@ class DriverStatefulProcessorHandleImpl(timeMode: TimeMode, keyExprEnc: Expressi
}
def getColumnFamilySchemas(
- setNullableFields: Boolean
+ setNullableFields: Boolean = true,
+ ensureNullableFields: Boolean = false
): Map[String, StateStoreColFamilySchema] = {
val schemas = columnFamilySchemas.toMap
if (setNullableFields) {
- schemas.map { case (colFamilyName, stateStoreColFamilySchema) =>
- colFamilyName -> stateStoreColFamilySchema.copy(
- valueSchema = stateStoreColFamilySchema.valueSchema.toNullable
+ schemas.map { case (colFamilyName, schema) =>
+ // assert that each field is nullable if schema evolution is enabled
+ schema.valueSchema.fields.foreach { field =>
+ if (!field.nullable && ensureNullableFields) {
Review Comment:
Should we just always enforce this for `transformWithState` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db commented on code in PR #49751:
URL: https://github.com/apache/spark/pull/49751#discussion_r1937968857
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -4715,6 +4715,14 @@
],
"sqlState" : "42K06"
},
+ "STATE_STORE_SCHEMA_MUST_BE_NULLABLE" : {
+ "message" : [
+ "If schema evolution is enabled, all the fields in the schema for column family <columnFamilyName> must be nullable.",
+ "Please set the 'spark.sql.streaming.stateStore.encodingFormat' to 'UnsafeRow' or make the schema nullable.",
Review Comment:
This is stored in the offset log though. So maybe just say that they should make schema nullable ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db commented on PR #49751:
URL: https://github.com/apache/spark/pull/49751#issuecomment-2628611845
@ericm-db - can u add the SPARK ticket in the PR title ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51065][SQL] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on code in PR #49751:
URL: https://github.com/apache/spark/pull/49751#discussion_r1945987644
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulProcessorHandleImpl.scala:
##########
@@ -363,18 +363,36 @@ class DriverStatefulProcessorHandleImpl(timeMode: TimeMode, keyExprEnc: Expressi
addTimerColFamily()
}
+ /**
+ * This method returns all column family schemas, and checks and enforces nullability
+ * if need be. The nullability check and set is only set to true when Avro is enabled.
+ * @param shouldCheckNullable Whether we need to check the nullability. This is set to
+ * true when using Python, as this is the only avenue through
+ * which users can set nullability
+ * @param shouldSetNullable Whether we need to set the fields as nullable. This is set to
+ * true when using Scala, as case classes are set to
Review Comment:
> case classes are set to non-nullable by default.
I'm actually surprised and it sounds like a bug to me. (Sorry, you had to handle Python and Scala differently due to this. My bad.)
What if you set `null` to any of fields in case class? Will it work, and if it works, how?
If this is indeed a bug and we can fix that, then we can simplify things a lot. I'm OK if you want to defer this, but definitely need to have follow up ticket for this.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TransformWithStateExec.scala:
##########
@@ -149,8 +149,11 @@ case class TransformWithStateExec(
0, keyExpressions.toStructType, 0, DUMMY_VALUE_ROW_SCHEMA,
Some(NoPrefixKeyStateEncoderSpec(keySchema)))
+ // For Scala, the user can't explicitly set nullability on schema, so there is
Review Comment:
Likewise I mentioned in other comment, it is not impossible to set nullability on encoder (although I tend to agree most users won't). Let's not make this be conditional.
Also, this is concerning me - if we are very confident that users would never be able to set column to be nullable, why we need to change the schema as we all know it has to be nullable? What we are worrying about if we just do the same with Python?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStoreErrors.scala:
##########
@@ -145,6 +145,12 @@ object StateStoreErrors {
new StateStoreValueSchemaNotCompatible(storedValueSchema, newValueSchema)
}
+ def twsSchemaMustBeNullable(
Review Comment:
I think TWS deserves its own error collection class, but I agree this is out of scope. Let's make a follow-up.
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -5072,6 +5072,14 @@
],
"sqlState" : "42601"
},
+ "TRANSFORM_WITH_STATE_SCHEMA_MUST_BE_NULLABLE" : {
+ "message" : [
+ "If schema evolution is enabled, all the fields in the schema for column family <columnFamilyName> must be nullable",
Review Comment:
Do we think whichever is easier to understand, "using Avro" or "schema evolution is enabled"?
I foresee the direction of using Avro for all stateful operators (unless there is outstanding regression), and once we make Avro by default, this will be confusing one to consume because they don't do anything for schema evolution. IMO it is "indirect" information and they would probably try to figure out how to disable schema evolution instead, without knowing that Avro and schema evolution is coupled.
cc. @anishshri-db to hear his voice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51065][SQL] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR closed pull request #49751: [SPARK-51065][SQL] Disallowing non-nullable schema when Avro encoding is used for TransformWithState
URL: https://github.com/apache/spark/pull/49751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51065][SQL] Disallowing non-nullable schema when Avro encoding is used for TransformWithState [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on code in PR #49751:
URL: https://github.com/apache/spark/pull/49751#discussion_r1946054194
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulProcessorHandleImpl.scala:
##########
@@ -363,18 +363,36 @@ class DriverStatefulProcessorHandleImpl(timeMode: TimeMode, keyExprEnc: Expressi
addTimerColFamily()
}
+ /**
+ * This method returns all column family schemas, and checks and enforces nullability
+ * if need be. The nullability check and set is only set to true when Avro is enabled.
+ * @param shouldCheckNullable Whether we need to check the nullability. This is set to
+ * true when using Python, as this is the only avenue through
+ * which users can set nullability
+ * @param shouldSetNullable Whether we need to set the fields as nullable. This is set to
+ * true when using Scala, as case classes are set to
Review Comment:
I found this, `def nullable: Boolean = !isPrimitive` from AgnosticEncoder trait, so it's intended and not a bug. For the track I've asked to update the comment since it is not always non-nullable, but primitive types are nullable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org