You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pig.apache.org by ol...@apache.org on 2009/03/11 02:03:48 UTC

svn commit: r752333 - in /hadoop/pig/trunk: CHANGES.txt build.xml

Author: olga
Date: Wed Mar 11 01:03:47 2009
New Revision: 752333

URL: http://svn.apache.org/viewvc?rev=752333&view=rev
Log:
PIG-706:  Implement ant target to use findbugs on PIG (gkesavan via olgan)

Modified:
    hadoop/pig/trunk/CHANGES.txt
    hadoop/pig/trunk/build.xml

Modified: hadoop/pig/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/pig/trunk/CHANGES.txt?rev=752333&r1=752332&r2=752333&view=diff
==============================================================================
--- hadoop/pig/trunk/CHANGES.txt (original)
+++ hadoop/pig/trunk/CHANGES.txt Wed Mar 11 01:03:47 2009
@@ -463,3 +463,5 @@
     HOD case (sms)
 
     PIG-699: Implement forrest docs target in Pig Build (gkesavan via olgan)
+
+    PIG-706:  Implement ant target to use findbugs on PIG (gkesavan via olgan)

Modified: hadoop/pig/trunk/build.xml
URL: http://svn.apache.org/viewvc/hadoop/pig/trunk/build.xml?rev=752333&r1=752332&r2=752333&view=diff
==============================================================================
--- hadoop/pig/trunk/build.xml (original)
+++ hadoop/pig/trunk/build.xml Wed Mar 11 01:03:47 2009
@@ -467,5 +467,35 @@
             </tarfileset>
         </tar>
     </target>
+   
+    <!-- ================================================================== -->
+    <!-- Findbugs                                                           -->
+    <!-- ================================================================== -->
+
+    <property name="findbugs.home" value=""/>
+    <target name="findbugs" depends="check-for-findbugs, jar" if="findbugs.present" description="Run findbugs if present">
+    	<property name="findbugs.out.dir" value="${test.build.dir}/findbugs"/>
+    	<property name="findbugs.report.htmlfile" value="${findbugs.out.dir}/pig-findbugs-report.html"/>
+    	<property name="findbugs.report.xmlfile" value="${findbugs.out.dir}/pig-findbugs-report.xml"/>
+    	<taskdef name="findbugs" classname="edu.umd.cs.findbugs.anttask.FindBugsTask"
+        		classpath="${findbugs.home}/lib/findbugs-ant.jar" />
+	<mkdir dir="${findbugs.out.dir}"/>
+    	<findbugs home="${findbugs.home}" output="xml:withMessages"
+        		outputFile="${findbugs.report.xmlfile}" effort="max" jvmargs="-Xmx512M">
+      		<auxClasspath>
+        		<fileset dir="${lib.dir}">
+          			<include name="**/*.jar"/>
+        		</fileset>
+      		</auxClasspath>
+      		<sourcePath path="${src.dir}"/>
+      		<class location="${output.jarfile.core}" />
+    	</findbugs>
+        <xslt style="${findbugs.home}/src/xsl/default.xsl" in="${findbugs.report.xmlfile}"
+        		out="${findbugs.report.htmlfile}"/>
+    </target>
+	
+    <target name="check-for-findbugs">
+    	<available property="findbugs.present" file="${findbugs.home}/lib/findbugs.jar" />
+    </target>
 
 </project>