You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "aokolnychyi (via GitHub)" <gi...@apache.org> on 2023/04/27 15:50:54 UTC
[GitHub] [iceberg] aokolnychyi opened a new pull request, #7448: Spark 3.4: Remove deprecated classes
aokolnychyi opened a new pull request, #7448:
URL: https://github.com/apache/iceberg/pull/7448
Spark 3.4 will be released as a brand-new jar so deprecations for 3.3 don't apply. This is similar to what we did in 3.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #7448: Spark 3.4: Remove deprecated classes
Posted by "aokolnychyi (via GitHub)" <gi...@apache.org>.
aokolnychyi commented on code in PR #7448:
URL: https://github.com/apache/iceberg/pull/7448#discussion_r1179379912
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/VectorizedSparkParquetReaders.java:
##########
@@ -84,30 +84,6 @@ public static ColumnarBatchReader buildReader(
ColumnarBatchReader::new));
}
- /**
- * @deprecated will be removed in 1.3.0, use {@link #buildReader(Schema, MessageType, Map,
- * DeleteFilter)} instead.
- */
- @Deprecated
- public static ColumnarBatchReader buildReader(
Review Comment:
There are a few more deprecated methods in this class but they are used in tests to validate set/unset Arrow validity vectors. It is probably a good idea to keep them so that we continue to test that path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #7448: Spark 3.4: Remove deprecated classes
Posted by "aokolnychyi (via GitHub)" <gi...@apache.org>.
aokolnychyi commented on PR #7448:
URL: https://github.com/apache/iceberg/pull/7448#issuecomment-1526055815
Thanks, @szehon-ho!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi merged pull request #7448: Spark 3.4: Remove deprecated classes
Posted by "aokolnychyi (via GitHub)" <gi...@apache.org>.
aokolnychyi merged PR #7448:
URL: https://github.com/apache/iceberg/pull/7448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org