You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "cjohnson-confluent (via GitHub)" <gi...@apache.org> on 2026/07/16 15:12:16 UTC

[PR] [BP-2.0][FLINK-40003][runtime] Fix IOMetrics not visible to state transition listeners [flink]

cjohnson-confluent opened a new pull request, #28760:
URL: https://github.com/apache/flink/pull/28760

   Backport of #28555 to release-2.0.
   
   ## What is the purpose of the change
   
   `Execution.markFinished()` and `processFail()` updated accumulators and IOMetrics after `transitionState()`, so `ExecutionStateUpdateListener`s notified inline during the transition saw null from `getIOMetrics()`.
   
   This backport applies the same fix as master: a `transitionToTerminalState()` method with a `preCompletionAction` callback that runs after the state is set but before `terminalStateFuture` is completed and listeners are notified. Applied to `markFinished()`, `processFail()`, `completeCancelling()` and `recoverExecution()`.
   
   ## Brief change log
   
   Cherry-pick of c0f774fdcefab05cf25c986effaad78fa5ecff2a from master (via the release-2.2 backport 7244dc10ea4). The production change in `Execution.java` is identical to master. The new test is adapted for this branch: `DefaultExecutionGraph#registerExecutionStateUpdateListener` does not exist here, so the test wires its listener at graph construction time via `TestingDefaultExecutionGraphBuilder` instead of going through a scheduler.
   
   ## Verifying this change
   
   The four tests added in #28555 (`DefaultExecutionGraphDeploymentTest.testMetricsVisibleToListenersOn*`) are included, adapted as described above, and pass on this branch.
   
   ## Does this pull request potentially affect one of the following parts:
   
   Same as #28555: no dependencies, no public API, no serializers, no per-record code paths, no deployment/recovery impact, no S3 connector impact.
   
   ## Documentation
   
   Does this pull request introduce a new feature? no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [BP-2.0][FLINK-40003][runtime] Fix IOMetrics not visible to state transition listeners [flink]

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #28760:
URL: https://github.com/apache/flink/pull/28760#issuecomment-5005105094

   2.0 is not supported by the community anymore. Only the 2 most recent minor version (2.3 and 2.2 and the LTS 1.20 version) should be covered by backports.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [BP-2.0][FLINK-40003][runtime] Fix IOMetrics not visible to state transition listeners [flink]

Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #28760:
URL: https://github.com/apache/flink/pull/28760#issuecomment-5003769966

   Thanks for contribution
   
   since you use AI, can you use Generated-by: instead of Co-authored-by: as mentioned in Apache recommendations https://www.apache.org/legal/generative-tooling.html
   
   also the doc about this is in progress https://github.com/apache/flink/pull/27776/changes#r2979585031


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [BP-2.0][FLINK-40003][runtime] Fix IOMetrics not visible to state transition listeners [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #28760:
URL: https://github.com/apache/flink/pull/28760#issuecomment-4993580483

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "33c2a5217f6e05699268c99c10e64bdc96f1a5d9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "33c2a5217f6e05699268c99c10e64bdc96f1a5d9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 33c2a5217f6e05699268c99c10e64bdc96f1a5d9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [BP-2.0][FLINK-40003][runtime] Fix IOMetrics not visible to state transition listeners [flink]

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp closed pull request #28760: [BP-2.0][FLINK-40003][runtime] Fix IOMetrics not visible to state transition listeners
URL: https://github.com/apache/flink/pull/28760


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org