[jira] [Commented] (SPARK-10906) More efficient SparseMatrix.equals

["Rahul Palamuttam (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-10906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940640#comment-14940640 ] 

Rahul Palamuttam commented on SPARK-10906:
------------------------------------------

Hi,
Can I tackle this? 
I have been working on a patch and will create a pull RQ shortly. 

- Rahul P


> More efficient SparseMatrix.equals
> ----------------------------------
>
>                 Key: SPARK-10906
>                 URL: https://issues.apache.org/jira/browse/SPARK-10906
>             Project: Spark
>          Issue Type: Improvement
>          Components: MLlib
>            Reporter: Joseph K. Bradley
>            Priority: Minor
>
> SparseMatrix.equals currently uses toBreeze and then calls Breeze's equals method.  However, it looks like Breeze's equals is inefficient: [https://github.com/scalanlp/breeze/blob/1130e0de31948d19225179d8500a8d2d1cc337d0/math/src/main/scala/breeze/linalg/Matrix.scala#L132]
> Breeze iterates over all values, including implicit zeros.  We could make this more efficient.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org