You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/30 05:32:00 UTC
[GitHub] [incubator-superset] robdiciuccio opened a new pull request #8902:
Enable running of tests in tests/db_engine_specs
robdiciuccio opened a new pull request #8902: Enable running of tests in tests/db_engine_specs
URL: https://github.com/apache/incubator-superset/pull/8902
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Tests in `tests/db_engine_specs` are not currently running, due to `nosetests` requiring an `__init__.py` to recognize the folder as a module.
Before: Ran **504 tests** in 124.049s (py36-sqlite)
After: Ran **619 tests** in 121.567s (py36-sqlite)
Also includes a refactor and tests from https://github.com/apache/incubator-superset/pull/8733 in order to preserve cherry-picking.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
Ensure `db_engine_specs` tests are running locally and in CI.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@willbarrett @craig-rueda @dpgaspar @villebro
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8902: Enable
running of tests in tests/db_engine_specs
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #8902: Enable running of tests in tests/db_engine_specs
URL: https://github.com/apache/incubator-superset/pull/8902#issuecomment-569589160
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8902?src=pr&el=h1) Report
> Merging [#8902](https://codecov.io/gh/apache/incubator-superset/pull/8902?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/191aca1fb01b797dae21657021d8fcd1e836c40a?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8902?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8902 +/- ##
=======================================
Coverage 58.97% 58.97%
=======================================
Files 359 359
Lines 11333 11333
Branches 2787 2787
=======================================
Hits 6684 6684
Misses 4471 4471
Partials 178 178
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8902?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8902?src=pr&el=footer). Last update [191aca1...f5ac6bf](https://codecov.io/gh/apache/incubator-superset/pull/8902?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on issue #8902: Enable
running of tests in tests/db_engine_specs
Posted by GitBox <gi...@apache.org>.
willbarrett commented on issue #8902: Enable running of tests in tests/db_engine_specs
URL: https://github.com/apache/incubator-superset/pull/8902#issuecomment-569823642
Ouch. That's no good! Good find, and thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #8902: Enable
running of tests in tests/db_engine_specs
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #8902: Enable running of tests in tests/db_engine_specs
URL: https://github.com/apache/incubator-superset/pull/8902
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org