[GitHub] [incubator-superset] bolkedebruin commented on a change in pull request #7539: Improvements related to ASF release process

[GitBox <gi...@apache.org>]

bolkedebruin commented on a change in pull request #7539: Improvements related to ASF release process
URL: https://github.com/apache/incubator-superset/pull/7539#discussion_r289598435
 
 

 ##########
 File path: superset/data/birth_names.py
 ##########
 @@ -231,7 +231,7 @@ def load_birth_names():
             The source dataset came from
             <a href='https://github.com/hadley/babynames' target='_blank'>[here]</a>
         </p>
-        <img src='/static/assets/images/babytux.jpg'>
+        <img src="https://i.imgur.com/aLOIXcC.png">
 
 Review comment:
   Why not make it part of assets? MapBox *does* work behind a firewall if you pay for it or have the patience to compile your own. That's how we do it. I think it to be bad practice to rely on anything "outside". 
   
   What if someone replaced that image with porn? And you open it up at work? Or at school? Malware served via images wouldn't be the first time either

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org