You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/23 22:54:19 UTC
[GitHub] [airflow] DougForrest opened a new pull request #14404: Update docker-compose.yaml default AIRFLOW_IMAGE_NAME
DougForrest opened a new pull request #14404:
URL: https://github.com/apache/airflow/pull/14404
Updates default docker image name used in the docker compose file for v2-0-stable to run Airflow in the Running Airflow in Docker documentation. This change is consistent with current master branch.
closes: #14379
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed pull request #14404: Update docker-compose.yaml default AIRFLOW_IMAGE_NAME
Posted by GitBox <gi...@apache.org>.
kaxil closed pull request #14404:
URL: https://github.com/apache/airflow/pull/14404
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ljburtz commented on pull request #14404: Update docker-compose.yaml default AIRFLOW_IMAGE_NAME
Posted by GitBox <gi...@apache.org>.
ljburtz commented on pull request #14404:
URL: https://github.com/apache/airflow/pull/14404#issuecomment-808083089
to be able to follow the [tutorial](https://airflow.apache.org/docs/apache-airflow/stable/tutorial.html#example-pipeline-definition)
I had to change:
```
- image: ${AIRFLOW_IMAGE_NAME:-apache/airflow:2.0.1}
+ image: ${AIRFLOW_IMAGE_NAME:-apache/airflow:2.0.1-python3.8}
```
Otherwise, the DAG fails with the same serialization error reported by @DougForrest in #14379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #14404: Update docker-compose.yaml default AIRFLOW_IMAGE_NAME
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #14404:
URL: https://github.com/apache/airflow/pull/14404#issuecomment-786964794
Documentation for the development version uses development image: http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/apache-airflow/latest/start/docker.html
Documentation for the released version uses the released versions.
http://airflow.apache.org/docs/apache-airflow/stable/start/docker.html
We have tests that detect this type of problem.
https://github.com/apache/airflow/blob/master/docs/exts/docs_build/lint_checks.py#L321
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #14404: Update docker-compose.yaml default AIRFLOW_IMAGE_NAME
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #14404:
URL: https://github.com/apache/airflow/pull/14404#issuecomment-784571313
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org