You are viewing a plain text version of this content. The canonical link for it is here.
Posted to modperl-cvs@perl.apache.org by st...@apache.org on 2003/09/18 09:34:21 UTC
cvs commit: modperl-2.0/src/modules/perl modperl_filter.c
stas 2003/09/18 00:34:21
Modified: src/modules/perl modperl_filter.c
Log:
it is invalid to return HTTP_INTERNAL_SERVER_ERROR or any other HTTP
response code from modperl_wbucket_pass, therefore set the error code into
r->status and return APR_SUCCESS. Untill now response handler with messed
up response headers, were causing no response what so ever to the client.
LWP was assuming 500, and it was all fine, testing without LWP has
immediately revealed that there was a problem in the handling of this case.
Revision Changes Path
1.68 +2 -1 modperl-2.0/src/modules/perl/modperl_filter.c
Index: modperl_filter.c
===================================================================
RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_filter.c,v
retrieving revision 1.67
retrieving revision 1.68
diff -u -u -r1.67 -r1.68
--- modperl_filter.c 13 Sep 2003 20:35:33 -0000 1.67
+++ modperl_filter.c 18 Sep 2003 07:34:21 -0000 1.68
@@ -130,8 +130,9 @@
ap_log_error(APLOG_MARK, APLOG_WARNING,
0, r->server, "%s did not send an HTTP header",
r->uri);
+ r->status = status;
/* XXX: bodytext == NULL here */
- return status;
+ return APR_SUCCESS;
}
else if (!bodytext) {
return APR_SUCCESS;