You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/02/01 21:14:33 UTC

[GitHub] [maven] michael-o opened a new pull request #322: [MNG-6859] Build not reproducible when built from source release

michael-o opened a new pull request #322: [MNG-6859] Build not reproducible when built from source release
URL: https://github.com/apache/maven/pull/322
 
 
   This closes #322

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] michael-o commented on a change in pull request #322: [MNG-6859] Build not reproducible when built from source release

Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #322: [MNG-6859] Build not reproducible when built from source release
URL: https://github.com/apache/maven/pull/322#discussion_r373831808
 
 

 ##########
 File path: maven-core/pom.xml
 ##########
 @@ -164,31 +164,6 @@ under the License.
             </excludes>
           </configuration>
         </plugin>
-        <!--This plugin's configuration is used to store Eclipse m2e settings only. It has no influence on the Maven build itself.-->
 
 Review comment:
   @slachiewicz Correct.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] eolivelli commented on a change in pull request #322: [MNG-6859] Build not reproducible when built from source release

Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #322: [MNG-6859] Build not reproducible when built from source release
URL: https://github.com/apache/maven/pull/322#discussion_r373826088
 
 

 ##########
 File path: maven-core/pom.xml
 ##########
 @@ -164,31 +164,6 @@ under the License.
             </excludes>
           </configuration>
         </plugin>
-        <!--This plugin's configuration is used to store Eclipse m2e settings only. It has no influence on the Maven build itself.-->
 
 Review comment:
   Is this change related to the issue somehow?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] slachiewicz commented on a change in pull request #322: [MNG-6859] Build not reproducible when built from source release

Posted by GitBox <gi...@apache.org>.
slachiewicz commented on a change in pull request #322: [MNG-6859] Build not reproducible when built from source release
URL: https://github.com/apache/maven/pull/322#discussion_r373831593
 
 

 ##########
 File path: maven-core/pom.xml
 ##########
 @@ -164,31 +164,6 @@ under the License.
             </excludes>
           </configuration>
         </plugin>
-        <!--This plugin's configuration is used to store Eclipse m2e settings only. It has no influence on the Maven build itself.-->
 
 Review comment:
   It's obsolete as we no longer use create-timestamp goal.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] asfgit closed pull request #322: [MNG-6859] Build not reproducible when built from source release

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #322: [MNG-6859] Build not reproducible when built from source release
URL: https://github.com/apache/maven/pull/322
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services