You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/09/15 12:23:37 UTC

[GitHub] [incubator-mxnet] sfraczek opened a new pull request #19152: [BUGFIX] FindMKL.cmake fix comment and cmake variables and search paths

sfraczek opened a new pull request #19152:
URL: https://github.com/apache/incubator-mxnet/pull/19152


   ## Description ##
   Fixes to small bugs in FindMKL.cmake explained here: https://github.com/apache/incubator-mxnet/issues/19151
   
   
   ## Checklist ##
   ### Essentials ###
   - [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] Code is well-documented
   
   ## Comments ##
   Regarding backwards compatibility: If someone previously used MKL_ROOT environment variable set manually because MKLROOT wasn't working, then this change may break things for them if they don't have MKLROOT env var set (which is done by sourcing mklvars.sh by the book https://software.intel.com/content/www/us/en/develop/documentation/mkl-linux-developer-guide/top/getting-started/setting-environment-variables/scripts-to-set-environment-variables.html).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19152: [BUGFIX] FindMKL.cmake fix comment and cmake variables and search paths

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19152:
URL: https://github.com/apache/incubator-mxnet/pull/19152#issuecomment-692679590


   Hey @sfraczek , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [windows-cpu, unix-gpu, edge, sanity, windows-gpu, unix-cpu, centos-gpu, website, miscellaneous, clang, centos-cpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] leezu merged pull request #19152: [BUGFIX] FindMKL.cmake fix comment and cmake variables and search paths

Posted by GitBox <gi...@apache.org>.
leezu merged pull request #19152:
URL: https://github.com/apache/incubator-mxnet/pull/19152


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org