You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Jeanne Waldman (JIRA)" <de...@myfaces.apache.org> on 2010/03/29 22:04:28 UTC
[jira] Created: (TRINIDAD-1767) throw an IllegalStateException on
SkinFactory.addSkin for duplicate skins.
throw an IllegalStateException on SkinFactory.addSkin for duplicate skins.
--------------------------------------------------------------------------
Key: TRINIDAD-1767
URL: https://issues.apache.org/jira/browse/TRINIDAD-1767
Project: MyFaces Trinidad
Issue Type: Improvement
Components: Skinning
Affects Versions: 1.2.13-core
Reporter: Jeanne Waldman
hrow an IllegalStateException from Trinidad's SkinFactory.addSkin() method
if a skin id that already exists is added again. This will not change the
method signature since IllegalStateException is an unchecked exception.
This will keep a duplicate skin from overriding an existing one.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-1767) throw an IllegalStateException on
SkinFactory.addSkin for duplicate skins.
Posted by "Ali Ok (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ali Ok updated TRINIDAD-1767:
-----------------------------
Status: Patch Available (was: Open)
> throw an IllegalStateException on SkinFactory.addSkin for duplicate skins.
> --------------------------------------------------------------------------
>
> Key: TRINIDAD-1767
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1767
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Skinning
> Affects Versions: 1.2.13-core
> Reporter: Jeanne Waldman
> Attachments: 1767_1.2.x.patch, 1767_2.0.x.patch
>
>
> hrow an IllegalStateException from Trinidad's SkinFactory.addSkin() method
> if a skin id that already exists is added again. This will not change the
> method signature since IllegalStateException is an unchecked exception.
> This will keep a duplicate skin from overriding an existing one.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-1767) throw an IllegalStateException on
SkinFactory.addSkin for duplicate skins.
Posted by "Ali Ok (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853344#action_12853344 ]
Ali Ok commented on TRINIDAD-1767:
----------------------------------
Javadoc of SkinFactory.addSkin method:
"Register the specified Skin instance, associated with the specified skinId, to be supported by this SkinFactory, replacing any previously registered Skin for this identifier."
Behavior of adding a skin with existing skinId is clearly replacing the older skin.
I prepared the patch to throw exception for duplicate skin ids, but I wanted to ask you: are we clear on this issue?
> throw an IllegalStateException on SkinFactory.addSkin for duplicate skins.
> --------------------------------------------------------------------------
>
> Key: TRINIDAD-1767
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1767
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Skinning
> Affects Versions: 1.2.13-core
> Reporter: Jeanne Waldman
>
> hrow an IllegalStateException from Trinidad's SkinFactory.addSkin() method
> if a skin id that already exists is added again. This will not change the
> method signature since IllegalStateException is an unchecked exception.
> This will keep a duplicate skin from overriding an existing one.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.