You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by sw...@apache.org on 2016/04/28 22:04:13 UTC

[6/7] git commit: updated refs/heads/4.8 to d11194a

Merge pull request #1500 from myENA/KVM_root_detach

CLOUDSTACK-9349: Enable root disk detach for KVM with new Marvin testsThis PR addresses the KVM detach/attach ROOT disks from VMs (CLOUDSTACK-9349).  In short, this allows the KVM Hypervisor, and I added the Simulator as a valid hypervisor for ease of development and testing of marvin, to detach a root volume and the reattach a root volume using the deviceid=0 flag to the attachVolume API.  I have also written a marvin integration test that verifies this feature works for both KVM and the Simulator.

Below is the marvin results files of the full marvin test_volumes.py.  All tests pass, including the new root detach/attach, on our KVM lab running with the patches in this PR.

[test_volumes_KIR4G3.zip](https://github.com/apache/cloudstack/files/223799/test_volumes_KIR4G3.zip)

* pr/1500:
  Removed sleeps and used validateList as requested.
  Added required_hardware="false" attr above test_02_root_volume_attach_detach
  Modified test_volumes.py to include a hypervisor test for root attach/detach testing
  Let hypervisor type KVM and Simulator detach root volumes. Updated test_volumes.py to include a test for detaching and reattaching a root volume from a vm. I also had to update base.py to allow attach_volume to have the parameter deviceid to be passed as needed.

Signed-off-by: Will Stevens <wi...@gmail.com>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/1979f42b
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/1979f42b
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/1979f42b

Branch: refs/heads/4.8
Commit: 1979f42b2d24e7d3ddaa71eeb0a01fde51dfd976
Parents: c03e359 73cd427
Author: Will Stevens <wi...@gmail.com>
Authored: Thu Apr 28 16:02:53 2016 -0400
Committer: Will Stevens <wi...@gmail.com>
Committed: Thu Apr 28 16:02:54 2016 -0400

----------------------------------------------------------------------
 .../com/cloud/storage/VolumeApiServiceImpl.java |   4 +-
 test/integration/component/test_volumes.py      | 135 ++++++++++++++++++-
 tools/marvin/marvin/lib/base.py                 |   6 +-
 3 files changed, 141 insertions(+), 4 deletions(-)
----------------------------------------------------------------------