You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zy-kkk (via GitHub)" <gi...@apache.org> on 2023/06/06 09:42:32 UTC
[GitHub] [doris] zy-kkk opened a new pull request, #20500: [Refactor](External) Move Common ODBC Methods to JDBC Class and Add D…
zy-kkk opened a new pull request, #20500:
URL: https://github.com/apache/doris/pull/20500
…efault config to Disable ODBC Creation
## Proposed changes
Issue Number: close #xxx
This PR addresses the refactoring of common methods that were originally located within the ODBC classes, but were used by the JDBC classes. These methods have now been moved to the JDBC classes to improve code readability and maintainability.
In addition, we have disabled the creation of ODBC external tables by default. However, this will not affect the existing usage of ODBC. You can still enable the ODBC external tables through the `enable_odbc_table` setting. Please be aware that we plan to completely remove the ODBC external tables in future versions, so we recommend using the JDBC Catalog as a priority.
Please note that these changes do not alter the existing behavior of the application. They are intended to make the code more clean, efficient, and manageable.
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zy-kkk commented on pull request #20500: [Refactor](External) Move Common ODBC Methods to JDBC Class and Add Default config to Disable ODBC Creation
Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk commented on PR #20500:
URL: https://github.com/apache/doris/pull/20500#issuecomment-1579960578
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zy-kkk commented on pull request #20500: [Refactor](External) Move Common ODBC Methods to JDBC Class and Add Default config to Disable ODBC Creation
Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk commented on PR #20500:
URL: https://github.com/apache/doris/pull/20500#issuecomment-1580454972
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zy-kkk commented on pull request #20500: [Refactor](External) Move Common ODBC Methods to JDBC Class and Add Default config to Disable ODBC Creation
Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk commented on PR #20500:
URL: https://github.com/apache/doris/pull/20500#issuecomment-1578338832
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zy-kkk closed pull request #20500: [Refactor](External) Move Common ODBC Methods to JDBC Class and Add Default config to Disable ODBC Creation
Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk closed pull request #20500: [Refactor](External) Move Common ODBC Methods to JDBC Class and Add Default config to Disable ODBC Creation
URL: https://github.com/apache/doris/pull/20500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zy-kkk commented on pull request #20500: [Refactor](External) Move Common ODBC Methods to JDBC Class and Add Default config to Disable ODBC Creation
Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk commented on PR #20500:
URL: https://github.com/apache/doris/pull/20500#issuecomment-1579853707
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zy-kkk commented on pull request #20500: [Refactor](External) Move Common ODBC Methods to JDBC Class and Add Default config to Disable ODBC Creation
Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk commented on PR #20500:
URL: https://github.com/apache/doris/pull/20500#issuecomment-1578702078
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zy-kkk commented on pull request #20500: [Refactor](External) Move Common ODBC Methods to JDBC Class and Add Default config to Disable ODBC Creation
Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk commented on PR #20500:
URL: https://github.com/apache/doris/pull/20500#issuecomment-1581022376
Resubmitted by #111 #20566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org