[GitHub] mrutkows commented on a change in pull request #754: Adding support for default package

[GitBox <gi...@apache.org>]

mrutkows commented on a change in pull request #754: Adding support for default package
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/754#discussion_r171094079
 
 

 ##########
 File path: deployers/servicedeployer.go
 ##########
 @@ -1136,9 +1137,15 @@ func (deployer *ServiceDeployer) UnDeployDependencies() error {
 
 func (deployer *ServiceDeployer) UnDeployPackages(deployment *DeploymentProject) error {
 	for _, pack := range deployment.Packages {
-		err := deployer.deletePackage(pack.Package)
-		if err != nil {
-			return err
+		// "default" package is a reserved package name
+		// all openwhisk entities were deployed under
+		// /<namespace> instead of /<namespace>/<package> and
+		// therefore skip deleting default package during undeployment
+		if strings.ToLower(pack.Package.Name) != parsers.DEFAULT_PACKAGE {
 
 Review comment:
   Do we still need to delete it from /namespace ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services