You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/30 16:03:32 UTC
[GitHub] [tvm] gigiblender opened a new pull request, #11969: [CI] Skip some additional tests that are failing in the wheel
gigiblender opened a new pull request, #11969:
URL: https://github.com/apache/tvm/pull/11969
This PR skips some additional tests that are failing in the nightly wheel.
@driazati @areusch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati merged pull request #11969: [CI] Skip some additional tests that are failing in the wheel
Posted by GitBox <gi...@apache.org>.
driazati merged PR #11969:
URL: https://github.com/apache/tvm/pull/11969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #11969: [CI] Skip some additional tests that are failing in the wheel
Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #11969:
URL: https://github.com/apache/tvm/pull/11969#discussion_r911283290
##########
python/tvm/testing/utils.py:
##########
@@ -95,7 +95,8 @@ def test_something():
SKIP_SLOW_TESTS = os.getenv("SKIP_SLOW_TESTS", "").lower() in {"true", "1", "yes"}
skip_if_wheel_test = pytest.mark.skipif(
- os.getenv("WHEEL_TEST") is not None, reason="Test not supported in wheel."
+ os.getenv("WHEEL_TEST") is not None and len(os.getenv("WHEEL_TEST")) != 0,
Review Comment:
can we check for a positive value here instead of just any string? (copied the values from `SKIP_SLOW_TESTS` above
```suggestion
os.getenv("WHEEL_TEST", "").lower() in {"true", "1", "yes"},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] github-actions[bot] commented on pull request #11969: [CI] Skip some additional tests that are failing in the wheel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11969:
URL: https://github.com/apache/tvm/pull/11969#issuecomment-1171613550
<!---docs-bot-comment-->
Built docs for commit d8ebc069b63cfad6f42b8fe4ee3e04568fd660fd can be found [here](https://pr-docs.tlcpack.ai/PR-11969/3/docs/index.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #11969: [CI] Skip some additional tests that are failing in the wheel
Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #11969:
URL: https://github.com/apache/tvm/pull/11969#discussion_r911283290
##########
python/tvm/testing/utils.py:
##########
@@ -95,7 +95,8 @@ def test_something():
SKIP_SLOW_TESTS = os.getenv("SKIP_SLOW_TESTS", "").lower() in {"true", "1", "yes"}
skip_if_wheel_test = pytest.mark.skipif(
- os.getenv("WHEEL_TEST") is not None, reason="Test not supported in wheel."
+ os.getenv("WHEEL_TEST") is not None and len(os.getenv("WHEEL_TEST")) != 0,
Review Comment:
can we check for a positive value here instead of just any string? (copied the values from `SKIP_SLOW_TESTS` above)
```suggestion
os.getenv("WHEEL_TEST", "").lower() in {"true", "1", "yes"},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org