You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by zhou xing <xi...@cn.ibm.com> on 2016/04/07 10:56:04 UTC

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/
-----------------------------------------------------------

(Updated April 7, 2016, 8:56 a.m.)


Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod Kone.


Changes
-------

rebased code and add CHANGELOG


Bugs: mesos-4580
    https://issues.apache.org/jira/browse/mesos-4580


Repository: mesos


Description (updated)
-------

Modify the return code of the following endpoints to 202:
1. /reserve
2. /unreserve
3. /create-volumes
4. /destroy-volumes

[#MESOS-4580]


Diffs (updated)
-----

  CHANGELOG 4553465cc3dc17956f168469d405f7a453d6359e 
  docs/endpoints/master/create-volumes.md 52ae3a8159bb7d26b63f5889ce3f122371afbdc4 
  docs/endpoints/master/destroy-volumes.md a0bb1e8d1ce42ab2b96518cd4d325bfc541ad4ff 
  docs/endpoints/master/reserve.md 1d481b56d380d45218001513330b225ca4a0a55c 
  docs/endpoints/master/unreserve.md b9282df659ebb6090ef49ef8fc0f01411cd53103 
  docs/persistent-volume.md ab6ed8227259384261dd5f7c2e353753f20e5c19 
  docs/reservation.md 75357206085848826b70c2d6f2be93d20e771604 
  docs/upgrades.md 64c6a02dd54ddf06c557b38e08916dc10e484cdd 
  src/master/http.cpp f781fd0102c247b2e77a71f7be82b872b0831681 
  src/tests/persistent_volume_endpoints_tests.cpp 9b8ad34469c0c9a986aa60f3a52584a3a9eabb2b 
  src/tests/reservation_endpoints_tests.cpp 2e0f6c1aba95d918b8c42219ee97f79f1070d56e 

Diff: https://reviews.apache.org/r/44606/diff/


Testing
-------


Thanks,

zhou xing


Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

Posted by zhou xing <xi...@cn.ibm.com>.

> On 四月 7, 2016, 10:13 p.m., Neil Conway wrote:
> > docs/persistent-volume.md, line 296
> > <https://reviews.apache.org/r/44606/diff/3/?file=1329462#file1329462line296>
> >
> >     Replace "Returns `202 ACCEPTED` which" with "This endpoint returns the `202 ACCEPTED` HTTP status code, which " -- here and below.

Thanks Neil for your review


> On 四月 7, 2016, 10:13 p.m., Neil Conway wrote:
> > docs/upgrades.md, line 167
> > <https://reviews.apache.org/r/44606/diff/3/?file=1329464#file1329464line167>
> >
> >     Replace "return code" with "HTTP status code"
> >     
> >     I think you can just remove "which may introduce backwards incompatibility issue" (if we're keeping it, the grammar isn't quite right).

Thanks Neil for your review


- zhou


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review127678
-----------------------------------------------------------


On 四月 7, 2016, 8:56 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> -----------------------------------------------------------
> 
> (Updated 四月 7, 2016, 8:56 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: mesos-4580
>     https://issues.apache.org/jira/browse/mesos-4580
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 4553465cc3dc17956f168469d405f7a453d6359e 
>   docs/endpoints/master/create-volumes.md 52ae3a8159bb7d26b63f5889ce3f122371afbdc4 
>   docs/endpoints/master/destroy-volumes.md a0bb1e8d1ce42ab2b96518cd4d325bfc541ad4ff 
>   docs/endpoints/master/reserve.md 1d481b56d380d45218001513330b225ca4a0a55c 
>   docs/endpoints/master/unreserve.md b9282df659ebb6090ef49ef8fc0f01411cd53103 
>   docs/persistent-volume.md ab6ed8227259384261dd5f7c2e353753f20e5c19 
>   docs/reservation.md 75357206085848826b70c2d6f2be93d20e771604 
>   docs/upgrades.md 64c6a02dd54ddf06c557b38e08916dc10e484cdd 
>   src/master/http.cpp f781fd0102c247b2e77a71f7be82b872b0831681 
>   src/tests/persistent_volume_endpoints_tests.cpp 9b8ad34469c0c9a986aa60f3a52584a3a9eabb2b 
>   src/tests/reservation_endpoints_tests.cpp 2e0f6c1aba95d918b8c42219ee97f79f1070d56e 
> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review127678
-----------------------------------------------------------


Fix it, then Ship it!





docs/persistent-volume.md (line 296)
<https://reviews.apache.org/r/44606/#comment191068>

    Replace "Returns `202 ACCEPTED` which" with "This endpoint returns the `202 ACCEPTED` HTTP status code, which " -- here and below.



docs/upgrades.md (line 167)
<https://reviews.apache.org/r/44606/#comment191061>

    Replace "return code" with "HTTP status code"
    
    I think you can just remove "which may introduce backwards incompatibility issue" (if we're keeping it, the grammar isn't quite right).


- Neil Conway


On April 7, 2016, 8:56 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 8:56 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: mesos-4580
>     https://issues.apache.org/jira/browse/mesos-4580
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 4553465cc3dc17956f168469d405f7a453d6359e 
>   docs/endpoints/master/create-volumes.md 52ae3a8159bb7d26b63f5889ce3f122371afbdc4 
>   docs/endpoints/master/destroy-volumes.md a0bb1e8d1ce42ab2b96518cd4d325bfc541ad4ff 
>   docs/endpoints/master/reserve.md 1d481b56d380d45218001513330b225ca4a0a55c 
>   docs/endpoints/master/unreserve.md b9282df659ebb6090ef49ef8fc0f01411cd53103 
>   docs/persistent-volume.md ab6ed8227259384261dd5f7c2e353753f20e5c19 
>   docs/reservation.md 75357206085848826b70c2d6f2be93d20e771604 
>   docs/upgrades.md 64c6a02dd54ddf06c557b38e08916dc10e484cdd 
>   src/master/http.cpp f781fd0102c247b2e77a71f7be82b872b0831681 
>   src/tests/persistent_volume_endpoints_tests.cpp 9b8ad34469c0c9a986aa60f3a52584a3a9eabb2b 
>   src/tests/reservation_endpoints_tests.cpp 2e0f6c1aba95d918b8c42219ee97f79f1070d56e 
> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review128344
-----------------------------------------------------------



Patch looks great!

Reviews applied: [42705, 44606]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 12, 2016, 5:20 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> -----------------------------------------------------------
> 
> (Updated April 12, 2016, 5:20 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: mesos-4580
>     https://issues.apache.org/jira/browse/mesos-4580
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 1f0527e86e333970f7f7879bb2bcbc33f0f44bc3 
>   docs/endpoints/master/create-volumes.md 52ae3a8159bb7d26b63f5889ce3f122371afbdc4 
>   docs/endpoints/master/destroy-volumes.md a0bb1e8d1ce42ab2b96518cd4d325bfc541ad4ff 
>   docs/endpoints/master/reserve.md 1d481b56d380d45218001513330b225ca4a0a55c 
>   docs/endpoints/master/unreserve.md b9282df659ebb6090ef49ef8fc0f01411cd53103 
>   docs/persistent-volume.md ab6ed8227259384261dd5f7c2e353753f20e5c19 
>   docs/reservation.md 75357206085848826b70c2d6f2be93d20e771604 
>   docs/upgrades.md 64c6a02dd54ddf06c557b38e08916dc10e484cdd 
>   src/master/http.cpp 626c88f85910c4e476194f203341c4db7053e0f0 
>   src/tests/persistent_volume_endpoints_tests.cpp 9b8ad34469c0c9a986aa60f3a52584a3a9eabb2b 
>   src/tests/reservation_endpoints_tests.cpp 2e0f6c1aba95d918b8c42219ee97f79f1070d56e 
> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

Posted by zhou xing <xi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/
-----------------------------------------------------------

(Updated 四月 12, 2016, 5:20 a.m.)


Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod Kone.


Changes
-------

rebase and update the code per Neil's comments


Bugs: mesos-4580
    https://issues.apache.org/jira/browse/mesos-4580


Repository: mesos


Description
-------

Modify the return code of the following endpoints to 202:
1. /reserve
2. /unreserve
3. /create-volumes
4. /destroy-volumes

[#MESOS-4580]


Diffs (updated)
-----

  CHANGELOG 1f0527e86e333970f7f7879bb2bcbc33f0f44bc3 
  docs/endpoints/master/create-volumes.md 52ae3a8159bb7d26b63f5889ce3f122371afbdc4 
  docs/endpoints/master/destroy-volumes.md a0bb1e8d1ce42ab2b96518cd4d325bfc541ad4ff 
  docs/endpoints/master/reserve.md 1d481b56d380d45218001513330b225ca4a0a55c 
  docs/endpoints/master/unreserve.md b9282df659ebb6090ef49ef8fc0f01411cd53103 
  docs/persistent-volume.md ab6ed8227259384261dd5f7c2e353753f20e5c19 
  docs/reservation.md 75357206085848826b70c2d6f2be93d20e771604 
  docs/upgrades.md 64c6a02dd54ddf06c557b38e08916dc10e484cdd 
  src/master/http.cpp 626c88f85910c4e476194f203341c4db7053e0f0 
  src/tests/persistent_volume_endpoints_tests.cpp 9b8ad34469c0c9a986aa60f3a52584a3a9eabb2b 
  src/tests/reservation_endpoints_tests.cpp 2e0f6c1aba95d918b8c42219ee97f79f1070d56e 

Diff: https://reviews.apache.org/r/44606/diff/


Testing
-------


Thanks,

zhou xing


Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review127578
-----------------------------------------------------------



Patch looks great!

Reviews applied: [42705, 44606]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 7, 2016, 8:56 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 8:56 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: mesos-4580
>     https://issues.apache.org/jira/browse/mesos-4580
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 4553465cc3dc17956f168469d405f7a453d6359e 
>   docs/endpoints/master/create-volumes.md 52ae3a8159bb7d26b63f5889ce3f122371afbdc4 
>   docs/endpoints/master/destroy-volumes.md a0bb1e8d1ce42ab2b96518cd4d325bfc541ad4ff 
>   docs/endpoints/master/reserve.md 1d481b56d380d45218001513330b225ca4a0a55c 
>   docs/endpoints/master/unreserve.md b9282df659ebb6090ef49ef8fc0f01411cd53103 
>   docs/persistent-volume.md ab6ed8227259384261dd5f7c2e353753f20e5c19 
>   docs/reservation.md 75357206085848826b70c2d6f2be93d20e771604 
>   docs/upgrades.md 64c6a02dd54ddf06c557b38e08916dc10e484cdd 
>   src/master/http.cpp f781fd0102c247b2e77a71f7be82b872b0831681 
>   src/tests/persistent_volume_endpoints_tests.cpp 9b8ad34469c0c9a986aa60f3a52584a3a9eabb2b 
>   src/tests/reservation_endpoints_tests.cpp 2e0f6c1aba95d918b8c42219ee97f79f1070d56e 
> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> zhou xing
> 
>