You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/15 02:43:08 UTC
[GitHub] [spark] LuciferYang commented on pull request #37480: [SPARK-40046][SQL][SS] Use Jackson instead of json4s to serialize `RocksDBMetrics`
LuciferYang commented on PR #37480:
URL: https://github.com/apache/spark/pull/37480#issuecomment-1214553834
In [SPARK-39489](https://github.com/apache/spark/pull/36885), for `Why are the changes needed?`, some of the reasons are as follows:
```
In addition, this is a stepping-stone towards eventually being able to remove our Json4s dependency:
Today Spark uses Json4s 3.x and this causes library conflicts for end users who want to upgrade to 4.x; see https://github.com/apache/spark/pull/33630 for one example.
To completely remove Json4s we'll need to update several other parts of Spark (including code used for ML model serialization); this PR is just a first step towards that goal if we decide to pursue it.
In this PR, I continue to use Json4s in test code; I think it's fine to keep Json4s as a test-only dependency.
```
I'm not sure if @JoshRosen has plans for the next step and the overall blueprint for this. I'm just learning this [SPARK-39489](https://github.com/apache/spark/pull/36885) and trying to start with some simple cases. Similarly, I submitted another pr: https://github.com/apache/spark/pull/37515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org