You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2014/11/29 04:19:59 UTC
[Bug 57282] New: request process UML diagram seems outdated
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282
Bug ID: 57282
Summary: request process UML diagram seems outdated
Product: Tomcat 7
Version: 7.0.56
Hardware: PC
Status: NEW
Severity: normal
Priority: P2
Component: Documentation
Assignee: dev@tomcat.apache.org
Reporter: chrwhy@gmail.com
apache-tomcat-7.0.56/webapps/docs/architecture/requestProcess/requestProcess.pdf
it is about the request process UML diagram, I have been reading tomcat 7.0.56
source code for weeks, and along with source code reading along with debug
which helps so much, and one day after I debgued the whole end-to-end request
flow, I found that the document seems is derived from Tomcat 5(please check the
footer of the pdf).
and there are few steps on the diagram which are different from my
finding/debuging.
Please kindly check attachments, thanks!
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57282] request process UML diagram seems outdated
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282
--- Comment #2 from Stephen Chen <ch...@gmail.com> ---
Created attachment 32237
--> https://issues.apache.org/bugzilla/attachment.cgi?id=32237&action=edit
Page 1 step
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57282] request process UML diagram seems outdated
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282
--- Comment #1 from Stephen Chen <ch...@gmail.com> ---
Created attachment 32236
--> https://issues.apache.org/bugzilla/attachment.cgi?id=32236&action=edit
Page 2 step
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57282] request process UML diagram seems outdated
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282
--- Comment #11 from Stephen Chen <ch...@gmail.com> ---
Created attachment 32345
--> https://issues.apache.org/bugzilla/attachment.cgi?id=32345&action=edit
authenticate and realm
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57282] request process UML diagram seems outdated
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282
--- Comment #13 from Mark Thomas <ma...@apache.org> ---
Broadly it looks OK but the detail around the Pipelines isn't right. Calls to
getFirst() are missing and some method names shown don't exist. Also methods
are being called on the wrong objects (e.g. getHost() on the StandardHost).
Similar comments apply to the Authentication diagram. For example getContext()
is shown as being called on StandardContext.
I'd consider ignoring the various getHost(), getPipeline() calls and just show
the calls that do the real work.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57282] request process UML diagram seems outdated
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282
--- Comment #9 from Stephen Chen <ch...@gmail.com> ---
(In reply to Mark Thomas from comment #8)
> The calls prior to CoyoteAdapter don't look right. Specifically, there is no
> Http11Processor and no SocketProcessor. After that things look OK. I do
> wonder if it would be more useful with an Authenticator + Realm configured.
> Maybe that should/could be in a separate diagram.
Mark, I was thinking about Http11Protocol represents both SockeProcessor(before
Http11Protocol) and Http11Processor(after Http11Protocol) which is not right,
the call hierarchy is very clear(at in the source code) and it should be
reflected in the diagram accordingly.
thanks for your comments, would supplement missed part, and as your said
authenticator + Realm diagram would be very useful, would supplement
accordingly too.
Regards
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57282] request process UML diagram seems outdated
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282
--- Comment #19 from Stephen Chen <ch...@gmail.com> ---
Created attachment 32418
--> https://issues.apache.org/bugzilla/attachment.cgi?id=32418&action=edit
add missed methods
authentication diagram V4
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57282] request process UML diagram seems outdated
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282
--- Comment #5 from Mark Thomas <ma...@apache.org> ---
You are part of community too. No-one else has stepped up to do this so if you
want to fix these diagrams go for it.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57282] request process UML diagram seems outdated
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282
--- Comment #10 from Stephen Chen <ch...@gmail.com> ---
Created attachment 32344
--> https://issues.apache.org/bugzilla/attachment.cgi?id=32344&action=edit
request process(revised)
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57282] request process UML diagram seems outdated
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282
--- Comment #14 from Stephen Chen <ch...@gmail.com> ---
Created attachment 32368
--> https://issues.apache.org/bugzilla/attachment.cgi?id=32368&action=edit
Revised(V3) request process according to Mark's comment
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57282] request process UML diagram seems outdated
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282
--- Comment #4 from Stephen Chen <ch...@gmail.com> ---
(In reply to Mark Thomas from comment #3)
> Yes, those diagrams are out of date.
>
> The problem is bigger than you have identified. Page 2 is completely wrong.
> The call sequence is very different.
Hi Mark,
community would fix that in the future? or what can I help ?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57282] request process UML diagram seems outdated
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282
--- Comment #7 from Stephen Chen <ch...@gmail.com> ---
Created attachment 32329
--> https://issues.apache.org/bugzilla/attachment.cgi?id=32329&action=edit
Tomcat 7.0 request process flow
Hi Mark, please check the drafted request reprocess diagram, since the exported
UML pdf is not that readable, please check whether the diagram meets or not
first, thanks!
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57282] request process UML diagram seems outdated
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS| |All
--- Comment #3 from Mark Thomas <ma...@apache.org> ---
Yes, those diagrams are out of date.
The problem is bigger than you have identified. Page 2 is completely wrong. The
call sequence is very different.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57282] request process UML diagram seems outdated
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282
--- Comment #18 from Stephen Chen <ch...@gmail.com> ---
Created attachment 32417
--> https://issues.apache.org/bugzilla/attachment.cgi?id=32417&action=edit
add missed methods
Request process V4
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57282] request process UML diagram seems outdated
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282
--- Comment #15 from Stephen Chen <ch...@gmail.com> ---
Created attachment 32369
--> https://issues.apache.org/bugzilla/attachment.cgi?id=32369&action=edit
Revised(V3) authenticate process according to Mark's comment
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57282] request process UML diagram seems outdated
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282
--- Comment #17 from Mark Thomas <ma...@apache.org> ---
Looking better. Some of the method calls are missing method names which makes
it hard to review and less useful to the reader.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57282] request process UML diagram seems outdated
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |enhancement
--- Comment #6 from Mark Thomas <ma...@apache.org> ---
This isn't going to stop a release so mark as an enhancement.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57282] request process UML diagram seems outdated
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282
--- Comment #16 from Stephen Chen <ch...@gmail.com> ---
(In reply to Mark Thomas from comment #13)
> Broadly it looks OK but the detail around the Pipelines isn't right. Calls
> to getFirst() are missing and some method names shown don't exist. Also
> methods are being called on the wrong objects (e.g. getHost() on the
> StandardHost).
>
> Similar comments apply to the Authentication diagram. For example
> getContext() is shown as being called on StandardContext.
>
> I'd consider ignoring the various getHost(), getPipeline() calls and just
> show the calls that do the real work.
Mark, thanks for your valuable comment as a reader.
That diagram wasn't that strict, since in my mind, I wanted to express the
process in a verbose&abstract way which is confusing people.
I have removed those unnecessary methods(getHost, getContext...) from previous
diagrams, please check the latest ones and give comments, would be delighted to
help.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57282] request process UML diagram seems outdated
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282
--- Comment #12 from Stephen Chen <ch...@gmail.com> ---
Hi Mark, please help to review the revised&advise request process and
Authenticator&Realm diagrams, thanks!
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57282] request process UML diagram seems outdated
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282
--- Comment #8 from Mark Thomas <ma...@apache.org> ---
The calls prior to CoyoteAdapter don't look right. Specifically, there is no
Http11Processor and no SocketProcessor. After that things look OK. I do wonder
if it would be more useful with an Authenticator + Realm configured. Maybe that
should/could be in a separate diagram.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org