You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2022/02/14 19:43:13 UTC
Review Request 73845: RANGER-3614:Make audit log for INSERT, UPDATE, DELETE, TRUNCATE statement of hive table recognizable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73845/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3614
https://issues.apache.org/jira/browse/RANGER-3614
Repository: ranger
Description
-------
RANGER-3614:Make audit log for INSERT, UPDATE, DELETE, TRUNCATE statement of hive table recognizable
Diffs
-----
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuditHandler.java c0aac28aa
Diff: https://reviews.apache.org/r/73845/diff/1/
Testing
-------
- Testing done in Local VM with various DML operation for HIVE and verified audits in Ranger
Thanks,
Ramesh Mani
Re: Review Request 73845: RANGER-3614:Make audit log for INSERT, UPDATE, DELETE, TRUNCATE statement of hive table recognizable
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73845/#review224045
-----------------------------------------------------------
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuditHandler.java
Lines 165 (patched)
<https://reviews.apache.org/r/73845/#comment313026>
Instead of toUpperCase(), consider using StringUtils.startsWithIgnoreCase() - as below:
```
if (StringUtils.startsWithIgnoreCase(commandStr, ACCESS_TYPE_INSERT)) {
accessType = ACCESS_TYPE_INSERT;
} else (StringUtils.startsWithIgnoreCase(commandStr, ACCESS_TYPE_UPDATE)) {
accessType = ACCESS_TYPE_UPDATE;
} else ..
```
- Madhan Neethiraj
On Feb. 14, 2022, 7:43 p.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73845/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2022, 7:43 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3614
> https://issues.apache.org/jira/browse/RANGER-3614
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-3614:Make audit log for INSERT, UPDATE, DELETE, TRUNCATE statement of hive table recognizable
>
>
> Diffs
> -----
>
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuditHandler.java c0aac28aa
>
>
> Diff: https://reviews.apache.org/r/73845/diff/1/
>
>
> Testing
> -------
>
> - Testing done in Local VM with various DML operation for HIVE and verified audits in Ranger
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 73845: RANGER-3614:Make audit log for INSERT, UPDATE, DELETE, TRUNCATE statement of hive table recognizable
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73845/#review224046
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Feb. 14, 2022, 10:55 p.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73845/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2022, 10:55 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3614
> https://issues.apache.org/jira/browse/RANGER-3614
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-3614:Make audit log for INSERT, UPDATE, DELETE, TRUNCATE statement of hive table recognizable
>
>
> Diffs
> -----
>
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuditHandler.java c0aac28aa
>
>
> Diff: https://reviews.apache.org/r/73845/diff/2/
>
>
> Testing
> -------
>
> - Testing done in Local VM with various DML operation for HIVE and verified audits in Ranger
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 73845: RANGER-3614:Make audit log for INSERT, UPDATE, DELETE, TRUNCATE statement of hive table recognizable
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73845/
-----------------------------------------------------------
(Updated Feb. 14, 2022, 10:55 p.m.)
Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Changes
-------
Fixed review comments
Bugs: RANGER-3614
https://issues.apache.org/jira/browse/RANGER-3614
Repository: ranger
Description
-------
RANGER-3614:Make audit log for INSERT, UPDATE, DELETE, TRUNCATE statement of hive table recognizable
Diffs (updated)
-----
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuditHandler.java c0aac28aa
Diff: https://reviews.apache.org/r/73845/diff/2/
Changes: https://reviews.apache.org/r/73845/diff/1-2/
Testing
-------
- Testing done in Local VM with various DML operation for HIVE and verified audits in Ranger
Thanks,
Ramesh Mani