You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by gi...@git.apache.org on 2017/08/04 16:48:41 UTC

[GitHub] dmigo commented on issue #3242: Make sql editor resizable

dmigo commented on issue #3242: Make sql editor resizable
URL: https://github.com/apache/incubator-superset/pull/3242#issuecomment-320293575
 
 
   @mistercrunch not quite sure what you mean, I encountered 2 problems with resizing while working on this PR.  
   **First**: it wasn't possible to resize `react-ace` properly it had some issues. This one is solved by updating to the version `5.1.2`.  
   **Second**: Sql Lab has one hack in it. This hack adjusts sizes of some parts of the page. I didn't fix it, since it is out of scope of the PR, however I have a couple of ideas about it.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services