[GitHub] [incubator-mxnet] josephevans commented on a change in pull request #19851: [v1.x] ONNX export rewrite Take

[GitBox <gi...@apache.org>]

josephevans commented on a change in pull request #19851:
URL: https://github.com/apache/incubator-mxnet/pull/19851#discussion_r571333899



##########
File path: tests/python-pytest/onnx/test_operators.py
##########
@@ -927,3 +927,15 @@ def test_onnx_export_convolution(tmp_path, dtype, shape, num_filter, num_group,
                   **kwargs)
     inputs = [x, w] if no_bias else [x, w, b]
     op_export_test('convolution', M, inputs, tmp_path)
+
+
+@pytest.mark.parametrize('dtype', ['int32', 'int64', 'float16', 'float32', 'float64'])
+@pytest.mark.parametrize('axis', [-3, -2, -1, 0, 1, 2])
+@pytest.mark.parametrize('mode', ['clip', 'wrap'])

Review comment:
       We can split it into multiple tests, one test just for 'raise' mode and the other tests the 'clip' and 'wrap' modes, since the parametrized options will be different. 
   
   Sorta like this:
   https://github.com/apache/incubator-mxnet/pull/19855/files#diff-30a9f0d694eb3951b810ec760f714b3873ab4453e685620b1571991e644aae3cR859-R881




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org