You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by "Aditya A Auradkar (JIRA)" <ji...@apache.org> on 2015/01/23 19:17:36 UTC

[jira] [Commented] (KAFKA-1862) Pass in the Time object into OffsetManager

    [ https://issues.apache.org/jira/browse/KAFKA-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289649#comment-14289649 ] 

Aditya A Auradkar commented on KAFKA-1862:
------------------------------------------

I can pick this up [~guozhang]. Can you assign it to me?

> Pass in the Time object into OffsetManager
> ------------------------------------------
>
>                 Key: KAFKA-1862
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1862
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Guozhang Wang
>              Labels: newbie++
>             Fix For: 0.9.0
>
>
> We should improve OffsetManager to take in a Time instance as we do for LogManager and ReplicaManager. That way we can advance time with MockTime in test cases. 
> Then we can move the testOffsetExpiration case from OffsetCommitTest to OffsetManagerTest.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)