You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Anton Lindström <an...@alley.se> on 2014/08/04 21:00:46 UTC
Review Request 24246: Use memory.memsw.limit_in_bytes in cgroup mem isolator
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24246/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-1662
https://issues.apache.org/jira/browse/MESOS-1662
Repository: mesos-git
Description
-------
Changed memory.limit_in_bytes to memory.memsw.limit_in_bytes where memory is limited. This makes Mesos limit both memory and swap as described in the Jira ticket.
Diffs
-----
src/linux/cgroups.hpp c571e915fec461485d2015f58e6e828b00ea089a
src/linux/cgroups.cpp ccb86cf172c3c97513b16b90756d7bc12aad278f
src/slave/containerizer/isolators/cgroups/mem.cpp e8d1e35a1acdb3beb03a91cfd734a59417657b20
Diff: https://reviews.apache.org/r/24246/diff/
Testing
-------
make check
Thanks,
Anton Lindström
Re: Review Request 24246: Use memory.memsw.limit_in_bytes in cgroup mem
isolator
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24246/#review49587
-----------------------------------------------------------
Patch looks great!
Reviews applied: [24246]
All tests passed.
- Mesos ReviewBot
On Aug. 4, 2014, 7 p.m., Anton Lindström wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24246/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 7 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1662
> https://issues.apache.org/jira/browse/MESOS-1662
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Changed memory.limit_in_bytes to memory.memsw.limit_in_bytes where memory is limited. This makes Mesos limit both memory and swap as described in the Jira ticket.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp c571e915fec461485d2015f58e6e828b00ea089a
> src/linux/cgroups.cpp ccb86cf172c3c97513b16b90756d7bc12aad278f
> src/slave/containerizer/isolators/cgroups/mem.cpp e8d1e35a1acdb3beb03a91cfd734a59417657b20
>
> Diff: https://reviews.apache.org/r/24246/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anton Lindström
>
>
Re: Review Request 24246: Use memory.memsw.limit_in_bytes in cgroup mem
isolator
Posted by Anton Lindström <an...@alley.se>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24246/
-----------------------------------------------------------
(Updated Aug. 5, 2014, 3:59 p.m.)
Review request for mesos.
Changes
-------
Updated with the comments from the Jira ticket.
Bugs: MESOS-1662
https://issues.apache.org/jira/browse/MESOS-1662
Repository: mesos-git
Description
-------
Changed memory.limit_in_bytes to memory.memsw.limit_in_bytes where memory is limited. This makes Mesos limit both memory and swap as described in the Jira ticket.
Diffs (updated)
-----
src/linux/cgroups.hpp c571e915fec461485d2015f58e6e828b00ea089a
src/linux/cgroups.cpp ccb86cf172c3c97513b16b90756d7bc12aad278f
src/slave/containerizer/isolators/cgroups/mem.cpp e8d1e35a1acdb3beb03a91cfd734a59417657b20
Diff: https://reviews.apache.org/r/24246/diff/
Testing
-------
make check
Thanks,
Anton Lindström