You are viewing a plain text version of this content. The canonical link for it is here.

Posted to java-user@lucene.apache.org by Ravikumar Govindarajan <ra...@gmail.com> on 2014/03/13 13:21:39 UTC

StoredFieldsWriter finishDocument() method should be abstract?

I was just trying to implement a StoredFieldsWriter[4.6.1] and found that
finishDocument() method has an empty impl. Any reason for not declaring it
abstract? We could easily miss over-riding it

--
Ravi

Re: StoredFieldsWriter finishDocument() method should be abstract?

Posted by Michael McCandless <lu...@mikemccandless.com>.

+1

Can you open an issue / put a patch?  Thanks.

Mike McCandless

http://blog.mikemccandless.com


On Thu, Mar 13, 2014 at 8:21 AM, Ravikumar Govindarajan
<ra...@gmail.com> wrote:
> I was just trying to implement a StoredFieldsWriter[4.6.1] and found that
> finishDocument() method has an empty impl. Any reason for not declaring it
> abstract? We could easily miss over-riding it
>
> --
> Ravi

---------------------------------------------------------------------
To unsubscribe, e-mail: java-user-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-user-help@lucene.apache.org