You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@guacamole.apache.org by vn...@apache.org on 2018/09/26 12:44:27 UTC

[06/19] guacamole-server git commit: GUACAMOLE-623: Do not return -1 from libwebsockets callback. Doing so results in automatic cleanup of part of the context, resulting in a segfault when lws_context_destroy() is invoked.

GUACAMOLE-623: Do not return -1 from libwebsockets callback. Doing so results in automatic cleanup of part of the context, resulting in a segfault when lws_context_destroy() is invoked.


Project: http://git-wip-us.apache.org/repos/asf/guacamole-server/repo
Commit: http://git-wip-us.apache.org/repos/asf/guacamole-server/commit/cbe59350
Tree: http://git-wip-us.apache.org/repos/asf/guacamole-server/tree/cbe59350
Diff: http://git-wip-us.apache.org/repos/asf/guacamole-server/diff/cbe59350

Branch: refs/heads/master
Commit: cbe593503f4cf819af32abc0b661662aa3fadc9e
Parents: f72877b
Author: Michael Jumper <mj...@apache.org>
Authored: Mon Sep 10 00:25:49 2018 -0700
Committer: Michael Jumper <mj...@apache.org>
Committed: Tue Sep 25 21:30:51 2018 -0700

----------------------------------------------------------------------
 src/protocols/kubernetes/kubernetes.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/guacamole-server/blob/cbe59350/src/protocols/kubernetes/kubernetes.c
----------------------------------------------------------------------
diff --git a/src/protocols/kubernetes/kubernetes.c b/src/protocols/kubernetes/kubernetes.c
index ae2a894..e38d5e3 100644
--- a/src/protocols/kubernetes/kubernetes.c
+++ b/src/protocols/kubernetes/kubernetes.c
@@ -109,7 +109,7 @@ static int guac_kubernetes_lws_callback(struct lws* wsi,
      * pointer passed by libwebsockets may be NULL for some events) */
     guac_client* client = (guac_client*) user;
     if (client != NULL && client->state != GUAC_CLIENT_RUNNING)
-        return -1;
+        return lws_callback_http_dummy(wsi, reason, user, in, length);
 
     switch (reason) {