You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Igor Vaynberg (JIRA)" <ji...@apache.org> on 2009/09/23 16:22:16 UTC

[jira] Updated: (WICKET-2486) DynamicWizardStep has isNextAvailable etc, but lacks isFinishAvailable

     [ https://issues.apache.org/jira/browse/WICKET-2486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg updated WICKET-2486:
----------------------------------

      Priority: Minor  (was: Major)
    Issue Type: Improvement  (was: Bug)

> DynamicWizardStep has isNextAvailable etc, but lacks isFinishAvailable
> ----------------------------------------------------------------------
>
>                 Key: WICKET-2486
>                 URL: https://issues.apache.org/jira/browse/WICKET-2486
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-extensions
>    Affects Versions: 1.4-RC2
>            Reporter: Maarten Billemont
>            Priority: Minor
>
> My final step only completes when an outside process finishes.  An AJAX timer behavior checks this process every so often and manually invokes finish() on the wizardModel.  Problem is that while it is possible to disable most wizard buttons, for some reason, the finish button cannot be. To make matters worse, I can't even override FinishButton and change its isEnabled myself because the API thought it was a good idea to make isEnabled final on that level.
> I recommend two things:
> - Get rid of the pointless use of final, it only cripples the API.  It's not like it's such a dangerous thing in this case to allow overriding isEnabled of FinishButton.
> - Add isFinishAvailable to DynamicWizardStep to bring it in line with the other buttons.  There's no particular reason for this method to not exist.  Also the cancel button should probably be disablable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.