[jira] [Work logged] (BEAM-11085) [Go SDK] Windows are correctly observed in DoFns.

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-11085?focusedWorklogId=736378&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-736378 ]

ASF GitHub Bot logged work on BEAM-11085:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Mar/22 21:59
            Start Date: 03/Mar/22 21:59
    Worklog Time Spent: 10m 
      Work Description: damccorm opened a new pull request #17007:
URL: https://github.com/apache/beam/pull/17007


   Part of our streaming roadmap is validating window correctness - https://cwiki.apache.org/confluence/display/BEAM/Supporting+Streaming+in+the+Go+SDK
   
   This knocks out the last item from that list by introducing some simple tests that we can access windows correctly in DoFns.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 736378)
    Remaining Estimate: 0h
            Time Spent: 10m

> [Go SDK] Windows are correctly observed in DoFns.
> -------------------------------------------------
>
>                 Key: BEAM-11085
>                 URL: https://issues.apache.org/jira/browse/BEAM-11085
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-go
>            Reporter: Robert Burke
>            Priority: P3
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Add a simple unit test to validate that user DoFns can observe windows. 
> In particular add a Go unit test to the exec package, in the style of the ParDo execution  unit test [https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/core/runtime/exec/pardo_test.go#L50] 
> This requires writing a small but observable DoFn that observes windows, and configures inputs to achieve expected outputs for given window assignements. There may be a need to add a utility functions to configure the windows and event times in a FullValue conveniently for the test.
> Tests should cover single and multiple windows cases.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)