[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich commented on a diff in pull request #32: Resolve ojdbc6.jar as a dependency

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #32:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/32#discussion_r1165255985


##########
project/Dependencies.scala:
##########
@@ -24,7 +24,8 @@ object Dependencies {
     "org.postgresql" % "postgresql" % "42.3.3",
     "com.h2database" % "h2" % "2.1.212",
     "mysql" % "mysql-connector-java" % "8.0.28",
-    "com.microsoft.sqlserver" % "mssql-jdbc" % "7.4.1.jre8")
+    "com.microsoft.sqlserver" % "mssql-jdbc" % "7.4.1.jre8",
+    "com.oracle.database.jdbc" % "ojdbc6" % "11.2.0.4")

Review Comment:
   Note that like the other JDBC drivers listed here, this will get resolved in `Test`/`Provided` scope



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org