You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by bj...@apache.org on 2002/04/01 18:42:02 UTC
cvs commit: httpd-2.0/server/mpm/mpmt_os2 mpmt_os2_child.c
bjh 02/04/01 08:42:02
Modified: server/mpm/mpmt_os2 mpmt_os2_child.c
Log:
Destroy the connection pool (and therefore run the cleanups) before destroying
the bucket_alloc as the cleanups refer to buckets allocated by the
bucket_alloc.
Revision Changes Path
1.19 +1 -1 httpd-2.0/server/mpm/mpmt_os2/mpmt_os2_child.c
Index: mpmt_os2_child.c
===================================================================
RCS file: /home/cvs/httpd-2.0/server/mpm/mpmt_os2/mpmt_os2_child.c,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- mpmt_os2_child.c 29 Mar 2002 08:17:25 -0000 1.18
+++ mpmt_os2_child.c 1 Apr 2002 16:42:02 -0000 1.19
@@ -442,8 +442,8 @@
ap_lingering_close(current_conn);
}
- apr_bucket_alloc_destroy(bucket_alloc);
apr_pool_destroy(pconn);
+ apr_bucket_alloc_destroy(bucket_alloc);
ap_update_child_status_from_indexes(child_slot, thread_slot,
SERVER_READY, NULL);
}
Re: cvs commit: httpd-2.0/server/mpm/mpmt_os2 mpmt_os2_child.c
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
At 10:51 AM 4/1/2002, you wrote:
>This is a severe crash-bug fix, can the 2.0.34 tag be bumped for it?
>
> >bjh 02/04/01 08:42:02
> >
> > Modified: server/mpm/mpmt_os2 mpmt_os2_child.c
> > Log:
> > Destroy the connection pool (and therefore run the cleanups) before
> destroying
> > the bucket_alloc as the cleanups refer to buckets allocated by the
> > bucket_alloc.
> >
> > Revision Changes Path
> > 1.19 +1 -1 httpd-2.0/server/mpm/mpmt_os2/mpmt_os2_child.c
Moved tag APACHE_2_0_34 for this version. Nice catch!
Bill
Re: cvs commit: httpd-2.0/server/mpm/mpmt_os2 mpmt_os2_child.c
Posted by Cliff Woolley <jw...@virginia.edu>.
On Tue, 2 Apr 2002, Brian Havard wrote:
> This is a severe crash-bug fix, can the 2.0.34 tag be bumped for it?
OOPS!! Sorry about that. Thanks for the fix! :) ++1 to bumping 2.0.34
for this change, by all means...
--Cliff
--------------------------------------------------------------
Cliff Woolley
cliffwoolley@yahoo.com
Charlottesville, VA
Re: cvs commit: httpd-2.0/server/mpm/mpmt_os2 mpmt_os2_child.c
Posted by Brian Havard <br...@kheldar.apana.org.au>.
This is a severe crash-bug fix, can the 2.0.34 tag be bumped for it?
On 1 Apr 2002 16:42:02 -0000, bjh@apache.org wrote:
>bjh 02/04/01 08:42:02
>
> Modified: server/mpm/mpmt_os2 mpmt_os2_child.c
> Log:
> Destroy the connection pool (and therefore run the cleanups) before destroying
> the bucket_alloc as the cleanups refer to buckets allocated by the
> bucket_alloc.
>
> Revision Changes Path
> 1.19 +1 -1 httpd-2.0/server/mpm/mpmt_os2/mpmt_os2_child.c
>
> Index: mpmt_os2_child.c
> ===================================================================
> RCS file: /home/cvs/httpd-2.0/server/mpm/mpmt_os2/mpmt_os2_child.c,v
> retrieving revision 1.18
> retrieving revision 1.19
> diff -u -r1.18 -r1.19
> --- mpmt_os2_child.c 29 Mar 2002 08:17:25 -0000 1.18
> +++ mpmt_os2_child.c 1 Apr 2002 16:42:02 -0000 1.19
> @@ -442,8 +442,8 @@
> ap_lingering_close(current_conn);
> }
>
> - apr_bucket_alloc_destroy(bucket_alloc);
> apr_pool_destroy(pconn);
> + apr_bucket_alloc_destroy(bucket_alloc);
> ap_update_child_status_from_indexes(child_slot, thread_slot,
> SERVER_READY, NULL);
> }
>
>
>
>
--
______________________________________________________________________________
| Brian Havard | "He is not the messiah! |
| brianh@kheldar.apana.org.au | He's a very naughty boy!" - Life of Brian |
------------------------------------------------------------------------------