You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Svet <no...@github.com> on 2017/07/20 07:16:18 UTC

[jclouds/jclouds] Make sure Jetty doesn't terminate on ssh disconnect (#1122)

Fixes `BaseComputeServiceAdapterLiveTest.testCreateAndRunAService` for CentOS 7. `disown` in `jetty.sh` is not enough to detach the process from the current session so it's terminated when jclouds closes the connection.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1122

-- Commit Summary --

  * Makes sure Jetty doesn't terminate on ssh disconnect

-- File Changes --

    M compute/src/test/java/org/jclouds/compute/JettyStatements.java (2)
    M compute/src/test/java/org/jclouds/compute/StubComputeServiceIntegrationTest.java (2)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1122.patch
https://github.com/jclouds/jclouds/pull/1122.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1122

Re: [jclouds/jclouds] Make sure Jetty doesn't terminate on ssh disconnect (#1122)

Posted by Svet <no...@github.com>.

Closed #1122.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1122#event-1172143924

Re: [jclouds/jclouds] Make sure Jetty doesn't terminate on ssh disconnect (#1122)

Posted by Svet <no...@github.com>.

Took some time to get to the bottom of it :).
Merged to [master](https://git1-us-west.apache.org/repos/asf/jclouds/?p=jclouds.git;a=commit;h=0c054c18359fc2bd0f1de2344b6e021a38aed695) and [2.0.x](https://git1-us-west.apache.org/repos/asf/jclouds/?p=jclouds.git;a=commit;h=5b57b73cf744cd316c028edd2e5d765324ec6d6f)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1122#issuecomment-316709900

Re: [jclouds/jclouds] Make sure Jetty doesn't terminate on ssh disconnect (#1122)

Posted by Ignasi Barrera <no...@github.com>.

nacx approved this pull request.

Looks like this had to be kind of a pain to debug :) Thanks @neykov!



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1122#pullrequestreview-51152916