Re: [PR] ARTEMIS-4540 validate MQTT session state data [activemq-artemis]

["gemmellr (via GitHub)" <gi...@apache.org>]

gemmellr commented on code in PR #4725:
URL: https://github.com/apache/activemq-artemis/pull/4725#discussion_r1458916273


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/server/impl/RemotingServiceImpl.java:
##########
@@ -285,7 +285,7 @@ public Acceptor createAcceptor(TransportConfiguration info) {
             managementService.registerAcceptor(acceptor, info);
          }
       } catch (Exception e) {
-         ActiveMQServerLogger.LOGGER.errorCreatingAcceptor(info.getFactoryClassName(), e);
+         ActiveMQServerLogger.LOGGER.errorCreatingAcceptor(info.toString(), e);

Review Comment:
   This seems like it could/should be a separate change.
   
   I'm also not sure logging all the info is that necessary, given the length it could be and that it often contains credentials (though there does look to be masking involved here). The underlying cause is being being logged anyway.
   
   The acceptors are required to have names, what about just using that rather than the factory class name?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org