You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Florian Barca <fb...@hortonworks.com> on 2015/04/21 22:05:07 UTC
Review Request 33405: [WinTP2] SQLServer transaction deadlock causes
deployment on Windows to be busted
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33405/
-----------------------------------------------------------
Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Ivan Kozlov, Jonathan Hurley, Jayush Luniya, and Sid Wagle.
Bugs: AMBARI-10637
https://issues.apache.org/jira/browse/AMBARI-10637
Repository: ambari
Description
-------
Split the Eclipselink sequence connection pool away from the main one.
Diffs
-----
ambari-server/src/main/resources/META-INF/persistence.xml b864c591796967f7471e65ebbc995f8aabd2bed5
Diff: https://reviews.apache.org/r/33405/diff/
Testing
-------
mvn clean install
deployed in a local VM cluster -> no repro
Thanks,
Florian Barca
Re: Review Request 33405: [WinTP2] SQLServer transaction deadlock
causes deployment on Windows to be busted
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33405/#review81053
-----------------------------------------------------------
ambari-server/src/main/resources/META-INF/persistence.xml
<https://reviews.apache.org/r/33405/#comment131273>
I believe this has no meaning according to Persistence unit docs.
- Sid Wagle
On April 21, 2015, 8:05 p.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33405/
> -----------------------------------------------------------
>
> (Updated April 21, 2015, 8:05 p.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Ivan Kozlov, Jonathan Hurley, Jayush Luniya, and Sid Wagle.
>
>
> Bugs: AMBARI-10637
> https://issues.apache.org/jira/browse/AMBARI-10637
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Split the Eclipselink sequence connection pool away from the main one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/META-INF/persistence.xml b864c591796967f7471e65ebbc995f8aabd2bed5
>
> Diff: https://reviews.apache.org/r/33405/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
> deployed in a local VM cluster -> no repro
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 33405: [WinTP2] SQLServer transaction deadlock
causes deployment on Windows to be busted
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33405/#review81200
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On April 22, 2015, 6:29 p.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33405/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 6:29 p.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Ivan Kozlov, Jonathan Hurley, Jayush Luniya, and Sid Wagle.
>
>
> Bugs: AMBARI-10637
> https://issues.apache.org/jira/browse/AMBARI-10637
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Split the Eclipselink sequence connection pool away from the main one.
>
>
> Diffs
> -----
>
> ambari-server/conf/windows/ambari.properties 58c8d9feb5ae48a58e26c605c78897ee04819dc4
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java cd2bafd4188ff14bd22952021d32d0e5abc4e4c5
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java a57a1507a13aa9dc500e06d8e1b23459e0342f79
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 184c8dbaf944517f0ba6643fe1a2d16d244c24db
> ambari-server/src/main/resources/META-INF/persistence.xml b864c591796967f7471e65ebbc995f8aabd2bed5
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 63447cad745ea04901671ec66c10716ef5c3fe5c
>
> Diff: https://reviews.apache.org/r/33405/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
> deployed in a local VM cluster -> no repro
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 33405: [WinTP2] SQLServer transaction deadlock
causes deployment on Windows to be busted
Posted by Florian Barca <fb...@hortonworks.com>.
> On April 23, 2015, 2:56 p.m., Jonathan Hurley wrote:
> > Why are separate tables only need for alerts and widgets. These business objects should not be creating many records apart from the initial seeding on cluster deploy. It seems like we're working around a problem here instead of fixing it.
It's not about the number of records, it's about the contention on those records, which in SQL Server's case translates into contention on the whole table. The Alerts are quite intensive, the sequence id goes up rapidly over 100 after only 1 deployment.
- Florian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33405/#review81314
-----------------------------------------------------------
On April 23, 2015, 5:05 a.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33405/
> -----------------------------------------------------------
>
> (Updated April 23, 2015, 5:05 a.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Ivan Kozlov, Jonathan Hurley, Jayush Luniya, and Sid Wagle.
>
>
> Bugs: AMBARI-10637
> https://issues.apache.org/jira/browse/AMBARI-10637
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Split the Eclipselink sequence connection pool away from the main one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java bbeca38410aff6d452204319e42fbbd141ed7116
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 184c8dbaf944517f0ba6643fe1a2d16d244c24db
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java 66aa1194df5565e123146d312095dcbe79e84a57
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java 6838983f16505f92a8dcae42bdc0ba0dde082544
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java 9efb1660603d47f7a3c992f0e3ad76aa35e8ade5
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity.java 8e96aca4fcd13cf7230f890922c72d6817f759e2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java ae43dfe5f61ecfe9ffcbd1b6bcc1b12b642c6906
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java 29f79d71bb3bce38d3b2da9c033aa4346a590c49
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetEntity.java 82d9a158a6b3fbbc0fa7f7de063af4a44d2526fe
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutEntity.java 6ba14e4ba4fa45814755c8702b56b843d07dea52
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b6f2aaab9aee3879a140f4e24ae064ddccae9391
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 25685e50feba0b6c19d8ed0944d2a8dc31d017ae
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 9ade56fa047cd6b0060627e5368a8daab048a54e
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql feaeae9aedf8c454979369ed4a05ea3ebff121af
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 03f1ec88fbc03da43dade8bb3605c28d6952d582
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql 8cb3132a4306f099419823d9a1ed718c5a42f5a5
> ambari-server/src/main/resources/META-INF/persistence.xml b864c591796967f7471e65ebbc995f8aabd2bed5
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 63447cad745ea04901671ec66c10716ef5c3fe5c
>
> Diff: https://reviews.apache.org/r/33405/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
> deployed in a local VM cluster -> no repro
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 33405: [WinTP2] SQLServer transaction deadlock
causes deployment on Windows to be busted
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On April 23, 2015, 10:56 a.m., Jonathan Hurley wrote:
> > Why are separate tables only need for alerts and widgets. These business objects should not be creating many records apart from the initial seeding on cluster deploy. It seems like we're working around a problem here instead of fixing it.
>
> Florian Barca wrote:
> It's not about the number of records, it's about the contention on those records, which in SQL Server's case translates into contention on the whole table. The Alerts are quite intensive, the sequence id goes up rapidly over 100 after only 1 deployment.
I disagree that 100 rows is "intensive" ... we're talking enterprise level databases here. If 100 rows causes this many problems, and the only way to solve it separate sequence tables, then we need to solve the problem for all of Ambari - creating new tables for every sequence row.
That's why I'm not sure this is the right way to go.
Additionally, this patch does not address upgrade scenarios and starting from IDs that won't conflict existing alerts in the system. If this is the going to be the way to go (which I'm still not convinced), then we'd need proper upgrade code as well.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33405/#review81314
-----------------------------------------------------------
On April 23, 2015, 1:05 a.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33405/
> -----------------------------------------------------------
>
> (Updated April 23, 2015, 1:05 a.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Ivan Kozlov, Jonathan Hurley, Jayush Luniya, and Sid Wagle.
>
>
> Bugs: AMBARI-10637
> https://issues.apache.org/jira/browse/AMBARI-10637
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Split the Eclipselink sequence connection pool away from the main one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java bbeca38410aff6d452204319e42fbbd141ed7116
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 184c8dbaf944517f0ba6643fe1a2d16d244c24db
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java 66aa1194df5565e123146d312095dcbe79e84a57
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java 6838983f16505f92a8dcae42bdc0ba0dde082544
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java 9efb1660603d47f7a3c992f0e3ad76aa35e8ade5
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity.java 8e96aca4fcd13cf7230f890922c72d6817f759e2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java ae43dfe5f61ecfe9ffcbd1b6bcc1b12b642c6906
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java 29f79d71bb3bce38d3b2da9c033aa4346a590c49
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetEntity.java 82d9a158a6b3fbbc0fa7f7de063af4a44d2526fe
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutEntity.java 6ba14e4ba4fa45814755c8702b56b843d07dea52
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b6f2aaab9aee3879a140f4e24ae064ddccae9391
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 25685e50feba0b6c19d8ed0944d2a8dc31d017ae
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 9ade56fa047cd6b0060627e5368a8daab048a54e
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql feaeae9aedf8c454979369ed4a05ea3ebff121af
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 03f1ec88fbc03da43dade8bb3605c28d6952d582
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql 8cb3132a4306f099419823d9a1ed718c5a42f5a5
> ambari-server/src/main/resources/META-INF/persistence.xml b864c591796967f7471e65ebbc995f8aabd2bed5
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 63447cad745ea04901671ec66c10716ef5c3fe5c
>
> Diff: https://reviews.apache.org/r/33405/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
> deployed in a local VM cluster -> no repro
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 33405: [WinTP2] SQLServer transaction deadlock
causes deployment on Windows to be busted
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33405/#review81314
-----------------------------------------------------------
Why are separate tables only need for alerts and widgets. These business objects should not be creating many records apart from the initial seeding on cluster deploy. It seems like we're working around a problem here instead of fixing it.
- Jonathan Hurley
On April 23, 2015, 1:05 a.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33405/
> -----------------------------------------------------------
>
> (Updated April 23, 2015, 1:05 a.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Ivan Kozlov, Jonathan Hurley, Jayush Luniya, and Sid Wagle.
>
>
> Bugs: AMBARI-10637
> https://issues.apache.org/jira/browse/AMBARI-10637
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Split the Eclipselink sequence connection pool away from the main one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java bbeca38410aff6d452204319e42fbbd141ed7116
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 184c8dbaf944517f0ba6643fe1a2d16d244c24db
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java 66aa1194df5565e123146d312095dcbe79e84a57
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java 6838983f16505f92a8dcae42bdc0ba0dde082544
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java 9efb1660603d47f7a3c992f0e3ad76aa35e8ade5
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity.java 8e96aca4fcd13cf7230f890922c72d6817f759e2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java ae43dfe5f61ecfe9ffcbd1b6bcc1b12b642c6906
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java 29f79d71bb3bce38d3b2da9c033aa4346a590c49
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetEntity.java 82d9a158a6b3fbbc0fa7f7de063af4a44d2526fe
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutEntity.java 6ba14e4ba4fa45814755c8702b56b843d07dea52
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b6f2aaab9aee3879a140f4e24ae064ddccae9391
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 25685e50feba0b6c19d8ed0944d2a8dc31d017ae
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 9ade56fa047cd6b0060627e5368a8daab048a54e
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql feaeae9aedf8c454979369ed4a05ea3ebff121af
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 03f1ec88fbc03da43dade8bb3605c28d6952d582
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql 8cb3132a4306f099419823d9a1ed718c5a42f5a5
> ambari-server/src/main/resources/META-INF/persistence.xml b864c591796967f7471e65ebbc995f8aabd2bed5
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 63447cad745ea04901671ec66c10716ef5c3fe5c
>
> Diff: https://reviews.apache.org/r/33405/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
> deployed in a local VM cluster -> no repro
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 33405: [WinTP2] SQLServer transaction deadlock
causes deployment on Windows to be busted
Posted by Artem Baranchuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33405/#review81350
-----------------------------------------------------------
Ship it!
Ship It!
- Artem Baranchuk
On Апрель 23, 2015, 5:05 д.п., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33405/
> -----------------------------------------------------------
>
> (Updated Апрель 23, 2015, 5:05 д.п.)
>
>
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Ivan Kozlov, Jonathan Hurley, Jayush Luniya, and Sid Wagle.
>
>
> Bugs: AMBARI-10637
> https://issues.apache.org/jira/browse/AMBARI-10637
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Split the Eclipselink sequence connection pool away from the main one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java bbeca38410aff6d452204319e42fbbd141ed7116
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 184c8dbaf944517f0ba6643fe1a2d16d244c24db
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java 66aa1194df5565e123146d312095dcbe79e84a57
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java 6838983f16505f92a8dcae42bdc0ba0dde082544
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java 9efb1660603d47f7a3c992f0e3ad76aa35e8ade5
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity.java 8e96aca4fcd13cf7230f890922c72d6817f759e2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java ae43dfe5f61ecfe9ffcbd1b6bcc1b12b642c6906
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java 29f79d71bb3bce38d3b2da9c033aa4346a590c49
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetEntity.java 82d9a158a6b3fbbc0fa7f7de063af4a44d2526fe
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutEntity.java 6ba14e4ba4fa45814755c8702b56b843d07dea52
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b6f2aaab9aee3879a140f4e24ae064ddccae9391
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 25685e50feba0b6c19d8ed0944d2a8dc31d017ae
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 9ade56fa047cd6b0060627e5368a8daab048a54e
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql feaeae9aedf8c454979369ed4a05ea3ebff121af
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 03f1ec88fbc03da43dade8bb3605c28d6952d582
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql 8cb3132a4306f099419823d9a1ed718c5a42f5a5
> ambari-server/src/main/resources/META-INF/persistence.xml b864c591796967f7471e65ebbc995f8aabd2bed5
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 63447cad745ea04901671ec66c10716ef5c3fe5c
>
> Diff: https://reviews.apache.org/r/33405/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
> deployed in a local VM cluster -> no repro
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 33405: [WinTP2] SQLServer transaction deadlock
causes deployment on Windows to be busted
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33405/#review81446
-----------------------------------------------------------
@Florian, can discard this review. I submitted a patch for review.
- Jayush Luniya
On April 23, 2015, 5:05 a.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33405/
> -----------------------------------------------------------
>
> (Updated April 23, 2015, 5:05 a.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Ivan Kozlov, Jonathan Hurley, Jayush Luniya, and Sid Wagle.
>
>
> Bugs: AMBARI-10637
> https://issues.apache.org/jira/browse/AMBARI-10637
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Split the Eclipselink sequence connection pool away from the main one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java bbeca38410aff6d452204319e42fbbd141ed7116
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 184c8dbaf944517f0ba6643fe1a2d16d244c24db
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java 66aa1194df5565e123146d312095dcbe79e84a57
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java 6838983f16505f92a8dcae42bdc0ba0dde082544
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java 9efb1660603d47f7a3c992f0e3ad76aa35e8ade5
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity.java 8e96aca4fcd13cf7230f890922c72d6817f759e2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java ae43dfe5f61ecfe9ffcbd1b6bcc1b12b642c6906
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java 29f79d71bb3bce38d3b2da9c033aa4346a590c49
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetEntity.java 82d9a158a6b3fbbc0fa7f7de063af4a44d2526fe
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutEntity.java 6ba14e4ba4fa45814755c8702b56b843d07dea52
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b6f2aaab9aee3879a140f4e24ae064ddccae9391
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 25685e50feba0b6c19d8ed0944d2a8dc31d017ae
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 9ade56fa047cd6b0060627e5368a8daab048a54e
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql feaeae9aedf8c454979369ed4a05ea3ebff121af
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 03f1ec88fbc03da43dade8bb3605c28d6952d582
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql 8cb3132a4306f099419823d9a1ed718c5a42f5a5
> ambari-server/src/main/resources/META-INF/persistence.xml b864c591796967f7471e65ebbc995f8aabd2bed5
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 63447cad745ea04901671ec66c10716ef5c3fe5c
>
> Diff: https://reviews.apache.org/r/33405/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
> deployed in a local VM cluster -> no repro
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 33405: [WinTP2] SQLServer transaction deadlock
causes deployment on Windows to be busted
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33405/
-----------------------------------------------------------
(Updated April 23, 2015, 5:05 a.m.)
Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Ivan Kozlov, Jonathan Hurley, Jayush Luniya, and Sid Wagle.
Changes
-------
Splitting the contentious records away in separate tables.
Bugs: AMBARI-10637
https://issues.apache.org/jira/browse/AMBARI-10637
Repository: ambari
Description
-------
Split the Eclipselink sequence connection pool away from the main one.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java bbeca38410aff6d452204319e42fbbd141ed7116
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 184c8dbaf944517f0ba6643fe1a2d16d244c24db
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java 66aa1194df5565e123146d312095dcbe79e84a57
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java 6838983f16505f92a8dcae42bdc0ba0dde082544
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java 9efb1660603d47f7a3c992f0e3ad76aa35e8ade5
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity.java 8e96aca4fcd13cf7230f890922c72d6817f759e2
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java ae43dfe5f61ecfe9ffcbd1b6bcc1b12b642c6906
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java 29f79d71bb3bce38d3b2da9c033aa4346a590c49
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetEntity.java 82d9a158a6b3fbbc0fa7f7de063af4a44d2526fe
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutEntity.java 6ba14e4ba4fa45814755c8702b56b843d07dea52
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b6f2aaab9aee3879a140f4e24ae064ddccae9391
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 25685e50feba0b6c19d8ed0944d2a8dc31d017ae
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 9ade56fa047cd6b0060627e5368a8daab048a54e
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql feaeae9aedf8c454979369ed4a05ea3ebff121af
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 03f1ec88fbc03da43dade8bb3605c28d6952d582
ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql 8cb3132a4306f099419823d9a1ed718c5a42f5a5
ambari-server/src/main/resources/META-INF/persistence.xml b864c591796967f7471e65ebbc995f8aabd2bed5
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 63447cad745ea04901671ec66c10716ef5c3fe5c
Diff: https://reviews.apache.org/r/33405/diff/
Testing
-------
mvn clean install
deployed in a local VM cluster -> no repro
Thanks,
Florian Barca
Re: Review Request 33405: [WinTP2] SQLServer transaction deadlock
causes deployment on Windows to be busted
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33405/#review81201
-----------------------------------------------------------
ambari-server/conf/windows/ambari.properties
<https://reviews.apache.org/r/33405/#comment131451>
I don't think this looks right; you're restricting the main connection pool to 1 connection.
Also, we should just use sensible defaults in Configuration and now have weirdo values here unless they need to be tuned.
- Jonathan Hurley
On April 22, 2015, 2:29 p.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33405/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 2:29 p.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Ivan Kozlov, Jonathan Hurley, Jayush Luniya, and Sid Wagle.
>
>
> Bugs: AMBARI-10637
> https://issues.apache.org/jira/browse/AMBARI-10637
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Split the Eclipselink sequence connection pool away from the main one.
>
>
> Diffs
> -----
>
> ambari-server/conf/windows/ambari.properties 58c8d9feb5ae48a58e26c605c78897ee04819dc4
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java cd2bafd4188ff14bd22952021d32d0e5abc4e4c5
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java a57a1507a13aa9dc500e06d8e1b23459e0342f79
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 184c8dbaf944517f0ba6643fe1a2d16d244c24db
> ambari-server/src/main/resources/META-INF/persistence.xml b864c591796967f7471e65ebbc995f8aabd2bed5
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 63447cad745ea04901671ec66c10716ef5c3fe5c
>
> Diff: https://reviews.apache.org/r/33405/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
> deployed in a local VM cluster -> no repro
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 33405: [WinTP2] SQLServer transaction deadlock
causes deployment on Windows to be busted
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33405/
-----------------------------------------------------------
(Updated April 22, 2015, 6:29 p.m.)
Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Ivan Kozlov, Jonathan Hurley, Jayush Luniya, and Sid Wagle.
Changes
-------
Added the configuration parameters. Restricting the pools to 1 connection on Windows to unblock the tests.
Bugs: AMBARI-10637
https://issues.apache.org/jira/browse/AMBARI-10637
Repository: ambari
Description
-------
Split the Eclipselink sequence connection pool away from the main one.
Diffs (updated)
-----
ambari-server/conf/windows/ambari.properties 58c8d9feb5ae48a58e26c605c78897ee04819dc4
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java cd2bafd4188ff14bd22952021d32d0e5abc4e4c5
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java a57a1507a13aa9dc500e06d8e1b23459e0342f79
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 184c8dbaf944517f0ba6643fe1a2d16d244c24db
ambari-server/src/main/resources/META-INF/persistence.xml b864c591796967f7471e65ebbc995f8aabd2bed5
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 63447cad745ea04901671ec66c10716ef5c3fe5c
Diff: https://reviews.apache.org/r/33405/diff/
Testing
-------
mvn clean install
deployed in a local VM cluster -> no repro
Thanks,
Florian Barca
Re: Review Request 33405: [WinTP2] SQLServer transaction deadlock
causes deployment on Windows to be busted
Posted by Sid Wagle <sw...@hortonworks.com>.
> On April 21, 2015, 8:11 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/META-INF/persistence.xml, lines 91-94
> > <https://reviews.apache.org/r/33405/diff/1/?file=938438#file938438line91>
> >
> > Configuration has the following properties, which default to some good starting values.
> > ```
> > public static final String SERVER_JDBC_CONNECTION_POOL = "server.jdbc.connection-pool";
> > public static final String SERVER_JDBC_CONNECTION_POOL_MIN_SIZE = "server.jdbc.connection-pool.min-size";
> > public static final String SERVER_JDBC_CONNECTION_POOL_MAX_SIZE = "server.jdbc.connection-pool.max-size";
> > public static final String SERVER_JDBC_CONNECTION_POOL_AQUISITION_SIZE = "server.jdbc.connection-pool.acquisition-size";
> > public static final String SERVER_JDBC_CONNECTION_POOL_MAX_AGE = "server.jdbc.connection-pool.max-age";
> > public static final String SERVER_JDBC_CONNECTION_POOL_MAX_IDLE_TIME = "server.jdbc.connection-pool.max-idle-time";
> > public static final String SERVER_JDBC_CONNECTION_POOL_MAX_IDLE_TIME_EXCESS = "server.jdbc.connection-pool.max-idle-time-excess";
> > public static final String SERVER_JDBC_CONNECTION_POOL_IDLE_TEST_INTERVAL = "server.jdbc.connection-pool.idle-test-interval";
> > ```
> >
> > We should instead read these values from ambari.properties and set them on EclipseLink manually.
> >
> > Sequence values can probably remain coded as they are.
+1 for setting sequence pool though confgiuration but I do not see anybody chanigng these, do you? The db connection pool settings would definitely change, not sure about sequence pool. In any case ability to override is definitely better.
- Sid
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33405/#review81054
-----------------------------------------------------------
On April 21, 2015, 8:05 p.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33405/
> -----------------------------------------------------------
>
> (Updated April 21, 2015, 8:05 p.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Ivan Kozlov, Jonathan Hurley, Jayush Luniya, and Sid Wagle.
>
>
> Bugs: AMBARI-10637
> https://issues.apache.org/jira/browse/AMBARI-10637
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Split the Eclipselink sequence connection pool away from the main one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/META-INF/persistence.xml b864c591796967f7471e65ebbc995f8aabd2bed5
>
> Diff: https://reviews.apache.org/r/33405/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
> deployed in a local VM cluster -> no repro
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 33405: [WinTP2] SQLServer transaction deadlock
causes deployment on Windows to be busted
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33405/#review81054
-----------------------------------------------------------
ambari-server/src/main/resources/META-INF/persistence.xml
<https://reviews.apache.org/r/33405/#comment131274>
Configuration has the following properties, which default to some good starting values.
```
public static final String SERVER_JDBC_CONNECTION_POOL = "server.jdbc.connection-pool";
public static final String SERVER_JDBC_CONNECTION_POOL_MIN_SIZE = "server.jdbc.connection-pool.min-size";
public static final String SERVER_JDBC_CONNECTION_POOL_MAX_SIZE = "server.jdbc.connection-pool.max-size";
public static final String SERVER_JDBC_CONNECTION_POOL_AQUISITION_SIZE = "server.jdbc.connection-pool.acquisition-size";
public static final String SERVER_JDBC_CONNECTION_POOL_MAX_AGE = "server.jdbc.connection-pool.max-age";
public static final String SERVER_JDBC_CONNECTION_POOL_MAX_IDLE_TIME = "server.jdbc.connection-pool.max-idle-time";
public static final String SERVER_JDBC_CONNECTION_POOL_MAX_IDLE_TIME_EXCESS = "server.jdbc.connection-pool.max-idle-time-excess";
public static final String SERVER_JDBC_CONNECTION_POOL_IDLE_TEST_INTERVAL = "server.jdbc.connection-pool.idle-test-interval";
```
We should instead read these values from ambari.properties and set them on EclipseLink manually.
Sequence values can probably remain coded as they are.
- Jonathan Hurley
On April 21, 2015, 4:05 p.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33405/
> -----------------------------------------------------------
>
> (Updated April 21, 2015, 4:05 p.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Ivan Kozlov, Jonathan Hurley, Jayush Luniya, and Sid Wagle.
>
>
> Bugs: AMBARI-10637
> https://issues.apache.org/jira/browse/AMBARI-10637
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Split the Eclipselink sequence connection pool away from the main one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/META-INF/persistence.xml b864c591796967f7471e65ebbc995f8aabd2bed5
>
> Diff: https://reviews.apache.org/r/33405/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
> deployed in a local VM cluster -> no repro
>
>
> Thanks,
>
> Florian Barca
>
>