You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/19 10:37:42 UTC

[GitHub] [spark] beliefer opened a new pull request #32234: [SPARK-34715][SQL][TESTS] Add round trip tests for period <-> month and duration <-> micros

beliefer opened a new pull request #32234:
URL: https://github.com/apache/spark/pull/32234


   ### What changes were proposed in this pull request?
   Similarly to the test from the PR https://github.com/apache/spark/pull/31799, add tests:
   1. Months -> Period -> Months
   2. Period -> Months -> Period
   3. Duration -> micros -> Duration
   
   
   ### Why are the changes needed?
   Add round trip tests for period <-> month and duration <-> micros
   
   
   ### Does this PR introduce _any_ user-facing change?
   'No'. Just test cases.
   
   
   ### How was this patch tested?
   Jenkins test
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32234: [SPARK-34715][SQL][TESTS] Add round trip tests for period <-> month and duration <-> micros

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32234:
URL: https://github.com/apache/spark/pull/32234#issuecomment-822416710


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42159/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32234: [SPARK-34715][SQL][TESTS] Add round trip tests for period <-> month and duration <-> micros

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32234:
URL: https://github.com/apache/spark/pull/32234#issuecomment-822632881


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137628/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32234: [SPARK-34715][SQL][TESTS] Add round trip tests for period <-> month and duration <-> micros

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32234:
URL: https://github.com/apache/spark/pull/32234#issuecomment-822416710


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42159/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32234: [SPARK-34715][SQL][TESTS] Add round trip tests for period <-> month and duration <-> micros

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32234:
URL: https://github.com/apache/spark/pull/32234#issuecomment-822416692


   Kubernetes integration test unable to build dist.
   
   exiting with code: 1
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42159/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32234: [SPARK-34715][SQL][TESTS] Add round trip tests for period <-> month and duration <-> micros

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32234:
URL: https://github.com/apache/spark/pull/32234#issuecomment-822410007


   **[Test build #137628 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137628/testReport)** for PR 32234 at commit [`1c55a9d`](https://github.com/apache/spark/commit/1c55a9d81bef1b7dec01ec194815bc37235034a5).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on pull request #32234: [SPARK-34715][SQL][TESTS] Add round trip tests for period <-> month and duration <-> micros

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #32234:
URL: https://github.com/apache/spark/pull/32234#issuecomment-822456114


   +1, LGTM. Merging to master.
   Thank you, @beliefer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32234: [SPARK-34715][SQL][TESTS] Add round trip tests for period <-> month and duration <-> micros

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32234:
URL: https://github.com/apache/spark/pull/32234#issuecomment-822632881


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137628/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32234: [SPARK-34715][SQL][TESTS] Add round trip tests for period <-> month and duration <-> micros

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32234:
URL: https://github.com/apache/spark/pull/32234#issuecomment-822631153


   **[Test build #137628 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137628/testReport)** for PR 32234 at commit [`1c55a9d`](https://github.com/apache/spark/commit/1c55a9d81bef1b7dec01ec194815bc37235034a5).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #32234: [SPARK-34715][SQL][TESTS] Add round trip tests for period <-> month and duration <-> micros

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32234:
URL: https://github.com/apache/spark/pull/32234#issuecomment-822410007


   **[Test build #137628 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137628/testReport)** for PR 32234 at commit [`1c55a9d`](https://github.com/apache/spark/commit/1c55a9d81bef1b7dec01ec194815bc37235034a5).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #32234: [SPARK-34715][SQL][TESTS] Add round trip tests for period <-> month and duration <-> micros

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #32234:
URL: https://github.com/apache/spark/pull/32234#issuecomment-822919911


   @MaxGekk Thanks for your review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk closed pull request #32234: [SPARK-34715][SQL][TESTS] Add round trip tests for period <-> month and duration <-> micros

Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #32234:
URL: https://github.com/apache/spark/pull/32234


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org