You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/17 15:34:46 UTC
[GitHub] [arrow-rs] alamb commented on a diff in pull request #2466: Return structured ColumnCloseResult (#2465)
alamb commented on code in PR #2466:
URL: https://github.com/apache/arrow-rs/pull/2466#discussion_r948113817
##########
parquet/src/column/writer/mod.rs:
##########
@@ -145,13 +145,20 @@ pub fn get_typed_column_writer_mut<'a, 'b: 'a, T: DataType>(
})
}
-type ColumnCloseResult = (
- u64,
- u64,
- ColumnChunkMetaData,
- Option<ColumnIndex>,
- Option<OffsetIndex>,
-);
+/// Metadata returned by [`GenericColumnWriter::close`]
Review Comment:
This is much nicer documentation 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org