You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Bert Huijben <be...@qqmail.nl> on 2015/04/19 17:57:54 UTC

RE: svn commit: r1674628 - /subversion/branches/1.9.x/STATUS

Why do you set the header if you can just set the parsed depth value even more locally as I did in my patch I sent as reply on the thread?

Bert

-----Original Message-----
From: "stsp@apache.org" <st...@apache.org>
Sent: ‎19-‎4-‎2015 17:03
To: "commits@subversion.apache.org" <co...@subversion.apache.org>
Subject: svn commit: r1674628 - /subversion/branches/1.9.x/STATUS

Author: stsp
Date: Sun Apr 19 15:03:12 2015
New Revision: 1674628

URL: http://svn.apache.org/r1674628
Log:
* STATUS: Nominate r1674627.

Modified:
    subversion/branches/1.9.x/STATUS

Modified: subversion/branches/1.9.x/STATUS
URL: http://svn.apache.org/viewvc/subversion/branches/1.9.x/STATUS?rev=1674628&r1=1674627&r2=1674628&view=diff
==============================================================================
--- subversion/branches/1.9.x/STATUS (original)
+++ subversion/branches/1.9.x/STATUS Sun Apr 19 15:03:12 2015
@@ -61,6 +61,14 @@ Other candidate changes:
    Votes:
      +1: rhuijben
 
+ * r1674627
+   Prevent a mod_dav tree walk on copy sources (issue #4351).
+   Justification:
+     Current HTTPD releases ship a mod_dav bug fix which broke
+     'svn copy' constant time guarantees.
+   Votes:
+     +1: stsp
+
 Veto-blocked changes:
 =====================
 



Re: svn commit: r1674628 - /subversion/branches/1.9.x/STATUS

Posted by Greg Stein <gs...@gmail.com>.
Sure, I can add your +1 ... both backports? 1.8 and 1.9 ?

On Sun, Apr 19, 2015 at 1:21 PM, Bert Huijben <be...@qqmail.nl> wrote:

>  Thanks for the explanation on why you prefer the tweak here. With that
> explanation feel free to add my +1. (Or I will add it myself later tonight).
>
> Bert
>
> Sent from Windows Mail
>
> *From:* Greg Stein <gs...@gmail.com>
> *Sent:* ‎Sunday‎, ‎April‎ ‎19‎, ‎2015 ‎7‎:‎27‎ ‎PM
> *To:* dev@subversion.apache.org
>
> On Sun, Apr 19, 2015 at 11:40 AM, Branko Čibej <br...@wandisco.com> wrote:
>
>>  On 19.04.2015 10:57, Bert Huijben wrote:
>>
>>  Why do you set the header if you can just set the parsed depth value
>> even more locally as I did in my patch I sent as reply on the thread?
>>
>>
>> The patch Greg and Stefan cooked up kicks in a lot earlier in the request
>> processing flow, and by modifying the request record instead of some
>> internal structure it's more future-proof. IMO, that's a good thing.
>>
>
> Well... Bert's patch sets depth=0 for ALL walks when the method is COPY.
> That is unsafe, as you don't know *why* the walk is being performed. We
> only want to disable a specific walk, and the Depth:0 header trick does
> exactly that.
>
> To be fair, one day, if mod_dav ever decides to be strict about the Depth
> header matching the resource type (file vs dir), then this could break. But
> I don't see that happening, as it hasn't in over 15 years.
>
> The patch that Stefan and I came up with is just moving Johan's "set Depth
> header" concept into code.
>
> Hat tip to Johan for finding the workaround!
>
> Cheers,
> -g
>
>

Re: svn commit: r1674628 - /subversion/branches/1.9.x/STATUS

Posted by Bert Huijben <be...@qqmail.nl>.
Thanks for the explanation on why you prefer the tweak here. With that explanation feel free to add my +1. (Or I will add it myself later tonight).


Bert






Sent from Windows Mail





From: Greg Stein
Sent: ‎Sunday‎, ‎April‎ ‎19‎, ‎2015 ‎7‎:‎27‎ ‎PM
To: dev@subversion.apache.org







On Sun, Apr 19, 2015 at 11:40 AM, Branko Čibej <br...@wandisco.com> wrote:



On 19.04.2015 10:57, Bert Huijben wrote:




Why do you set the header if you can just set the parsed depth value even more locally as I did in my patch I sent as reply on the thread?


 The patch Greg and Stefan cooked up kicks in a lot earlier in the request processing flow, and by modifying the request record instead of some internal structure it's more future-proof. IMO, that's a good thing.



Well... Bert's patch sets depth=0 for ALL walks when the method is COPY. That is unsafe, as you don't know *why* the walk is being performed. We only want to disable a specific walk, and the Depth:0 header trick does exactly that.




To be fair, one day, if mod_dav ever decides to be strict about the Depth header matching the resource type (file vs dir), then this could break. But I don't see that happening, as it hasn't in over 15 years.




The patch that Stefan and I came up with is just moving Johan's "set Depth header" concept into code.




Hat tip to Johan for finding the workaround!




Cheers,

-g

Re: svn commit: r1674628 - /subversion/branches/1.9.x/STATUS

Posted by Johan Corveleyn <jc...@gmail.com>.
On Sun, Apr 19, 2015 at 7:27 PM, Greg Stein <gs...@gmail.com> wrote:
> On Sun, Apr 19, 2015 at 11:40 AM, Branko Čibej <br...@wandisco.com> wrote:
>>
>> On 19.04.2015 10:57, Bert Huijben wrote:
>>
>> Why do you set the header if you can just set the parsed depth value even
>> more locally as I did in my patch I sent as reply on the thread?
>>
>>
>> The patch Greg and Stefan cooked up kicks in a lot earlier in the request
>> processing flow, and by modifying the request record instead of some
>> internal structure it's more future-proof. IMO, that's a good thing.
>
>
> Well... Bert's patch sets depth=0 for ALL walks when the method is COPY.
> That is unsafe, as you don't know *why* the walk is being performed. We only
> want to disable a specific walk, and the Depth:0 header trick does exactly
> that.
>
> To be fair, one day, if mod_dav ever decides to be strict about the Depth
> header matching the resource type (file vs dir), then this could break. But
> I don't see that happening, as it hasn't in over 15 years.
>
> The patch that Stefan and I came up with is just moving Johan's "set Depth
> header" concept into code.
>
> Hat tip to Johan for finding the workaround!

Thanks :-). I'm glad you guys made a mod_dav_svn fix out of it. That's
gonna help even more users / admins.

Cheers,
-- 
Johan

Re: svn commit: r1674628 - /subversion/branches/1.9.x/STATUS

Posted by Greg Stein <gs...@gmail.com>.
On Sun, Apr 19, 2015 at 11:40 AM, Branko Čibej <br...@wandisco.com> wrote:

>  On 19.04.2015 10:57, Bert Huijben wrote:
>
>  Why do you set the header if you can just set the parsed depth value
> even more locally as I did in my patch I sent as reply on the thread?
>
>
> The patch Greg and Stefan cooked up kicks in a lot earlier in the request
> processing flow, and by modifying the request record instead of some
> internal structure it's more future-proof. IMO, that's a good thing.
>

Well... Bert's patch sets depth=0 for ALL walks when the method is COPY.
That is unsafe, as you don't know *why* the walk is being performed. We
only want to disable a specific walk, and the Depth:0 header trick does
exactly that.

To be fair, one day, if mod_dav ever decides to be strict about the Depth
header matching the resource type (file vs dir), then this could break. But
I don't see that happening, as it hasn't in over 15 years.

The patch that Stefan and I came up with is just moving Johan's "set Depth
header" concept into code.

Hat tip to Johan for finding the workaround!

Cheers,
-g

Re: svn commit: r1674628 - /subversion/branches/1.9.x/STATUS

Posted by Branko Čibej <br...@wandisco.com>.
On 19.04.2015 10:57, Bert Huijben wrote:
> Why do you set the header if you can just set the parsed depth value
> even more locally as I did in my patch I sent as reply on the thread?

The patch Greg and Stefan cooked up kicks in a lot earlier in the
request processing flow, and by modifying the request record instead of
some internal structure it's more future-proof. IMO, that's a good thing.

-- Brane


Re: svn commit: r1674628 - /subversion/branches/1.9.x/STATUS

Posted by Bert Huijben <be...@qqmail.nl>.
I don't have those links in my telephone. As far as I know the link was in the thread where we discussed this; perhaps in the related issue.





Bert


Sent from Windows Mail





From: Stefan Sperling
Sent: ‎Sunday‎, ‎April‎ ‎19‎, ‎2015 ‎6‎:‎18‎ ‎PM
To: dev@subversion.apache.org
Cc: commits@subversion.apache.org





On Sun, Apr 19, 2015 at 05:57:54PM +0200, Bert Huijben wrote:
> Why do you set the header if you can just set the parsed depth value even more locally as I did in my patch I sent as reply on the thread?

I could not find your patch in the thread with subject
"branching over mod_dav 2.4.6 is O(tree)". Is that the wrong thread?
Please post a link to your patch.

(Perhaps, generally, please try to provide links or at least subject
lines when referencing a discussion thread -- it might seem like a burden on
you but it saves other people a lot of time, especially if they're trying
to understand this discussion in a few weeks/months).

Re: svn commit: r1674628 - /subversion/branches/1.9.x/STATUS

Posted by Bert Huijben <be...@qqmail.nl>.
I don't have those links in my telephone. As far as I know the link was in the thread where we discussed this; perhaps in the related issue.





Bert


Sent from Windows Mail





From: Stefan Sperling
Sent: ‎Sunday‎, ‎April‎ ‎19‎, ‎2015 ‎6‎:‎18‎ ‎PM
To: dev@subversion.apache.org
Cc: commits@subversion.apache.org





On Sun, Apr 19, 2015 at 05:57:54PM +0200, Bert Huijben wrote:
> Why do you set the header if you can just set the parsed depth value even more locally as I did in my patch I sent as reply on the thread?

I could not find your patch in the thread with subject
"branching over mod_dav 2.4.6 is O(tree)". Is that the wrong thread?
Please post a link to your patch.

(Perhaps, generally, please try to provide links or at least subject
lines when referencing a discussion thread -- it might seem like a burden on
you but it saves other people a lot of time, especially if they're trying
to understand this discussion in a few weeks/months).

Re: svn commit: r1674628 - /subversion/branches/1.9.x/STATUS

Posted by Stefan Sperling <st...@elego.de>.
On Sun, Apr 19, 2015 at 05:57:54PM +0200, Bert Huijben wrote:
> Why do you set the header if you can just set the parsed depth value even more locally as I did in my patch I sent as reply on the thread?

I could not find your patch in the thread with subject
"branching over mod_dav 2.4.6 is O(tree)". Is that the wrong thread?
Please post a link to your patch.

(Perhaps, generally, please try to provide links or at least subject
lines when referencing a discussion thread -- it might seem like a burden on
you but it saves other people a lot of time, especially if they're trying
to understand this discussion in a few weeks/months).

Re: svn commit: r1674628 - /subversion/branches/1.9.x/STATUS

Posted by Stefan Sperling <st...@elego.de>.
On Sun, Apr 19, 2015 at 05:57:54PM +0200, Bert Huijben wrote:
> Why do you set the header if you can just set the parsed depth value even more locally as I did in my patch I sent as reply on the thread?

I could not find your patch in the thread with subject
"branching over mod_dav 2.4.6 is O(tree)". Is that the wrong thread?
Please post a link to your patch.

(Perhaps, generally, please try to provide links or at least subject
lines when referencing a discussion thread -- it might seem like a burden on
you but it saves other people a lot of time, especially if they're trying
to understand this discussion in a few weeks/months).