You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by "Prashant Pogde (Jira)" <ji...@apache.org> on 2023/05/24 20:56:00 UTC

[jira] [Created] (HDDS-8685) CreateCheckpoint needs to be idemp[otent

Prashant Pogde created HDDS-8685:
------------------------------------

             Summary: CreateCheckpoint needs to be idemp[otent
                 Key: HDDS-8685
                 URL: https://issues.apache.org/jira/browse/HDDS-8685
             Project: Apache Ozone
          Issue Type: Sub-task
            Reporter: Prashant Pogde
            Assignee: Aswin Shakil


Create snapshot  can be called multiple times with log replay. We need to make sure that it's idempotent.  Consider scenarios

 

* Create rocksDB checkpoint itself can cause issues.

     - RocksDB will create hardlinks in a temp directory

     - after links are created, temp dir is renamed to snapshot-id

     - we make entry in snapshot info table

 

Operation could fail at any time due to OM crash/restart and log replay will start from the beginning here. We need to make sure
 * We need to make sure clean up the temp directory. un-removed hardlinks will pose a problem because we sst files with these hardlink will not get cleaned up when the snapshots are deleted due to extra link.  
 * CreateCheckpoint doesn't try to recreated the checkpoint again. (rocksDB operation would fail)

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org