You are viewing a plain text version of this content. The canonical link for it is here.
Posted to qa@openoffice.apache.org by Regina Henschel <rb...@t-online.de> on 2014/07/31 01:20:04 UTC
Development progress on SVG-graphics
Hi all,
perhaps you have noticed recently a lot of issues and commits regarding
SVG. Styling a SVG-Graphic with CSS stylesheets is a great feature, but
very complex. Thanks to Armins recent work, OpenOffice now understands
the simple selectors 'id', 'class' and type in the style sheet element,
understands the style attribute in addition to non-css presentation
attributes, and handles their priority correctly. That covers most of
the graphics you will use, for example from clip art galleries.
These CSS-features are still missing:
complex selectors with descendant, child and sibling relations
selectors with attributes
@import and @media
!important
pseudo classes like :lang or :hover
The current state has been tested with a lot of special test files. But
now we need “real-life” svg-graphics. So if you come across such
graphics, please take an OpenOffice build from a buildbot (make sure it
is a 4.2 build and not a 4.1.1 build) and try it out; and when you
encounter a problem, report it here.
Kind regards
Regina
---------------------------------------------------------------------
To unsubscribe, e-mail: qa-unsubscribe@openoffice.apache.org
For additional commands, e-mail: qa-help@openoffice.apache.org
Re: Development progress on SVG-graphics
Posted by Armin Le Grand <Ar...@me.com>.
Hi Regina,
On 16.08.2014 21:01, Regina Henschel wrote:
> Hi all,
>
> there have been some discussions in German in private emails before
> the implementations. That was a wrong behavior and should not happen
> again, please excuse this.
>
> I'll translate and summarize here some of those discussions:
>
> CSS knows a large variety of selectors in a rule, read
> http://www.w3.org/TR/CSS21/selector.html. We discussed to which extend
> they should be supported. Because currently Inkscape supports CSS only
> rudimentary, and there are no special requests in Bugzilla, and other
> areas of CSS (e.g. filter and animation) are more important, the
> decision has been, to support only those selectors, which can be
> implemented straightforward within the existing design. Find details
> about current implementation in the comments in
> main/svgio/source/svgreader/svgstylenode.cxx.
>
> There exists currently no code to load external data which are
> referenced in a svg-image. Therefore support for "@import" rule has
> been postponed.
>
> In contrast to browsers, the environment, in which svg-images are used
> in Apache OpenOffice, has no user-defined style sheets. In addition
> '@import' rule is not supported. So the author's rule is always taken
> and authors can directly determine the order of styles. Therefore the
> '!important' part of a description is ignored for now.
>
> A CSS-style is stored in a SvgStyleAttributes-instance. Each svg-node
> gets a linked list of pointers to styles, ordered according the
> priority specified by "cascading". The list is build once using method
> fillCssStyleVector. (I hope, I've got it right.)
Yes, thanks for adding this here. Maybe I am sometimes too concentrated
on discussing issues directly in the issuezilla task. OTOH it belongs
there and the task defines the problem to discuss about precisely. OTOH
the bugzilla mailing list is just too big to always follow completely,
so maybe sending hints to issues where a discussion is ongoing to the
dev list is a good approach...
Sincerely,
Armin
>
> Kind regards
> Regina
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: dev-help@openoffice.apache.org
>
--
ALG
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: Development progress on SVG-graphics
Posted by Regina Henschel <rb...@t-online.de>.
Hi all,
there have been some discussions in German in private emails before the
implementations. That was a wrong behavior and should not happen again,
please excuse this.
I'll translate and summarize here some of those discussions:
CSS knows a large variety of selectors in a rule, read
http://www.w3.org/TR/CSS21/selector.html. We discussed to which extend
they should be supported. Because currently Inkscape supports CSS only
rudimentary, and there are no special requests in Bugzilla, and other
areas of CSS (e.g. filter and animation) are more important, the
decision has been, to support only those selectors, which can be
implemented straightforward within the existing design. Find details
about current implementation in the comments in
main/svgio/source/svgreader/svgstylenode.cxx.
There exists currently no code to load external data which are
referenced in a svg-image. Therefore support for "@import" rule has been
postponed.
In contrast to browsers, the environment, in which svg-images are used
in Apache OpenOffice, has no user-defined style sheets. In addition
'@import' rule is not supported. So the author's rule is always taken
and authors can directly determine the order of styles. Therefore the
'!important' part of a description is ignored for now.
A CSS-style is stored in a SvgStyleAttributes-instance. Each svg-node
gets a linked list of pointers to styles, ordered according the priority
specified by "cascading". The list is build once using method
fillCssStyleVector. (I hope, I've got it right.)
Kind regards
Regina
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: Development progress on SVG-graphics
Posted by Jürgen Schmidt <jo...@gmail.com>.
what are you all smoking or drinking ... he, hu, ho, hi
Have a nice weeknend
Juergen
On 01/08/14 16:44, Armin Le Grand wrote:
> Hi Pedro,
>
> On 01.08.2014 15:34, Pedro Lino wrote:
>> Hu Armin, Regina
>>
>>
>> On Fri, Aug 1, 2014 at 2:29 PM, Armin Le Grand <Ar...@me.com>
>> wrote:
>>
>>> Ho Pedro,
>>>
>>>
>>> On 01.08.2014 14:43, Regina Henschel wrote:
>>>
>>>> He Pedro,
>>>>
>>>> Pedro Lino schrieb:
>>>>
>>>>> Hi Regina
>>>>>
>>>>> I'm not sure if this is what you meant, but I reported this bug on
>>>>> LO a
>>>>> long time ago but it is also present in AOO.
>>>>>
>>>>> https://bugs.freedesktop.org/show_bug.cgi?id=71068
>>>>>
>>>> No, the current improvements are for import of svg graphics and the
>>>> import seems to be correct in your case. I can see a normal Chrome
>>>> logo. In
>>>> addition, the logo has been created with Inkscape and Inkscape has only
>>>> small support for CSS.
>>>>
>>>> BTW, the error is not in the pdf export, but in the conservation to
>>>> metafile.
>>>>
>>> Regina is right, it's a problem in conversion to metafile, probably
>>> clipping involved. Do we have a task in bugzilla for this?
>>>
>> The task is in LO's Bugzilla. Should I add a copy to AOO's Issuezilla?
>>
>
> Maybe, but more simple, please. It's enough to
> - insert SVG
> - convert to metafile (context menu)
> You can add me to CC immediately.
>
> Sincerely,
> Armin
> --
> ALG
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: qa-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: qa-help@openoffice.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: qa-unsubscribe@openoffice.apache.org
For additional commands, e-mail: qa-help@openoffice.apache.org
Re: Development progress on SVG-graphics
Posted by Regina Henschel <rb...@t-online.de>.
Hi,
Armin Le Grand schrieb:
[..]
>>> On 01.08.2014 14:43, Regina Henschel wrote:
[..]
>>>> BTW, the error is not in the pdf export, but in the conservation to
>>>> metafile.
>>>>
>>> Regina is right, it's a problem in conversion to metafile, probably
>>> clipping involved. Do we have a task in bugzilla for this?
I have written https://issues.apache.org/ooo/show_bug.cgi?id=125349
The reason is the combination of point outside viewBox and gradient
fill, details in the bug report.
Kind regards
Regina
---------------------------------------------------------------------
To unsubscribe, e-mail: qa-unsubscribe@openoffice.apache.org
For additional commands, e-mail: qa-help@openoffice.apache.org
Re: Development progress on SVG-graphics
Posted by Pedro Lino <pe...@gmail.com>.
Hi Ariel
Thank you for the detailed instructions!
Yes, that does show what you get when you export to PDF and in the PNG
thumbnails..
Thanks!
On Sat, Aug 2, 2014 at 10:45 AM, Ariel Constenla-Haile <ar...@apache.org>
wrote:
> On Sat, Aug 02, 2014 at 10:35:01AM +0100, Pedro Lino wrote:
> > Hi Armin, Regina, all
> >
> >
> > On Fri, Aug 1, 2014 at 3:44 PM, Armin Le Grand <Ar...@me.com>
> > wrote:
> >
> > > Maybe, but more simple, please. It's enough to
> > > - insert SVG
> > > - convert to metafile (context menu)
> > > You can add me to CC immediately.
> > >
> > >
> > If you mean right click on the SVG, choose Save Graphics and then saving
> as
> > Enhanced Metafile or Windows Metafile, then the files are exported
> > correctly.
> >
> > That is not the problem
>
> You have to use Draw, not Writer, in order to find that option in the
> context menu.
>
> - New Draw document
> - Insert
> http://upload.wikimedia.org/wikipedia/commons/archive/e/e2/20140516213145%21Google_Chrome_icon_%282011%29.svg
> - Select the graphic
> - Right-click to open the context menu
> - Select "Convert" - To Metafile" (or just select "Break")
>
> This is reproducible with the first version from
> http://en.wikipedia.org/wiki/File:Google_Chrome_icon_%282011%29.svg but
> not with the current one.
>
>
> Regards
> --
> Ariel Constenla-Haile
> La Plata, Argentina
>
Re: Development progress on SVG-graphics
Posted by Ariel Constenla-Haile <ar...@apache.org>.
On Sat, Aug 02, 2014 at 10:35:01AM +0100, Pedro Lino wrote:
> Hi Armin, Regina, all
>
>
> On Fri, Aug 1, 2014 at 3:44 PM, Armin Le Grand <Ar...@me.com>
> wrote:
>
> > Maybe, but more simple, please. It's enough to
> > - insert SVG
> > - convert to metafile (context menu)
> > You can add me to CC immediately.
> >
> >
> If you mean right click on the SVG, choose Save Graphics and then saving as
> Enhanced Metafile or Windows Metafile, then the files are exported
> correctly.
>
> That is not the problem
You have to use Draw, not Writer, in order to find that option in the
context menu.
- New Draw document
- Insert http://upload.wikimedia.org/wikipedia/commons/archive/e/e2/20140516213145%21Google_Chrome_icon_%282011%29.svg
- Select the graphic
- Right-click to open the context menu
- Select "Convert" - To Metafile" (or just select "Break")
This is reproducible with the first version from
http://en.wikipedia.org/wiki/File:Google_Chrome_icon_%282011%29.svg but
not with the current one.
Regards
--
Ariel Constenla-Haile
La Plata, Argentina
Re: Development progress on SVG-graphics
Posted by Pedro Lino <pe...@gmail.com>.
Hi Armin, Regina, all
On Fri, Aug 1, 2014 at 3:44 PM, Armin Le Grand <Ar...@me.com>
wrote:
> Maybe, but more simple, please. It's enough to
> - insert SVG
> - convert to metafile (context menu)
> You can add me to CC immediately.
>
>
If you mean right click on the SVG, choose Save Graphics and then saving as
Enhanced Metafile or Windows Metafile, then the files are exported
correctly.
That is not the problem
Re: Development progress on SVG-graphics
Posted by Armin Le Grand <Ar...@me.com>.
Hi Pedro,
On 01.08.2014 15:34, Pedro Lino wrote:
> Hu Armin, Regina
>
>
> On Fri, Aug 1, 2014 at 2:29 PM, Armin Le Grand <Ar...@me.com>
> wrote:
>
>> Ho Pedro,
>>
>>
>> On 01.08.2014 14:43, Regina Henschel wrote:
>>
>>> He Pedro,
>>>
>>> Pedro Lino schrieb:
>>>
>>>> Hi Regina
>>>>
>>>> I'm not sure if this is what you meant, but I reported this bug on LO a
>>>> long time ago but it is also present in AOO.
>>>>
>>>> https://bugs.freedesktop.org/show_bug.cgi?id=71068
>>>>
>>> No, the current improvements are for import of svg graphics and the
>>> import seems to be correct in your case. I can see a normal Chrome logo. In
>>> addition, the logo has been created with Inkscape and Inkscape has only
>>> small support for CSS.
>>>
>>> BTW, the error is not in the pdf export, but in the conservation to
>>> metafile.
>>>
>> Regina is right, it's a problem in conversion to metafile, probably
>> clipping involved. Do we have a task in bugzilla for this?
>>
> The task is in LO's Bugzilla. Should I add a copy to AOO's Issuezilla?
>
Maybe, but more simple, please. It's enough to
- insert SVG
- convert to metafile (context menu)
You can add me to CC immediately.
Sincerely,
Armin
--
ALG
---------------------------------------------------------------------
To unsubscribe, e-mail: qa-unsubscribe@openoffice.apache.org
For additional commands, e-mail: qa-help@openoffice.apache.org
Re: Development progress on SVG-graphics
Posted by Pedro Lino <pe...@gmail.com>.
Hu Armin, Regina
On Fri, Aug 1, 2014 at 2:29 PM, Armin Le Grand <Ar...@me.com>
wrote:
> Ho Pedro,
>
>
> On 01.08.2014 14:43, Regina Henschel wrote:
>
>> He Pedro,
>>
>> Pedro Lino schrieb:
>>
>>> Hi Regina
>>>
>>> I'm not sure if this is what you meant, but I reported this bug on LO a
>>> long time ago but it is also present in AOO.
>>>
>>> https://bugs.freedesktop.org/show_bug.cgi?id=71068
>>>
>>
>> No, the current improvements are for import of svg graphics and the
>> import seems to be correct in your case. I can see a normal Chrome logo. In
>> addition, the logo has been created with Inkscape and Inkscape has only
>> small support for CSS.
>>
>> BTW, the error is not in the pdf export, but in the conservation to
>> metafile.
>>
>
> Regina is right, it's a problem in conversion to metafile, probably
> clipping involved. Do we have a task in bugzilla for this?
>
The task is in LO's Bugzilla. Should I add a copy to AOO's Issuezilla?
Re: Development progress on SVG-graphics
Posted by Armin Le Grand <Ar...@me.com>.
Ho Pedro,
On 01.08.2014 14:43, Regina Henschel wrote:
> He Pedro,
>
> Pedro Lino schrieb:
>> Hi Regina
>>
>> I'm not sure if this is what you meant, but I reported this bug on LO a
>> long time ago but it is also present in AOO.
>>
>> https://bugs.freedesktop.org/show_bug.cgi?id=71068
>
> No, the current improvements are for import of svg graphics and the
> import seems to be correct in your case. I can see a normal Chrome
> logo. In addition, the logo has been created with Inkscape and
> Inkscape has only small support for CSS.
>
> BTW, the error is not in the pdf export, but in the conservation to
> metafile.
Regina is right, it's a problem in conversion to metafile, probably
clipping involved. Do we have a task in bugzilla for this?
Sincerely,
Armin
>
> Kind regards
> Regina
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: qa-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: qa-help@openoffice.apache.org
>
--
ALG
---------------------------------------------------------------------
To unsubscribe, e-mail: qa-unsubscribe@openoffice.apache.org
For additional commands, e-mail: qa-help@openoffice.apache.org
Re: Development progress on SVG-graphics
Posted by Regina Henschel <rb...@t-online.de>.
He Pedro,
Pedro Lino schrieb:
> Hi Regina
>
> I'm not sure if this is what you meant, but I reported this bug on LO a
> long time ago but it is also present in AOO.
>
> https://bugs.freedesktop.org/show_bug.cgi?id=71068
No, the current improvements are for import of svg graphics and the
import seems to be correct in your case. I can see a normal Chrome logo.
In addition, the logo has been created with Inkscape and Inkscape has
only small support for CSS.
BTW, the error is not in the pdf export, but in the conservation to
metafile.
Kind regards
Regina
---------------------------------------------------------------------
To unsubscribe, e-mail: qa-unsubscribe@openoffice.apache.org
For additional commands, e-mail: qa-help@openoffice.apache.org
Re: Development progress on SVG-graphics
Posted by Pedro Lino <pe...@gmail.com>.
Hi Regina
I'm not sure if this is what you meant, but I reported this bug on LO a
long time ago but it is also present in AOO.
https://bugs.freedesktop.org/show_bug.cgi?id=71068
Kind regards,
Pedro
On Thu, Jul 31, 2014 at 12:20 AM, Regina Henschel <rb...@t-online.de>
wrote:
> Hi all,
>
> perhaps you have noticed recently a lot of issues and commits regarding
> SVG. Styling a SVG-Graphic with CSS stylesheets is a great feature, but
> very complex. Thanks to Armins recent work, OpenOffice now understands the
> simple selectors 'id', 'class' and type in the style sheet element,
> understands the style attribute in addition to non-css presentation
> attributes, and handles their priority correctly. That covers most of the
> graphics you will use, for example from clip art galleries.
>
> These CSS-features are still missing:
> complex selectors with descendant, child and sibling relations
> selectors with attributes
> @import and @media
> !important
> pseudo classes like :lang or :hover
>
> The current state has been tested with a lot of special test files. But
> now we need "real-life" svg-graphics. So if you come across such graphics,
> please take an OpenOffice build from a buildbot (make sure it is a 4.2
> build and not a 4.1.1 build) and try it out; and when you encounter a
> problem, report it here.
>
> Kind regards
> Regina
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: qa-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: qa-help@openoffice.apache.org
>
>