You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/24 08:22:00 UTC

[GitHub] [skywalking-booster-ui] Fine0830 opened a new pull request, #191: fix: update metric processor for the `readRecords`

Fine0830 opened a new pull request, #191:
URL: https://github.com/apache/skywalking-booster-ui/pull/191

   Fixes metric processor for the `readRecords`.
   
   Video 
   
   
   https://user-images.githubusercontent.com/20871783/203730031-382d18f2-f42d-4e00-afed-8a1269bd39c7.mov
   
   Signed-off-by: Qiuxia Fan <qi...@apache.org>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-booster-ui] Fine0830 commented on pull request #191: fix: update metric processor for the `readRecords` and remove `readSampledRecords` from metrics selector

Posted by GitBox <gi...@apache.org>.
Fine0830 commented on PR #191:
URL: https://github.com/apache/skywalking-booster-ui/pull/191#issuecomment-1326238682

   
   Removed `readSampledRecords` from metrics selector
   
   <img width="1899" alt="1" src="https://user-images.githubusercontent.com/20871783/203758328-1cf703b0-32f6-4a49-94f2-a9b36d4d7987.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-booster-ui] wu-sheng commented on pull request #191: fix: update metric processor for the `readRecords`

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #191:
URL: https://github.com/apache/skywalking-booster-ui/pull/191#issuecomment-1326216790

   Let's adopt the latest `readRecords` and remove the **deprecated** `readSampledRecords`
   
   Ref https://github.com/apache/skywalking-query-protocol/blob/90724a9c4982ea806d6ad58304ed70d3c3758248/metrics-v2.graphqls#L156-L159


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-booster-ui] wu-sheng merged pull request #191: fix: update metric processor for the `readRecords` and remove `readSampledRecords` from metrics selector

Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #191:
URL: https://github.com/apache/skywalking-booster-ui/pull/191


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org