You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by rf...@apache.org on 2020/06/20 08:40:13 UTC
[maven] 06/30: Created unit tests for the resumeFromSelector method.
This is an automated email from the ASF dual-hosted git repository.
rfscholte pushed a commit to branch MNG-5760
in repository https://gitbox.apache.org/repos/asf/maven.git
commit 3467b0dd868dc4042be04ebd81e5adfda876d625
Author: Martin Kanters <Ma...@infosupport.com>
AuthorDate: Fri May 22 15:14:24 2020 +0200
Created unit tests for the resumeFromSelector method.
---
.../execution/BuildResumptionManagerTest.java | 33 +++++++++++++++++++++-
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/maven-core/src/test/java/org/apache/maven/execution/BuildResumptionManagerTest.java b/maven-core/src/test/java/org/apache/maven/execution/BuildResumptionManagerTest.java
index 95a0375..96c0dee 100644
--- a/maven-core/src/test/java/org/apache/maven/execution/BuildResumptionManagerTest.java
+++ b/maven-core/src/test/java/org/apache/maven/execution/BuildResumptionManagerTest.java
@@ -159,10 +159,41 @@ public class BuildResumptionManagerTest
assertThat( request.getExcludedProjects(), contains( ":module-a", ":module-b", ":module-c" ) );
}
+ @Test
+ public void resumeFromSelectorIsSuggestedWithoutGroupId()
+ {
+ List<MavenProject> allProjects = asList(
+ createMavenProject( "group", "module-a" ),
+ createMavenProject( "group", "module-b" ) );
+ MavenProject failedProject = allProjects.get( 0 );
+
+ String selector = buildResumptionManager.getResumeFromSelector( allProjects, failedProject );
+
+ assertThat( selector, is( ":module-a" ) );
+ }
+
+ @Test
+ public void resumeFromSelectorContainsGroupIdWhenArtifactIdIsNotUnique()
+ {
+ List<MavenProject> allProjects = asList(
+ createMavenProject( "group-a", "module" ),
+ createMavenProject( "group-b", "module" ) );
+ MavenProject failedProject = allProjects.get( 0 );
+
+ String selector = buildResumptionManager.getResumeFromSelector( allProjects, failedProject );
+
+ assertThat( selector, is( "group-a:module" ) );
+ }
+
private MavenProject createMavenProject( String artifactId )
{
+ return createMavenProject( "test", artifactId );
+ }
+
+ private MavenProject createMavenProject( String groupId, String artifactId )
+ {
MavenProject project = new MavenProject();
- project.setGroupId( "test" );
+ project.setGroupId( groupId );
project.setArtifactId( artifactId );
return project;
}