You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/09/01 16:05:31 UTC
[GitHub] [hive] zabetak opened a new pull request #1453: HIVE-24104: NPE due to null key columns in ReduceSink after deduplication
zabetak opened a new pull request #1453:
URL: https://github.com/apache/hive/pull/1453
### What changes were proposed in this pull request?
Remove double backtracking of columns inside ReduceSinkDeDuplicationUtils#ggressiveDedup.
### Why are the changes needed?
To prevent NPE during planning or execution. Examples in the JIRA case.
### Does this PR introduce _any_ user-facing change?
Changes in the EXPLAIN plans but probably for the best.
### How was this patch tested?
`mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile=reduce_deduplicate_null_keys.q`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on a change in pull request #1453: HIVE-24104: NPE due to null key columns in ReduceSink after deduplication
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on a change in pull request #1453:
URL: https://github.com/apache/hive/pull/1453#discussion_r482770439
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/ReduceSinkDeDuplicationUtils.java
##########
@@ -570,7 +570,7 @@ protected static boolean aggressiveDedup(ReduceSinkOperator cRS, ReduceSinkOpera
return false;
}
}
- cRS.getConf().setKeyCols(ExprNodeDescUtils.backtrack(cKeysInParentRS, cRS, pRS));
+ cRS.getConf().setKeyCols(cKeysInParentRS);
Review comment:
this seems to be a 3 year old typo; I wonder why it didn't surfaced earlier
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on a change in pull request #1453: HIVE-24104: NPE due to null key columns in ReduceSink after deduplication
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on a change in pull request #1453:
URL: https://github.com/apache/hive/pull/1453#discussion_r482764142
##########
File path: ql/src/test/queries/clientpositive/dynamic_semijoin_reduction_on_aggcol.q
##########
@@ -1,3 +1,4 @@
+--! qt:disabled:flaky HIVE-24112
Review comment:
I've just saw another PR failing with this test as well - please ping me somehow to get things like this in sooner than later
I think another option could be to open a ticketless PR to merge in the disablement of the tests; with that it will only need 1 click from a committer (and it can be even done from phone as well)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk merged pull request #1453: HIVE-24104: NPE due to null key columns in ReduceSink after deduplication
Posted by GitBox <gi...@apache.org>.
kgyrtkirk merged pull request #1453:
URL: https://github.com/apache/hive/pull/1453
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org