You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "Brad Anderson (JIRA)" <ji...@apache.org> on 2009/05/18 20:39:45 UTC

[jira] Created: (COUCHDB-353) [PATCH] add default_handler into configuration for overriding couch_httpd_db:handle_request/1 if needed

[PATCH] add default_handler into configuration for overriding couch_httpd_db:handle_request/1 if needed
-------------------------------------------------------------------------------------------------------

                 Key: COUCHDB-353
                 URL: https://issues.apache.org/jira/browse/COUCHDB-353
             Project: CouchDB
          Issue Type: Improvement
          Components: HTTP Interface
    Affects Versions: 0.9
            Reporter: Brad Anderson
            Priority: Minor
             Fix For: 0.10
         Attachments: default_handler.patch

To execute code other than couch_httpd_db:handle_request/1 for the default handler function, we need to add a configuration option to specify the new module/fun and execute that function upon a request.  This will allow devs to execute alternate code for things like database creation and deletion, etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (COUCHDB-353) [PATCH] add default_handler into configuration for overriding couch_httpd_db:handle_request/1 if needed

Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COUCHDB-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710444#action_12710444 ] 

Paul Joseph Davis commented on COUCHDB-353:
-------------------------------------------

Brad,

Can you run a quick curl test to make sure that the mochiweb receive loop gets notification of the config change (via being kiled from the exit call and restarted)? I'm wondering if maybe the config handler might need to explicitly kill the mochiweb server.

> [PATCH] add default_handler into configuration for overriding couch_httpd_db:handle_request/1 if needed
> -------------------------------------------------------------------------------------------------------
>
>                 Key: COUCHDB-353
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-353
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: HTTP Interface
>    Affects Versions: 0.9
>            Reporter: Brad Anderson
>            Priority: Minor
>             Fix For: 0.10
>
>         Attachments: default_handler.patch
>
>
> To execute code other than couch_httpd_db:handle_request/1 for the default handler function, we need to add a configuration option to specify the new module/fun and execute that function upon a request.  This will allow devs to execute alternate code for things like database creation and deletion, etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-353) [PATCH] add default_handler into configuration for overriding couch_httpd_db:handle_request/1 if needed

Posted by "Brad Anderson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brad Anderson updated COUCHDB-353:
----------------------------------

    Attachment: default_handler.console.txt

This console dump shows that mochiweb is picking up the change and does not need to be restarted, as davisp was thinking might be required.

Note:  my new handler returns {ok, false} and doesn't delete the database.  The normal couch handler returns {ok, true} and performs the delete of the database.

> [PATCH] add default_handler into configuration for overriding couch_httpd_db:handle_request/1 if needed
> -------------------------------------------------------------------------------------------------------
>
>                 Key: COUCHDB-353
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-353
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: HTTP Interface
>    Affects Versions: 0.9
>            Reporter: Brad Anderson
>            Priority: Minor
>             Fix For: 0.10
>
>         Attachments: default_handler.console.txt, default_handler.patch
>
>
> To execute code other than couch_httpd_db:handle_request/1 for the default handler function, we need to add a configuration option to specify the new module/fun and execute that function upon a request.  This will allow devs to execute alternate code for things like database creation and deletion, etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COUCHDB-353) [PATCH] add default_handler into configuration for overriding couch_httpd_db:handle_request/1 if needed

Posted by "Brad Anderson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brad Anderson updated COUCHDB-353:
----------------------------------

    Attachment: default_handler.patch

> [PATCH] add default_handler into configuration for overriding couch_httpd_db:handle_request/1 if needed
> -------------------------------------------------------------------------------------------------------
>
>                 Key: COUCHDB-353
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-353
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: HTTP Interface
>    Affects Versions: 0.9
>            Reporter: Brad Anderson
>            Priority: Minor
>             Fix For: 0.10
>
>         Attachments: default_handler.patch
>
>
> To execute code other than couch_httpd_db:handle_request/1 for the default handler function, we need to add a configuration option to specify the new module/fun and execute that function upon a request.  This will allow devs to execute alternate code for things like database creation and deletion, etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (COUCHDB-353) [PATCH] add default_handler into configuration for overriding couch_httpd_db:handle_request/1 if needed

Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Joseph Davis resolved COUCHDB-353.
---------------------------------------

    Resolution: Fixed
      Assignee: Paul Joseph Davis

In trunk as of r776143

> [PATCH] add default_handler into configuration for overriding couch_httpd_db:handle_request/1 if needed
> -------------------------------------------------------------------------------------------------------
>
>                 Key: COUCHDB-353
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-353
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: HTTP Interface
>    Affects Versions: 0.9
>            Reporter: Brad Anderson
>            Assignee: Paul Joseph Davis
>            Priority: Minor
>             Fix For: 0.10
>
>         Attachments: default_handler.console.txt, default_handler.patch
>
>
> To execute code other than couch_httpd_db:handle_request/1 for the default handler function, we need to add a configuration option to specify the new module/fun and execute that function upon a request.  This will allow devs to execute alternate code for things like database creation and deletion, etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.