You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morningman (via GitHub)" <gi...@apache.org> on 2023/05/27 10:21:58 UTC

[GitHub] [doris] morningman opened a new pull request, #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

morningman opened a new pull request, #20137:
URL: https://github.com/apache/doris/pull/20137

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   Describe your changes.
   
   ## Checklist(Required)
   
   * [ ] Does it affect the original behavior
   * [ ] Has unit tests been added
   * [ ] Has document been added or modified
   * [ ] Does it need to update dependencies
   * [ ] Is this PR support rollback (If NO, please explain WHY)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1567994475

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1566149343

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1567752590

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1565337990

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] Jibing-Li commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1566706781

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1567234591

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1566754545

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman merged pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #20137:
URL: https://github.com/apache/doris/pull/20137


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1567050186

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1566591404

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] Jibing-Li commented on a diff in pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "Jibing-Li (via GitHub)" <gi...@apache.org>.
Jibing-Li commented on code in PR #20137:
URL: https://github.com/apache/doris/pull/20137#discussion_r1209033286


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/CatalogFactory.java:
##########
@@ -74,21 +71,33 @@ public static CatalogLog constructorCatalogLog(long catalogId, StatementBase stm
     /**
      * create the catalog instance from catalog log.
      */
-    public static CatalogIf constructorFromLog(CatalogLog log) throws DdlException {
-        return constructorCatalog(log.getCatalogId(), log.getCatalogName(), log.getResource(),
-                    log.getComment(), log.getProps());
+    public static CatalogIf createFromLog(CatalogLog log) throws DdlException {
+        return createCatalog(log.getCatalogId(), log.getCatalogName(), log.getResource(),
+                log.getComment(), log.getProps(), true);
     }
 
-    private static CatalogIf constructorCatalog(long catalogId, String name, String resource, String comment,
-                                                Map<String, String> props) throws DdlException {
+    /**
+     * create the catalog instance from creating statement.
+     */
+    public static CatalogIf createFromStmt(long catalogId, CreateCatalogStmt stmt)
+            throws DdlException {
+        return createCatalog(catalogId, stmt.getCatalogName(), stmt.getResource(),
+                stmt.getComment(), stmt.getProperties(), false);
+    }
+
+    private static CatalogIf createCatalog(long catalogId, String name, String resource, String comment,
+            Map<String, String> props, boolean isReplay) throws DdlException {
         // get catalog type from resource or properties
         String catalogType;
         if (!Strings.isNullOrEmpty(resource)) {
-            Resource catalogResource = Optional.ofNullable(Env.getCurrentEnv().getResourceMgr().getResource(resource))
-                    .orElseThrow(() -> new DdlException("Resource doesn't exist: " + resource));
-            catalogType = catalogResource.getType().name().toLowerCase();
-            if (props.containsKey(CatalogMgr.CATALOG_TYPE_PROP)) {
-                throw new DdlException("Can not set 'type' when creating catalog with resource");
+            Resource catalogResource = Env.getCurrentEnv().getResourceMgr().getResource(resource);
+            if (catalogResource == null) {

Review Comment:
   I can't think of a scenario how could this happen. If the resource doesn't exist, shouldn't it has already been dropped before creating the new catalog with this resource? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1565336331

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1565348236

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 33.83 seconds
    stream load tsv:          454 seconds loaded 74807831229 Bytes, about 157 MB/s
    stream load json:         22 seconds loaded 2358488459 Bytes, about 102 MB/s
    stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
    stream load parquet:          29 seconds loaded 861443392 Bytes, about 28 MB/s
    insert into select:          25.5 seconds inserted 10000000 Rows, about 392K ops/s
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230527105326_clickbench_pr_151819.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1565470681

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1565337087

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1566589607

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1567750967

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1566149116

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1565341634

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 34.67 seconds
    stream load tsv:          449 seconds loaded 74807831229 Bytes, about 158 MB/s
    stream load json:         22 seconds loaded 2358488459 Bytes, about 102 MB/s
    stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
    stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
    insert into select:          25.6 seconds inserted 10000000 Rows, about 390K ops/s
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230527104526_clickbench_pr_151808.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1565562983

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 34.43 seconds
    stream load tsv:          441 seconds loaded 74807831229 Bytes, about 161 MB/s
    stream load json:         22 seconds loaded 2358488459 Bytes, about 102 MB/s
    stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
    stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
    insert into select:          25.3 seconds inserted 10000000 Rows, about 395K ops/s
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230527161208_clickbench_pr_151918.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1565551715

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1567994547

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1565466546

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1565335515

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1566180664

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman commented on a diff in pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #20137:
URL: https://github.com/apache/doris/pull/20137#discussion_r1209258543


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/CatalogFactory.java:
##########
@@ -74,21 +71,33 @@ public static CatalogLog constructorCatalogLog(long catalogId, StatementBase stm
     /**
      * create the catalog instance from catalog log.
      */
-    public static CatalogIf constructorFromLog(CatalogLog log) throws DdlException {
-        return constructorCatalog(log.getCatalogId(), log.getCatalogName(), log.getResource(),
-                    log.getComment(), log.getProps());
+    public static CatalogIf createFromLog(CatalogLog log) throws DdlException {
+        return createCatalog(log.getCatalogId(), log.getCatalogName(), log.getResource(),
+                log.getComment(), log.getProps(), true);
     }
 
-    private static CatalogIf constructorCatalog(long catalogId, String name, String resource, String comment,
-                                                Map<String, String> props) throws DdlException {
+    /**
+     * create the catalog instance from creating statement.
+     */
+    public static CatalogIf createFromStmt(long catalogId, CreateCatalogStmt stmt)
+            throws DdlException {
+        return createCatalog(catalogId, stmt.getCatalogName(), stmt.getResource(),
+                stmt.getComment(), stmt.getProperties(), false);
+    }
+
+    private static CatalogIf createCatalog(long catalogId, String name, String resource, String comment,
+            Map<String, String> props, boolean isReplay) throws DdlException {
         // get catalog type from resource or properties
         String catalogType;
         if (!Strings.isNullOrEmpty(resource)) {
-            Resource catalogResource = Optional.ofNullable(Env.getCurrentEnv().getResourceMgr().getResource(resource))
-                    .orElseThrow(() -> new DdlException("Resource doesn't exist: " + resource));
-            catalogType = catalogResource.getType().name().toLowerCase();
-            if (props.containsKey(CatalogMgr.CATALOG_TYPE_PROP)) {
-                throw new DdlException("Can not set 'type' when creating catalog with resource");
+            Resource catalogResource = Env.getCurrentEnv().getResourceMgr().getResource(resource);
+            if (catalogResource == null) {

Review Comment:
   Yes, this is a bug, i don't know the reason, but it worth nothing to fix it because i decide to forbid creating catalog with resource. This operation makes things complex and hard to keep meta data consistency.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1566197797

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 35.64 seconds
    stream load tsv:          449 seconds loaded 74807831229 Bytes, about 158 MB/s
    stream load json:         23 seconds loaded 2358488459 Bytes, about 97 MB/s
    stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
    stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
    insert into select:          25.9 seconds inserted 10000000 Rows, about 386K ops/s
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230528165008_clickbench_pr_152319.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman commented on pull request #20137: [fix](catalog) fix create catalog with resource replay issue and kerberos auth issue

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #20137:
URL: https://github.com/apache/doris/pull/20137#issuecomment-1567231933

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org