You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/02/11 09:55:17 UTC
[GitHub] [activemq-artemis] jsmucr opened a new pull request #3451: Add a note about the `jms-client-id` session metadata to the docs
jsmucr opened a new pull request #3451:
URL: https://github.com/apache/activemq-artemis/pull/3451
I've added a note about how to identify an open core session via the management console by setting the `jmx-client-id` session metadata entry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #3451: Add a note about the `jms-client-id` session metadata to the docs
Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3451:
URL: https://github.com/apache/activemq-artemis/pull/3451#issuecomment-778414176
@jsmucr, it's not that the documentation isn't *useful*. It's simply that if core clients need functionality that they don't have (e.g. a way to uniquely identify themselves in the web console) then we should add that ability rather than using JMS implementation details in the core client. My goal is to make this ability more intuitive and less reliant on a hack. I apologize for any misunderstanding.
I'm curious...Did you ask about this subject yourself on the ActiveMQ user mailing list or Stack Overflow? If not, you might have saved yourself some trouble.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jsmucr commented on pull request #3451: Add a note about the `jms-client-id` session metadata to the docs
Posted by GitBox <gi...@apache.org>.
jsmucr commented on pull request #3451:
URL: https://github.com/apache/activemq-artemis/pull/3451#issuecomment-778581469
@jbertram I see, thank you.
I didn't ask there. It seems that I've got banned for some reason (not sure how that happened). I asked a couple of times to get unbanned via the form that the page offered to me but nobody responded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3451: Add a note about the `jms-client-id` session metadata to the docs
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3451:
URL: https://github.com/apache/activemq-artemis/pull/3451#discussion_r574604108
##########
File path: docs/user-manual/en/core.md
##########
@@ -159,6 +159,19 @@ end asynchronous systems which is not possible using the standard JMS API. For
more information on this advanced feature please see the section [Guarantees of
sends and commits](send-guarantees.md).
+> **Identifying your session**
Review comment:
these are all commented out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jsmucr commented on a change in pull request #3451: Add a note about the `jms-client-id` session metadata to the docs
Posted by GitBox <gi...@apache.org>.
jsmucr commented on a change in pull request #3451:
URL: https://github.com/apache/activemq-artemis/pull/3451#discussion_r574999601
##########
File path: docs/user-manual/en/core.md
##########
@@ -159,6 +159,19 @@ end asynchronous systems which is not possible using the standard JMS API. For
more information on this advanced feature please see the section [Guarantees of
sends and commits](send-guarantees.md).
+> **Identifying your session**
Review comment:
? I don't understand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jsmucr commented on pull request #3451: Add a note about the `jms-client-id` session metadata to the docs
Posted by GitBox <gi...@apache.org>.
jsmucr commented on pull request #3451:
URL: https://github.com/apache/activemq-artemis/pull/3451#issuecomment-777989106
I'm sorry that you don't find this useful. But please note that it took me a lot of googling before I found this approach somewhere in the depths of Stack Overflow. I'm pretty sure it should be written *somewhere*. So for those desperately searching, once again:
```java
session.addMetaData(ClientSession.JMS_SESSION_IDENTIFIER_PROPERTY, "jms-client-id"); // Or just ""
session.addMetaData("jms-client-id", "my-session");
```
Any other approach didn't work for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3451: Add a note about the `jms-client-id` session metadata to the docs
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3451:
URL: https://github.com/apache/activemq-artemis/pull/3451
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3451: Add a note about the `jms-client-id` session metadata to the docs
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3451:
URL: https://github.com/apache/activemq-artemis/pull/3451#discussion_r574604301
##########
File path: docs/user-manual/en/core.md
##########
@@ -159,6 +159,19 @@ end asynchronous systems which is not possible using the standard JMS API. For
more information on this advanced feature please see the section [Guarantees of
sends and commits](send-guarantees.md).
+> **Identifying your session**
+>
+> Assigning IDs to your core sessions can save you from a bit of headache
+> when monitoring and debugging the cluster using the [management console](management-console.md).
+> ```java
+> ClientSession session;
+> // ...
+> session.addMetaData(ClientSession.JMS_SESSION_IDENTIFIER_PROPERTY, "jms-client-id");
Review comment:
setClientID from JMS would do the same here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #3451: Add a note about the `jms-client-id` session metadata to the docs
Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3451:
URL: https://github.com/apache/activemq-artemis/pull/3451#issuecomment-777604206
FWIW, I think we should add a core-specific client identifier meta-data key so users don't need to use a JMS-specific one. It should be really easy to add. I'll open a Jira for that and send a PR soon (which will update this documentation).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jsmucr commented on a change in pull request #3451: Add a note about the `jms-client-id` session metadata to the docs
Posted by GitBox <gi...@apache.org>.
jsmucr commented on a change in pull request #3451:
URL: https://github.com/apache/activemq-artemis/pull/3451#discussion_r574999336
##########
File path: docs/user-manual/en/core.md
##########
@@ -159,6 +159,19 @@ end asynchronous systems which is not possible using the standard JMS API. For
more information on this advanced feature please see the section [Guarantees of
sends and commits](send-guarantees.md).
+> **Identifying your session**
+>
+> Assigning IDs to your core sessions can save you from a bit of headache
+> when monitoring and debugging the cluster using the [management console](management-console.md).
+> ```java
+> ClientSession session;
+> // ...
+> session.addMetaData(ClientSession.JMS_SESSION_IDENTIFIER_PROPERTY, "jms-client-id");
Review comment:
What if I don't use JMS though?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org