Time to turn off dependency change tracking in trunk?

[David Jencks <da...@yahoo.com>]

I'm getting annoyed with the changes to dependency.xml during the build and I don't think we are paying much attention to them -- I know I'm not -- and I expect we'll soon be building karaf features instead of plugins anyway so I'd like to stop generating and comparing these files.

Any objections?

thanks
david jencks

Re: Time to turn off dependency change tracking in trunk?

[Forrest Xia <fo...@gmail.com>]

yes, please turn it off by default.

Forrest

On Thu, Mar 3, 2011 at 10:33 AM, Shawn Jiang <ge...@gmail.com> wrote:

> Putting it to target is reasonable.
>
> Besides, I'd like to see off to be the default and add a switch to turn it
> on when needed.
>
>
> On Thu, Mar 3, 2011 at 10:30 AM, Kevan Miller <ke...@gmail.com>wrote:
>
>>
>> On Mar 2, 2011, at 8:30 PM, Ivan wrote:
>>
>> > How about just generating these files in the target folder for now,
>> sometimes, the dependency.xml and treelist.txt are helpful for me to find
>> why the unwanted artifact is imported.
>>
>> I see no reason to keep generating them and pumping them into svn. If Ivan
>> is finding them useful, for now, putting into target seems reasonable.
>>
>> --kevan
>
>
>
>
> --
> Shawn
>

Re: Time to turn off dependency change tracking in trunk?

[Shawn Jiang <ge...@gmail.com>]

Putting it to target is reasonable.

Besides, I'd like to see off to be the default and add a switch to turn it
on when needed.

On Thu, Mar 3, 2011 at 10:30 AM, Kevan Miller <ke...@gmail.com>wrote:

>
> On Mar 2, 2011, at 8:30 PM, Ivan wrote:
>
> > How about just generating these files in the target folder for now,
> sometimes, the dependency.xml and treelist.txt are helpful for me to find
> why the unwanted artifact is imported.
>
> I see no reason to keep generating them and pumping them into svn. If Ivan
> is finding them useful, for now, putting into target seems reasonable.
>
> --kevan




-- 
Shawn

Re: Time to turn off dependency change tracking in trunk?

[Kevan Miller <ke...@gmail.com>]

On Mar 2, 2011, at 8:30 PM, Ivan wrote:

> How about just generating these files in the target folder for now, sometimes, the dependency.xml and treelist.txt are helpful for me to find why the unwanted artifact is imported.

I see no reason to keep generating them and pumping them into svn. If Ivan is finding them useful, for now, putting into target seems reasonable.

--kevan

Re: Time to turn off dependency change tracking in trunk?

[Ivan <xh...@gmail.com>]

How about just generating these files in the target folder for now,
sometimes, the dependency.xml and treelist.txt are helpful for me to find
why the unwanted artifact is imported.

2011/3/3 David Jencks <da...@yahoo.com>

> I'm getting annoyed with the changes to dependency.xml during the build and
> I don't think we are paying much attention to them -- I know I'm not -- and
> I expect we'll soon be building karaf features instead of plugins anyway so
> I'd like to stop generating and comparing these files.
>
> Any objections?
>
> thanks
> david jencks




-- 
Ivan

Re: Time to turn off dependency change tracking in trunk?

[Jarek Gawor <jg...@gmail.com>]

#2 sounds reasonable so +1 to that.

Jarek

On Mon, Mar 7, 2011 at 2:41 PM, Kevan Miller <ke...@gmail.com> wrote:
>
> On Mar 3, 2011, at 12:14 PM, Jarek Gawor wrote:
>
>> Are karaf features built from the maven dependencies? If so, won't
>> that require the same tracking as we are doing now?
>>
>> I always found the dependencies.xml useful but I guess maybe I was the
>> only one that paid attention to it. It prevented the server from
>> having too much unnecessary stuff and probably improved build time a
>> bit (since less stuff was getting pulled in when building a plugin).
>
> You aren't the only one that found them useful. However, in our current mode of development, I don't think they are particularly useful. Dependencies are getting updated, but you don't see them until you're running an svn diff (or svn commit). IMO, that's too late. I think we have two options:
>
> 1) reenable the check that fails the build when dependencies change.
> 2) disable the dependency generation (or move dependencies to target), until we're ready to start (1) again
>
> I think we're going to need a thorough review of our dependencies. So, I'm ok with 2) until things settle down a bit...
>
> --kevan

Re: Time to turn off dependency change tracking in trunk?

[Kevan Miller <ke...@gmail.com>]

On Mar 3, 2011, at 12:14 PM, Jarek Gawor wrote:

> Are karaf features built from the maven dependencies? If so, won't
> that require the same tracking as we are doing now?
> 
> I always found the dependencies.xml useful but I guess maybe I was the
> only one that paid attention to it. It prevented the server from
> having too much unnecessary stuff and probably improved build time a
> bit (since less stuff was getting pulled in when building a plugin).

You aren't the only one that found them useful. However, in our current mode of development, I don't think they are particularly useful. Dependencies are getting updated, but you don't see them until you're running an svn diff (or svn commit). IMO, that's too late. I think we have two options:

1) reenable the check that fails the build when dependencies change.
2) disable the dependency generation (or move dependencies to target), until we're ready to start (1) again

I think we're going to need a thorough review of our dependencies. So, I'm ok with 2) until things settle down a bit...

--kevan

Re: Time to turn off dependency change tracking in trunk?

[Jarek Gawor <jg...@gmail.com>]

Are karaf features built from the maven dependencies? If so, won't
that require the same tracking as we are doing now?

I always found the dependencies.xml useful but I guess maybe I was the
only one that paid attention to it. It prevented the server from
having too much unnecessary stuff and probably improved build time a
bit (since less stuff was getting pulled in when building a plugin).

Putting the dependencies.xml into the target directory doesn't really
help. There won't be anything to compare the dependency information
against next time you do mvn clean. So all the usefulness of
dependency tracking is gone and at that point might as well just
disable the whole thing.

So I guess I would vote -0 on this proposal. But I'll be ok with
whatever the community decides.

Jarek

On Wed, Mar 2, 2011 at 8:05 PM, David Jencks <da...@yahoo.com> wrote:
> I'm getting annoyed with the changes to dependency.xml during the build and I don't think we are paying much attention to them -- I know I'm not -- and I expect we'll soon be building karaf features instead of plugins anyway so I'd like to stop generating and comparing these files.
>
> Any objections?
>
> thanks
> david jencks