You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/11/23 15:57:28 UTC
[GitHub] brodybits commented on a change in pull request #576: Improve target-dir restriction for detecting new android project…
brodybits commented on a change in pull request #576: Improve target-dir restriction for detecting new android project…
URL: https://github.com/apache/cordova-android/pull/576#discussion_r235979798
##########
File path: bin/templates/cordova/lib/pluginHandlers.js
##########
@@ -320,7 +320,7 @@ function generateAttributeError (attribute, element, id) {
function getInstallDestination (obj) {
var APP_MAIN_PREFIX = 'app/src/main';
- if (obj.targetDir.startsWith('app')) {
+ if (obj.targetDir.startsWith('app/')) {
Review comment:
What if a plugin author uses `target-dir` that starts with `app` but not `app/`?
What if a plugin author decides to specify `target-dir="app"`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org